validation on submit date

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/Loan.java

@@ -2020,7 +2020,7 @@ public class Loan extends AbstractPersistable<Long> {
         return this.submittedOnDate == null ? false : (new LocalDate(submittedOnDate)).isAfter(compareDate);
     }
 
-    private LocalDate getSubmittedOnDate() {
+    public LocalDate getSubmittedOnDate() {
         return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null);
     }
 

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java

@@ -151,14 +151,14 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
         final LoanProduct loanProduct = this.loanProductRepository.findOne(productId);
         if (loanProduct == null) { throw new LoanProductNotFoundException(productId); }
         
-        validateSubmittedOnDate(command, loanProduct);
-        
         this.loanProductCommandFromApiJsonDeserializer.validateMinMaxConstraints(command.parsedJson(), baseDataValidator, loanProduct);
         
         if (!dataValidationErrors.isEmpty()) { throw new PlatformApiDataValidationException(dataValidationErrors); }
 
         final Loan newLoanApplication = loanAssembler.assembleFrom(command, currentUser);
         
+        validateSubmittedOnDate(newLoanApplication);
+        
         final LoanProductRelatedDetail productRelatedDetail = newLoanApplication.repaymentScheduleDetail();
         this.fromApiJsonDeserializer.validateLoanTermAndRepaidEveryValues(newLoanApplication.getTermFrequency(), newLoanApplication.getTermPeriodFrequencyType(),
                 productRelatedDetail.getNumberOfRepayments(), productRelatedDetail.getRepayEvery(),
@@ -214,8 +214,6 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
 
             final Loan existingLoanApplication = retrieveLoanBy(loanId);
             
-            validateSubmittedOnDate(command, existingLoanApplication.loanProduct());
-            
             if (!existingLoanApplication.isSubmittedAndPendingApproval()) { throw new LoanApplicationNotInSubmittedAndPendingApprovalStateCannotBeModified(
                     loanId); }
 
@@ -246,6 +244,7 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
                 }
             }
             
+            validateSubmittedOnDate(existingLoanApplication);
             // validate min and maximum constraints
             this.fromApiJsonDeserializer.validateForModify(command.json());
             final LoanProductRelatedDetail productRelatedDetail = existingLoanApplication.repaymentScheduleDetail();
@@ -545,10 +544,10 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
         return loan;
     }
     
-    private void validateSubmittedOnDate(final JsonCommand command, final LoanProduct loanProduct) {
+    private void validateSubmittedOnDate(final Loan loan) {
-        final LocalDate startDate = loanProduct.getStartDate();
+        final LocalDate startDate = loan.loanProduct().getStartDate();
-        final LocalDate closeDate = loanProduct.getCloseDate();
+        final LocalDate closeDate = loan.loanProduct().getCloseDate();
-        final LocalDate submittedOnDate = command.localDateValueOfParameterNamed("submittedOnDate");
+        final LocalDate submittedOnDate = loan.getSubmittedOnDate();
 
         String defaultUserMessage = "";
         if (startDate != null && submittedOnDate.isBefore(startDate)) {