[FINERACT-1678] API for Business Step configuration fix
This commit is contained in:
committed by
Arnold Gálovics
parent
d75835170a
commit
0bbd825a46
+2
-1
@@ -21,6 +21,7 @@ package org.apache.fineract.cob.service;
|
|||||||
import com.google.common.base.Splitter;
|
import com.google.common.base.Splitter;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
import lombok.RequiredArgsConstructor;
|
import lombok.RequiredArgsConstructor;
|
||||||
|
import org.apache.fineract.cob.exceptions.BusinessStepNotBelongsToJobException;
|
||||||
import org.apache.fineract.commands.annotation.CommandType;
|
import org.apache.fineract.commands.annotation.CommandType;
|
||||||
import org.apache.fineract.commands.handler.NewCommandSourceHandler;
|
import org.apache.fineract.commands.handler.NewCommandSourceHandler;
|
||||||
import org.apache.fineract.infrastructure.core.api.JsonCommand;
|
import org.apache.fineract.infrastructure.core.api.JsonCommand;
|
||||||
@@ -37,7 +38,7 @@ public class BusinessStepConfigUpdateHandler implements NewCommandSourceHandler
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
@Transactional
|
@Transactional
|
||||||
public CommandProcessingResult processCommand(JsonCommand command) {
|
public CommandProcessingResult processCommand(JsonCommand command) throws BusinessStepNotBelongsToJobException {
|
||||||
List<String> split = Splitter.on("/").splitToList(command.getUrl());
|
List<String> split = Splitter.on("/").splitToList(command.getUrl());
|
||||||
String jobName = split.get(split.size() - 2);
|
String jobName = split.get(split.size() - 2);
|
||||||
if ("null".equals(jobName)) {
|
if ("null".equals(jobName)) {
|
||||||
|
|||||||
+45
@@ -0,0 +1,45 @@
|
|||||||
|
/**
|
||||||
|
* Licensed to the Apache Software Foundation (ASF) under one
|
||||||
|
* or more contributor license agreements. See the NOTICE file
|
||||||
|
* distributed with this work for additional information
|
||||||
|
* regarding copyright ownership. The ASF licenses this file
|
||||||
|
* to you under the Apache License, Version 2.0 (the
|
||||||
|
* "License"); you may not use this file except in compliance
|
||||||
|
* with the License. You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing,
|
||||||
|
* software distributed under the License is distributed on an
|
||||||
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||||
|
* KIND, either express or implied. See the License for the
|
||||||
|
* specific language governing permissions and limitations
|
||||||
|
* under the License.
|
||||||
|
*/
|
||||||
|
package org.apache.fineract.infrastructure.core.exceptionmapper;
|
||||||
|
|
||||||
|
import javax.ws.rs.core.MediaType;
|
||||||
|
import javax.ws.rs.core.Response;
|
||||||
|
import javax.ws.rs.ext.ExceptionMapper;
|
||||||
|
import javax.ws.rs.ext.Provider;
|
||||||
|
import lombok.extern.slf4j.Slf4j;
|
||||||
|
import org.apache.fineract.cob.exceptions.BusinessStepNotBelongsToJobException;
|
||||||
|
import org.apache.fineract.infrastructure.core.data.ApiParameterError;
|
||||||
|
import org.springframework.stereotype.Component;
|
||||||
|
|
||||||
|
@Provider
|
||||||
|
@Component
|
||||||
|
@Slf4j
|
||||||
|
public class BusinessStepNotBelongsToJobExceptionMapper implements ExceptionMapper<BusinessStepNotBelongsToJobException> {
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Response toResponse(BusinessStepNotBelongsToJobException exception) {
|
||||||
|
final String globalisationMessageCode = "error.msg.invalid.request.body";
|
||||||
|
final String defaultUserMessage = "One of the provided Business Steps does not belong to the provided Job Name.";
|
||||||
|
log.warn("Exception: {}, Message: {}", exception.getClass().getName(), defaultUserMessage);
|
||||||
|
|
||||||
|
final ApiParameterError error = ApiParameterError.generalError(globalisationMessageCode, defaultUserMessage);
|
||||||
|
|
||||||
|
return Response.status(Response.Status.BAD_REQUEST).entity(error).type(MediaType.APPLICATION_JSON).build();
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user