From 0cc18d7b8c223d4178bdc386f58c9e889abe987e Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Sat, 9 May 2020 19:13:32 +0200 Subject: [PATCH] fix obvious bug in Notification setActor() This method doesn't seem to be used anywhere, so it never mattered. Eclipse pointed out "The assignment to variable actorId has no effect". We should not ignore javac/Eclipse compiler warnings! => FINERACT-959 --- .../apache/fineract/notification/domain/Notification.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fineract-provider/src/main/java/org/apache/fineract/notification/domain/Notification.java b/fineract-provider/src/main/java/org/apache/fineract/notification/domain/Notification.java index ccbc85bf1..3eae975fb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/notification/domain/Notification.java +++ b/fineract-provider/src/main/java/org/apache/fineract/notification/domain/Notification.java @@ -51,7 +51,7 @@ public class Notification extends AbstractPersistableCustom { public Notification() {} public Notification(String objectType, Long objectIdentifier, String action, Long actorId, boolean isSystemGenerated, - String notificationContent, String createdAt) { + String notificationContent, String createdAt) { this.objectType = objectType; this.objectIdentifier = objectIdentifier; this.action = action; @@ -89,7 +89,7 @@ public class Notification extends AbstractPersistableCustom { return actorId; } - public void setActor(Long actor) { + public void setActor(Long actorId) { this.actorId = actorId; } @@ -108,4 +108,6 @@ public class Notification extends AbstractPersistableCustom { public void setNotificationContent(String notificationContent) { this.notificationContent = notificationContent; } + + } \ No newline at end of file