CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

mifosx-567 ensure duplicate externalId for staff and loan general valid json error response

Browse Source
This commit is contained in:
John Woodlock
2013-08-01 14:35:56 +01:00
parent 627a754262
commit 0da7dabf0c
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mifosng-provider/src/main/java/org/mifosplatform/organisation/staff/service/StaffWritePlatformServiceJpaRepositoryImpl.java
+1 -1
View File
@@ -98,7 +98,7 @@ public class StaffWritePlatformServiceJpaRepositoryImpl implements StaffWritePla
} }
if (!changesOnly.isEmpty()) { if (!changesOnly.isEmpty()) {
this.staffRepository.save(staffForUpdate); this.staffRepository.saveAndFlush(staffForUpdate);
} }
return new CommandProcessingResultBuilder().withCommandId(command.commandId()).withEntityId(staffId) return new CommandProcessingResultBuilder().withCommandId(command.commandId()).withEntityId(staffId)
mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java
+8 -3
View File
@@ -140,6 +140,7 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
@Override @Override
public CommandProcessingResult submitApplication(final JsonCommand command) { public CommandProcessingResult submitApplication(final JsonCommand command) {
try {
final AppUser currentUser = context.authenticatedUser(); final AppUser currentUser = context.authenticatedUser();
this.fromApiJsonDeserializer.validateForCreate(command.json()); this.fromApiJsonDeserializer.validateForCreate(command.json());
@@ -201,8 +202,12 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
.withGroupId(newLoanApplication.getGroupId()) // .withGroupId(newLoanApplication.getGroupId()) //
.withLoanId(newLoanApplication.getId()) // .withLoanId(newLoanApplication.getId()) //
.build(); .build();
} catch (DataIntegrityViolationException dve) {
handleDataIntegrityIssues(command, dve);
return CommandProcessingResult.empty();
}
} }
@Transactional @Transactional
@Override @Override
public CommandProcessingResult modifyApplication(final Long loanId, final JsonCommand command) { public CommandProcessingResult modifyApplication(final Long loanId, final JsonCommand command) {
@@ -379,8 +384,8 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
logAsErrorUnexpectedDataIntegrityException(dve); logAsErrorUnexpectedDataIntegrityException(dve);
throw new PlatformDataIntegrityException("error.msg.unknown.data.integrity.issue", "Unknown data integrity issue with resource."); throw new PlatformDataIntegrityException("error.msg.unknown.data.integrity.issue", "Unknown data integrity issue with resource.");
} }
private void logAsErrorUnexpectedDataIntegrityException(final DataIntegrityViolationException dve) { private void logAsErrorUnexpectedDataIntegrityException(final DataIntegrityViolationException dve) {
logger.error(dve.getMessage(), dve); logger.error(dve.getMessage(), dve);
} }