From 0eee0ff7754dc931527af98be616f43aecc40c9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Vorburger=20=E2=9B=91=EF=B8=8F?= Date: Fri, 15 May 2020 22:31:16 +0200 Subject: [PATCH] make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859) This is just a first step - we should aim for -Xlint:all! ;) --- fineract-provider/build.gradle | 2 +- .../apache/fineract/integrationtests/SchedulerJobsTest.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle index 18cc67ab8..5bcba348f 100644 --- a/fineract-provider/build.gradle +++ b/fineract-provider/build.gradle @@ -284,7 +284,7 @@ configurations { } tasks.withType(JavaCompile) { - options.compilerArgs << '-Xlint:unchecked' + options.compilerArgs += ["-Xlint:unchecked", "-Werror"] // TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X") options.deprecation = true } diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java index 623cfd807..d00e03a68 100644 --- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java +++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java @@ -108,7 +108,7 @@ public class SchedulerJobsTest { Map schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId); // Executing Scheduler Job - schedulerJobHelper.runSchedulerJob(requestSpec, jobId.toString()); + SchedulerJobHelper.runSchedulerJob(requestSpec, jobId.toString()); // Retrieving Scheduler Job by ID schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId); @@ -121,6 +121,7 @@ public class SchedulerJobsTest { assertNotNull(schedulerJob); System.out.println("Job " + jobId +" is Still Running"); } + @SuppressWarnings({ "unchecked", "rawtypes" }) List jobHistoryData = schedulerJobHelper.getSchedulerJobHistory(jobId); // Verifying the Status of the Recently executed Scheduler Job