From 1099e730396ee2e2dcbf33c7bc7e8d9d4ae58ee6 Mon Sep 17 00:00:00 2001 From: Pramod Nuthakki Date: Fri, 29 Nov 2013 15:11:34 +0530 Subject: [PATCH] added empty data check --- ...lEntryRunningBalanceUpdateServiceImpl.java | 32 ++++++++++--------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/mifosng-provider/src/main/java/org/mifosplatform/accounting/journalentry/service/JournalEntryRunningBalanceUpdateServiceImpl.java b/mifosng-provider/src/main/java/org/mifosplatform/accounting/journalentry/service/JournalEntryRunningBalanceUpdateServiceImpl.java index a6be72595..7d7fa3a21 100755 --- a/mifosng-provider/src/main/java/org/mifosplatform/accounting/journalentry/service/JournalEntryRunningBalanceUpdateServiceImpl.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/accounting/journalentry/service/JournalEntryRunningBalanceUpdateServiceImpl.java @@ -149,23 +149,25 @@ public class JournalEntryRunningBalanceUpdateServiceImpl implements JournalEntry List entryDatas = jdbcTemplate.query(entryMapper.organizationRunningBalanceSchema(), entryMapper, new Object[] { entityDate }); - String[] updateSql = new String[entryDatas.size()]; - int i = 0; - for (JournalEntryData entryData : entryDatas) { - Map officeRunningBalanceMap = null; - if (officesRunningBalance.containsKey(entryData.getOfficeId())) { - officeRunningBalanceMap = officesRunningBalance.get(entryData.getOfficeId()); - } else { - officeRunningBalanceMap = new HashMap(); - officesRunningBalance.put(entryData.getOfficeId(), officeRunningBalanceMap); + if(entryDatas.size()>0){ + String[] updateSql = new String[entryDatas.size()]; + int i = 0; + for (JournalEntryData entryData : entryDatas) { + Map officeRunningBalanceMap = null; + if (officesRunningBalance.containsKey(entryData.getOfficeId())) { + officeRunningBalanceMap = officesRunningBalance.get(entryData.getOfficeId()); + } else { + officeRunningBalanceMap = new HashMap(); + officesRunningBalance.put(entryData.getOfficeId(), officeRunningBalanceMap); + } + BigDecimal officeRunningBalance = calculateRunningBalance(entryData, officeRunningBalanceMap); + BigDecimal runningBalance = calculateRunningBalance(entryData, runningBalanceMap); + String sql = "UPDATE acc_gl_journal_entry je SET je.is_running_balance_caculated=1, je.organization_running_balance=" + + runningBalance + ",je.office_running_balance=" + officeRunningBalance + " WHERE je.id=" + entryData.getId(); + updateSql[i++] = sql; } - BigDecimal officeRunningBalance = calculateRunningBalance(entryData, officeRunningBalanceMap); - BigDecimal runningBalance = calculateRunningBalance(entryData, runningBalanceMap); - String sql = "UPDATE acc_gl_journal_entry je SET je.is_running_balance_caculated=1, je.organization_running_balance=" - + runningBalance + ",je.office_running_balance=" + officeRunningBalance + " WHERE je.id=" + entryData.getId(); - updateSql[i++] = sql; + this.jdbcTemplate.batchUpdate(updateSql); } - this.jdbcTemplate.batchUpdate(updateSql); }