From 111e28ed1b1077544c022103890b3cab4d374770 Mon Sep 17 00:00:00 2001 From: Adam Saghy Date: Tue, 11 Jun 2024 19:28:55 +0200 Subject: [PATCH] FINERACT-2081: Fix linked account validation --- .../loanaccount/serialization/LoanApplicationValidator.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java index 01bb58223..d8d78ed21 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java @@ -1525,13 +1525,10 @@ public final class LoanApplicationValidator { } public void validateLinkedSavingsAccount(final JsonElement element, DataValidatorBuilder baseDataValidator) { - final boolean linkedAccountIdWasProvided = this.fromApiJsonHelper.parameterExists(LoanApiConstants.linkAccountIdParameterName, - element); final Long linkedAccountId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.linkAccountIdParameterName, element); - if (linkedAccountIdWasProvided && linkedAccountId != null) { + if (linkedAccountId != null) { baseDataValidator.reset().parameter(LoanApiConstants.linkAccountIdParameterName).value(linkedAccountId).ignoreIfNull() .longGreaterThanZero(); - final SavingsAccount savingsAccount = savingsAccountRepository.findOneWithNotFoundDetection(linkedAccountId); final Long clientId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.clientIdParameterName, element); if (savingsAccount.isNotActive()) {