Spotbugs adjustments

fineract-core/src/main/java/org/apache/fineract/infrastructure/core/exception/MultiException.java

@@ -59,6 +59,7 @@ public class MultiException extends Exception {
         this.throwables = new ArrayList<>(problems);
     }
 
+    @SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
     public MultiException(List<Throwable> problems) {
         this("MultiException with " + problems.size() + " contained causes (details available)", problems);
     }

fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/messaging/EventAssertion.java

@@ -21,6 +21,7 @@ package org.apache.fineract.test.messaging;
 import static java.lang.String.format;
 import static org.awaitility.Awaitility.await;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.math.BigDecimal;
 import java.time.Duration;
 import java.time.LocalDate;
@@ -38,6 +39,7 @@ import org.springframework.stereotype.Component;
 
 @RequiredArgsConstructor
 @Component
+@SuppressFBWarnings({ "VA_FORMAT_STRING_USES_NEWLINE" })
 public class EventAssertion {
 
     private final EventStore eventStore;

fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/support/loader/FineractConfigLoader.java

@@ -20,11 +20,13 @@ package org.apache.fineract.test.support.loader;
 
 import static org.apache.commons.collections4.CollectionUtils.isEmpty;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
+@SuppressFBWarnings({ "VA_FORMAT_STRING_USES_NEWLINE" })
 public final class FineractConfigLoader {
 
     public static final String FINERACT_TEST_CONFIG_LOCATION = "META-INF/fineract-test.config";

fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/support/loader/PropertiesResourceLoader.java

@@ -18,6 +18,7 @@
  */
 package org.apache.fineract.test.support.loader;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.net.URL;
 import java.util.ArrayList;
@@ -32,6 +33,7 @@ import org.springframework.core.io.UrlResource;
 import org.springframework.core.io.support.PropertiesLoaderUtils;
 import org.springframework.util.StringUtils;
 
+@SuppressFBWarnings({ "VA_FORMAT_STRING_USES_NEWLINE" })
 public final class PropertiesResourceLoader {
 
     private PropertiesResourceLoader() {}

fineract-provider/src/main/java/org/apache/fineract/cob/listener/COBExecutionListenerRunner.java

@@ -18,6 +18,7 @@
  */
 package org.apache.fineract.cob.listener;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -30,6 +31,7 @@ public class COBExecutionListenerRunner implements JobExecutionListener {
     private final List<FineractCOBBeforeJobListener> beforeJobListeners = new ArrayList<>();
     private final List<FineractCOBAfterJobListener> afterJobListeners = new ArrayList<>();
 
+    @SuppressFBWarnings({ "CT_CONSTRUCTOR_THROW" })
     public COBExecutionListenerRunner(ApplicationContext applicationContext, String jobName) {
         addBeforeListeners(applicationContext, jobName);
         addAfterListeners(applicationContext, jobName);

fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/diagnostics/performance/sampling/output/SamplingDataPrinter.java

@@ -53,6 +53,7 @@ public class SamplingDataPrinter {
         }
     }
 
+    @SuppressFBWarnings({ "VA_FORMAT_STRING_USES_NEWLINE" })
     private String getFormattedSamplingData(Class<?> clazz, SamplingData samplingData) {
         if (clazz != null && samplingData != null) {
             Map<String, List<Duration>> timings = samplingData.getTimings();

fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/service/reaging/LoanReAgingValidatorTest.java

@@ -23,6 +23,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.mock;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.time.Clock;
 import java.time.LocalDate;
 import java.time.LocalTime;
@@ -53,6 +54,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
+@SuppressFBWarnings({ "VA_FORMAT_STRING_USES_NEWLINE" })
 class LoanReAgingValidatorTest {
 
     public static final String DATE_FORMAT = "dd MMMM yyyy";

fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/service/reamortization/LoanReAmortizationValidatorTest.java

@@ -23,6 +23,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.mock;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.time.Clock;
 import java.time.LocalDate;
 import java.time.LocalTime;
@@ -52,6 +53,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
+@SuppressFBWarnings({ "VA_FORMAT_STRING_USES_NEWLINE" })
 class LoanReAmortizationValidatorTest {
 
     private final LocalDate actualDate = LocalDate.now(Clock.systemUTC());