Allow disbursementDataArray empty instead of null (#2499)
Co-authored-by: Jose Alberto Hernandez <alberto@MacBook-Pro.local>
This commit is contained in:
co-authored by
Jose Alberto Hernandez
parent
eea635e90a
commit
13d587a951
+1
-1
@@ -1609,7 +1609,7 @@ public class Loan extends AbstractAuditableWithUTCDateTimeCustom {
|
|||||||
final JsonArray disbursementDataArray = command.arrayOfParameterNamed(LoanApiConstants.disbursementDataParameterName);
|
final JsonArray disbursementDataArray = command.arrayOfParameterNamed(LoanApiConstants.disbursementDataParameterName);
|
||||||
|
|
||||||
if (loanProduct.isDisallowExpectedDisbursements()) {
|
if (loanProduct.isDisallowExpectedDisbursements()) {
|
||||||
if (disbursementDataArray != null) {
|
if (!disbursementDataArray.isEmpty()) {
|
||||||
final String errorMessage = "For this loan product, disbursement details are not allowed";
|
final String errorMessage = "For this loan product, disbursement details are not allowed";
|
||||||
throw new MultiDisbursementDataNotAllowedException(LoanApiConstants.disbursementDataParameterName, errorMessage);
|
throw new MultiDisbursementDataNotAllowedException(LoanApiConstants.disbursementDataParameterName, errorMessage);
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-1
@@ -2883,7 +2883,7 @@ public class LoanWritePlatformServiceJpaRepositoryImpl implements LoanWritePlatf
|
|||||||
final JsonArray disbursementDataArray = command.arrayOfParameterNamed(LoanApiConstants.disbursementDataParameterName);
|
final JsonArray disbursementDataArray = command.arrayOfParameterNamed(LoanApiConstants.disbursementDataParameterName);
|
||||||
|
|
||||||
if (isDisallowExpectedDisbursements) {
|
if (isDisallowExpectedDisbursements) {
|
||||||
if (disbursementDataArray != null) {
|
if (!disbursementDataArray.isEmpty()) {
|
||||||
final String errorMessage = "For this loan product, disbursement details are not allowed";
|
final String errorMessage = "For this loan product, disbursement details are not allowed";
|
||||||
throw new MultiDisbursementDataNotAllowedException(LoanApiConstants.disbursementDataParameterName, errorMessage);
|
throw new MultiDisbursementDataNotAllowedException(LoanApiConstants.disbursementDataParameterName, errorMessage);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user