From 16a69e7a4ccd361037bca4e876dc692e154ff70d Mon Sep 17 00:00:00 2001
From: Percy Ayuk Ashu <percyayukashu@gmail.com>
Date: Tue, 2 Jun 2020 17:32:52 +0100
Subject: [PATCH] FINERACT-822 enable ArgumentSelectionDefectChecker warning
 (#961)

---
 fineract-provider/build.gradle                             | 1 -
 .../service/CreditBureauReadPlatformServiceImpl.java       | 2 +-
 .../hooks/service/HookReadPlatformService.java             | 2 +-
 .../hooks/service/HookReadPlatformServiceImpl.java         | 7 +++----
 4 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle
index 3ca9e70de..2f13ce4b6 100644
--- a/fineract-provider/build.gradle
+++ b/fineract-provider/build.gradle
@@ -324,7 +324,6 @@ tasks.withType(JavaCompile) {
                 "BadImport",
                 "UnusedMethod",
                 "ModifiedButNotUsed",
-                "ArgumentSelectionDefectChecker",
                 "JodaPlusMinusLong",
                 "TypeParameterUnusedInFormals",
                 "DoubleBraceInitialization",
diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadPlatformServiceImpl.java
index 2f9ad884e..f4d1196cc 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadPlatformServiceImpl.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadPlatformServiceImpl.java
@@ -58,7 +58,7 @@ public class CreditBureauReadPlatformServiceImpl implements CreditBureauReadPlat
             final String cbSummary = rs.getString("cbSummary");
             final long implementationKey = rs.getLong("implementationKey");
 
-            return CreditBureauData.instance(id, name, product, country, cbSummary, implementationKey);
+            return CreditBureauData.instance(id, name, country, product, cbSummary, implementationKey);
 
         }
     }
diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java
index 4f175b58b..2c0205659 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java
@@ -29,7 +29,7 @@ public interface HookReadPlatformService {
 
     HookData retrieveHook(Long hookId);
 
-    List<Hook> retrieveHooksByEvent(final String actionName, final String entityName);
+    List<Hook> retrieveHooksByEvent(final String entityName,final String actionName);
 
     HookData retrieveNewHookDetails(String templateName);
 }
diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java
index 6a6897fae..3f3923675 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java
@@ -84,11 +84,10 @@ public class HookReadPlatformServiceImpl implements HookReadPlatformService {
 
     @Override
     @Cacheable(value = "hooks", key = "T(org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil).getTenant().getTenantIdentifier().concat('HK')")
-    public List<Hook> retrieveHooksByEvent(final String actionName,
-            final String entityName) {
+    public List<Hook> retrieveHooksByEvent(final String entityName, final String actionName) {
 
-        return this.hookRepository.findAllHooksListeningToEvent(actionName,
-                entityName);
+        return this.hookRepository.findAllHooksListeningToEvent(entityName,
+                actionName);
     }
 
     @Override