From 184ec07487b96ee1027c0f2645689894a0bfba36 Mon Sep 17 00:00:00 2001 From: John Woodlock Date: Wed, 5 Dec 2012 11:44:31 +0000 Subject: [PATCH] minor changes for reducing console logging --- .../commands/service/ChangeDetectionServiceJdbc.java | 7 ++++++- .../dataqueries/service/GenericDataServiceImpl.java | 10 +++++----- .../organisation/staff/api/StaffApiResource.java | 2 +- .../portfolio/client/api/ClientsApiResource.java | 2 +- .../portfolio/group/api/GroupsApiResource.java | 2 +- mifosng-provider/src/main/resources/logback.xml | 1 + 6 files changed, 15 insertions(+), 9 deletions(-) diff --git a/mifosng-provider/src/main/java/org/mifosplatform/commands/service/ChangeDetectionServiceJdbc.java b/mifosng-provider/src/main/java/org/mifosplatform/commands/service/ChangeDetectionServiceJdbc.java index a27a80f13..de89d5009 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/commands/service/ChangeDetectionServiceJdbc.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/commands/service/ChangeDetectionServiceJdbc.java @@ -3,15 +3,20 @@ package org.mifosplatform.commands.service; import org.mifosplatform.infrastructure.core.api.PortfolioApiDataConversionService; import org.mifosplatform.infrastructure.core.serialization.CommandSerializer; import org.mifosplatform.infrastructure.core.serialization.DefaultToApiJsonSerializer; +import org.mifosplatform.infrastructure.dataqueries.service.ReadWriteNonCoreDataServiceImpl; import org.mifosplatform.portfolio.client.command.ClientCommand; import org.mifosplatform.portfolio.client.data.ClientData; import org.mifosplatform.portfolio.client.service.ClientReadPlatformService; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; @Service public class ChangeDetectionServiceJdbc implements ChangeDetectionService { + private final static Logger logger = LoggerFactory.getLogger(ChangeDetectionServiceJdbc.class); + private final PortfolioApiDataConversionService apiDataConversionService; private final ClientReadPlatformService clientReadPlatformService; private final CommandSerializer commandSerializerService; @@ -29,7 +34,7 @@ public class ChangeDetectionServiceJdbc implements ChangeDetectionService { @Override public String detectChangesOnUpdate(final String resourceName, final Long resourceId, final String commandSerializedAsJson) { - +logger.info(resourceName + ": ID: " + resourceId + " JSON: " + commandSerializedAsJson); String changesOnlyJson = ""; if ("clients".equalsIgnoreCase(resourceName)) { diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/service/GenericDataServiceImpl.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/service/GenericDataServiceImpl.java index aacebabce..d84e21cdf 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/service/GenericDataServiceImpl.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/service/GenericDataServiceImpl.java @@ -64,7 +64,7 @@ public class GenericDataServiceImpl implements GenericDataService { } long elapsed = System.currentTimeMillis() - startTime; - logger.info("Elapsed Time: " + elapsed + " SQL: " + sql); + //logger.info("Elapsed Time: " + elapsed + " SQL: " + sql); return crs; } @@ -85,7 +85,7 @@ public class GenericDataServiceImpl implements GenericDataService { } long elapsed = System.currentTimeMillis() - startTime; - logger.info("Elapsed Time FOR UPDATE: " + elapsed + " SQL: " + sql); + //logger.info("Elapsed Time FOR UPDATE: " + elapsed + " SQL: " + sql); } @Override @@ -165,14 +165,14 @@ public class GenericDataServiceImpl implements GenericDataService { writer.append("["); List columnHeaders = grs.getColumnHeaders(); - logger.info("NO. of Columns: " + columnHeaders.size()); + //logger.info("NO. of Columns: " + columnHeaders.size()); List data = grs.getData(); List row; Integer rSize; String currColType; String currVal; - logger.info("NO. of Rows: " + data.size()); + //logger.info("NO. of Rows: " + data.size()); for (int i = 0; i < data.size(); i++) { writer.append("\n{"); @@ -212,7 +212,7 @@ public class GenericDataServiceImpl implements GenericDataService { } private void dbClose(Statement db_statement, Connection db_connection) { - logger.debug("dbClose"); + //logger.debug("dbClose"); try { if (db_statement != null) { db_statement.close(); diff --git a/mifosng-provider/src/main/java/org/mifosplatform/organisation/staff/api/StaffApiResource.java b/mifosng-provider/src/main/java/org/mifosplatform/organisation/staff/api/StaffApiResource.java index 999cde341..e7bf9ac08 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/organisation/staff/api/StaffApiResource.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/organisation/staff/api/StaffApiResource.java @@ -155,7 +155,7 @@ public class StaffApiResource { if (StringUtils.isNotBlank(extraCriteria)) { extraCriteria = extraCriteria.substring(4); } - logger.debug("extraCriteria; " + extraCriteria); + //logger.debug("extraCriteria; " + extraCriteria); return extraCriteria; } diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/client/api/ClientsApiResource.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/client/api/ClientsApiResource.java index 471673bde..e7718c978 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/client/api/ClientsApiResource.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/client/api/ClientsApiResource.java @@ -158,7 +158,7 @@ public class ClientsApiResource { extraCriteria = extraCriteria.substring(4); } - logger.info("extraCriteria; " + extraCriteria); + //logger.info("extraCriteria; " + extraCriteria); return extraCriteria; } diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/group/api/GroupsApiResource.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/group/api/GroupsApiResource.java index 6b78f14fe..45892f656 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/group/api/GroupsApiResource.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/group/api/GroupsApiResource.java @@ -267,7 +267,7 @@ public class GroupsApiResource { extraCriteria = extraCriteria.substring(4); } - logger.info("extraCriteria; " + extraCriteria); + //logger.info("extraCriteria; " + extraCriteria); return extraCriteria; } diff --git a/mifosng-provider/src/main/resources/logback.xml b/mifosng-provider/src/main/resources/logback.xml index 25059a961..aff55439a 100644 --- a/mifosng-provider/src/main/resources/logback.xml +++ b/mifosng-provider/src/main/resources/logback.xml @@ -18,6 +18,7 @@ +