FINERACT-2181: fixed ConfigurationReadPlatformServiceImpl to handle not found cases, added tests

integration-tests/src/test/java/org/apache/fineract/integrationtests/GlobalConfigurationTest.java

@@ -18,6 +18,7 @@
  */
 package org.apache.fineract.integrationtests;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -27,6 +28,7 @@ import io.restassured.builder.ResponseSpecBuilder;
 import io.restassured.http.ContentType;
 import io.restassured.specification.RequestSpecification;
 import io.restassured.specification.ResponseSpecification;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.fineract.client.models.GetGlobalConfigurationsResponse;
 import org.apache.fineract.client.models.GlobalConfigurationPropertyData;
 import org.apache.fineract.client.models.PutGlobalConfigurationsRequest;
@@ -96,6 +98,22 @@ public class GlobalConfigurationTest {
         }
     }
 
+    @Test
+    public void testGetConfigurationPropertyById() {
+        Long configId = 1L;
+        GlobalConfigurationPropertyData configuration = assertDoesNotThrow(
+                () -> globalConfigurationHelper.getGlobalConfigurationById(configId));
+        assertTrue(StringUtils.isNotBlank(configuration.getName()));
+    }
+
+    @Test
+    public void testNotExistingConfigurationProperty() {
+        String notExistingConfigName = "not-existing-configuration";
+        CallFailedRuntimeException exception = assertThrows(CallFailedRuntimeException.class,
+                () -> globalConfigurationHelper.getGlobalConfigurationByName(notExistingConfigName));
+        assertEquals(404, exception.getResponse().code());
+    }
+
     @Test
     public void testPasswordUpdateFailing() {
         String configName = GlobalConfigurationConstants.FORCE_PASSWORD_RESET_DAYS;

integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanCatchUpIntegrationTest.java

@@ -52,8 +52,10 @@ import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanSchedul
 import org.apache.http.HttpStatus;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
 
+@Order(1)
 public class LoanCatchUpIntegrationTest extends BaseLoanIntegrationTest {
 
     private static final String REPAYMENT_LOAN_PERMISSION = "REPAYMENT_LOAN";

integration-tests/src/test/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java

@@ -52,6 +52,11 @@ public class GlobalConfigurationHelper {
         return Calls.ok(FineractClientHelper.getFineractClient().globalConfigurations.retrieveOneByName(configName));
     }
 
+    public GlobalConfigurationPropertyData getGlobalConfigurationById(final Long configId) {
+        log.info("------------------------ RETRIEVING GLOBAL CONFIGURATION BY ID -------------------------");
+        return Calls.ok(FineractClientHelper.getFineractClient().globalConfigurations.retrieveOne3(configId));
+    }
+
     // TODO: This is quite a bad pattern and adds a lot of time to individual test executions
     public void resetAllDefaultGlobalConfigurations() {