Do not expose getApiClient() in FineractClient (FINERACT-1220)
Because FineractClient is about to not use Swagger's ApiClient anymore.
This commit is contained in:
committed by
Michael Vorburger ⛑️
parent
800b7e07ad
commit
27bebff4ac
@@ -138,7 +138,7 @@ import org.apache.fineract.client.services.UsersApi;
|
|||||||
import org.apache.fineract.client.services.WorkingDaysApi;
|
import org.apache.fineract.client.services.WorkingDaysApi;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Fineract Client Java SDK API entry point. This is recommended to be used instead of {@link ApiClient}.
|
* Fineract Client Java SDK API entry point. Use this instead of the {@link ApiClient}.
|
||||||
*
|
*
|
||||||
* @author Michael Vorburger.ch
|
* @author Michael Vorburger.ch
|
||||||
*/
|
*/
|
||||||
@@ -395,7 +395,7 @@ public final class FineractClient {
|
|||||||
public Builder logging(Level level) {
|
public Builder logging(Level level) {
|
||||||
HttpLoggingInterceptor logging = new HttpLoggingInterceptor();
|
HttpLoggingInterceptor logging = new HttpLoggingInterceptor();
|
||||||
logging.setLevel(level);
|
logging.setLevel(level);
|
||||||
getApiClient().getOkBuilder().addInterceptor(logging);
|
apiClient.getOkBuilder().addInterceptor(logging);
|
||||||
return this;
|
return this;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -458,13 +458,23 @@ public final class FineractClient {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Obtain the internal Retrofit ApiClient. This method is typically not required to be invoked for simple API
|
* Obtain the internal Retrofit Builder. This method is typically not required to be invoked for simple API
|
||||||
* usages, but can be a handy back door for non-trivial advanced customizations of the API client.
|
* usages, but can be a handy back door for non-trivial advanced customizations of the API client.
|
||||||
*
|
*
|
||||||
* @return the {@link ApiClient} which {@link #build()} will use.
|
* @return the {@link ApiClient} which {@link #build()} will use.
|
||||||
*/
|
*/
|
||||||
public ApiClient getApiClient() {
|
public retrofit2.Retrofit.Builder getRetrofitBuilder() {
|
||||||
return apiClient;
|
return apiClient.getAdapterBuilder();
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Obtain the internal OkHttp Builder. This method is typically not required to be invoked for simple API
|
||||||
|
* usages, but can be a handy back door for non-trivial advanced customizations of the API client.
|
||||||
|
*
|
||||||
|
* @return the {@link ApiClient} which {@link #build()} will use.
|
||||||
|
*/
|
||||||
|
public okhttp3.OkHttpClient.Builder getOkBuilder() {
|
||||||
|
return apiClient.getOkBuilder();
|
||||||
}
|
}
|
||||||
|
|
||||||
private <T> T has(String propertyName, T value) throws IllegalStateException {
|
private <T> T has(String propertyName, T value) throws IllegalStateException {
|
||||||
|
|||||||
+9
-1
@@ -54,11 +54,19 @@ public class FineractClientTest {
|
|||||||
checkClients(fineract);
|
checkClients(fineract);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@Disabled // TODO FINERACT-1220
|
||||||
|
void testOfficesDateFormat() throws IOException {
|
||||||
|
FineractClient fineract = FineractClient.builder().baseURL("https://demo.fineract.dev/fineract-provider/api/v1/").tenant("default")
|
||||||
|
.basicAuth("mifos", "password").insecure(true).build();
|
||||||
|
ok(fineract.offices.retrieveOffices(true, null, null));
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
@Disabled // TODO remove Ignore once https://issues.apache.org/jira/browse/FINERACT-1221 is fixed
|
@Disabled // TODO remove Ignore once https://issues.apache.org/jira/browse/FINERACT-1221 is fixed
|
||||||
void testInvalidOperations() throws IOException {
|
void testInvalidOperations() throws IOException {
|
||||||
FineractClient.Builder builder = FineractClient.builder().baseURL("http://test/").tenant("default").basicAuth("mifos", "password");
|
FineractClient.Builder builder = FineractClient.builder().baseURL("http://test/").tenant("default").basicAuth("mifos", "password");
|
||||||
builder.getApiClient().getAdapterBuilder().validateEagerly(true); // see FINERACT-1221
|
builder.getRetrofitBuilder().validateEagerly(true); // see FINERACT-1221
|
||||||
builder.build();
|
builder.build();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user