From 2cae5521269fbd33d6f5b07f6887cefc8790b633 Mon Sep 17 00:00:00 2001 From: BLasan Date: Sun, 30 May 2021 16:24:10 +0530 Subject: [PATCH] Fix: Integration test - loanWithChargesOfTypeAmountPercentageAndPeriodicAccrualAccountingEnabled --- ...AccrualBasedAccountingProcessorForLoan.java | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java index 620979f3e..eb232595d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java @@ -211,10 +211,6 @@ public class AccrualBasedAccountingProcessorForLoan implements AccountingProcess } else { accountMap.put(account, interestAmount); } - for (Map.Entry entry : accountMap.entrySet()) { - this.helper.createCreditJournalEntryOrReversalForLoan(office, currencyCode, loanId, transactionId, transactionDate, - entry.getValue(), isReversal, entry.getKey()); - } } // handle fees payment of writeOff (and reversals) @@ -268,11 +264,6 @@ public class AccrualBasedAccountingProcessorForLoan implements AccountingProcess accountMap.put(account, penaltiesAmount); } } - for (Map.Entry entry : accountMap.entrySet()) { - this.helper.createCreditJournalEntryOrReversalForLoan(office, currencyCode, loanId, transactionId, transactionDate, - entry.getValue(), isReversal, entry.getKey()); - } - } if (overPaymentAmount != null && !(overPaymentAmount.compareTo(BigDecimal.ZERO) == 0)) { @@ -285,10 +276,11 @@ public class AccrualBasedAccountingProcessorForLoan implements AccountingProcess } else { accountMap.put(account, overPaymentAmount); } - for (Map.Entry entry : accountMap.entrySet()) { - this.helper.createCreditJournalEntryOrReversalForLoan(office, currencyCode, loanId, transactionId, transactionDate, - entry.getValue(), isReversal, entry.getKey()); - } + } + + for (Map.Entry entry : accountMap.entrySet()) { + this.helper.createCreditJournalEntryOrReversalForLoan(office, currencyCode, loanId, transactionId, transactionDate, + entry.getValue(), isReversal, entry.getKey()); } /**