CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

FINERACT-2050: Fix client transfer loan status staying in TRANSFER_IN_PROGRESS

Browse Source
This commit is contained in:
airajena
2026-02-17 12:06:12 +00:00
committed by Adam Saghy
parent 7daf4b8a84
commit 2ee6f22713
4 changed files with 63 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
+1 -5
View File
@@ -1731,11 +1731,7 @@ public class LoanWritePlatformServiceJpaRepositoryImpl implements LoanWritePlatf
final LoanTransaction newTransferAcceptanceTransaction = LoanTransaction.approveTransfer(acceptedInOffice, loan, transferDate,
externalId);
loan.addLoanTransaction(newTransferAcceptanceTransaction);
if (loan.getTotalOverpaid() != null) {
loanLifecycleStateMachine.transition(LoanEvent.LOAN_OVERPAYMENT, loan);
} else {
loanLifecycleStateMachine.transition(LoanEvent.LOAN_REPAYMENT_OR_WAIVER, loan);
}
loanLifecycleStateMachine.transition(LoanEvent.LOAN_COMPLETE_TRANSFER, loan);
if (loanOfficer != null) {
loanOfficerService.reassignLoanOfficer(loan, loanOfficer, transferDate);
}
fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachineTest.java
+49
View File
@@ -421,6 +421,55 @@ class DefaultLoanLifecycleStateMachineTest {
verify(businessEventNotifierService).notifyPostBusinessEvent(any(LoanStatusChangedBusinessEvent.class));
}
@Test
public void testTransitionShouldWorkProperlyForLoanCompleteTransferWhenTransferInProgress() {
// given
MonetaryCurrency currency = new MonetaryCurrency("USD", 2, null);
Loan loan = Mockito.mock(Loan.class);
LoanSummary loanSummary = Mockito.mock(LoanSummary.class);
Mockito.when(loan.getStatus()).thenReturn(LoanStatus.TRANSFER_IN_PROGRESS);
Mockito.when(loan.getTotalOverpaid()).thenReturn(null);
Mockito.when(loan.getSummary()).thenReturn(loanSummary);
Mockito.when(loan.getCurrency()).thenReturn(currency);
Mockito.when(loanSummary.isRepaidInFull(currency)).thenReturn(false);
// when
underTest.transition(LoanEvent.LOAN_COMPLETE_TRANSFER, loan);
// then
verify(loan).setLoanStatus(LoanStatus.ACTIVE);
verify(businessEventNotifierService).notifyPostBusinessEvent(any(LoanStatusChangedBusinessEvent.class));
}
@Test
public void testTransitionShouldWorkProperlyForLoanCompleteTransferWhenTransferInProgressAndOverpaid() {
// given
Loan loan = Mockito.mock(Loan.class);
Mockito.when(loan.getStatus()).thenReturn(LoanStatus.TRANSFER_IN_PROGRESS);
Mockito.when(loan.getTotalOverpaid()).thenReturn(BigDecimal.ONE);
// when
underTest.transition(LoanEvent.LOAN_COMPLETE_TRANSFER, loan);
// then
verify(loan).setLoanStatus(LoanStatus.OVERPAID);
verify(businessEventNotifierService).notifyPostBusinessEvent(any(LoanStatusChangedBusinessEvent.class));
}
@Test
public void testTransitionShouldWorkProperlyForLoanCompleteTransferWhenTransferInProgressAndFullyPaid() {
// given
MonetaryCurrency currency = new MonetaryCurrency("USD", 2, null);
Loan loan = Mockito.mock(Loan.class);
LoanSummary loanSummary = Mockito.mock(LoanSummary.class);
Mockito.when(loan.getStatus()).thenReturn(LoanStatus.TRANSFER_IN_PROGRESS);
Mockito.when(loan.getTotalOverpaid()).thenReturn(null);
Mockito.when(loan.getSummary()).thenReturn(loanSummary);
Mockito.when(loan.getCurrency()).thenReturn(currency);
Mockito.when(loanSummary.isRepaidInFull(currency)).thenReturn(true);
// when
underTest.transition(LoanEvent.LOAN_COMPLETE_TRANSFER, loan);
// then
verify(loan).setLoanStatus(LoanStatus.CLOSED_OBLIGATIONS_MET);
verify(businessEventNotifierService).notifyPostBusinessEvent(any(LoanStatusChangedBusinessEvent.class));
}
private Loan createLoanWithStatus(LoanStatus status) {
Loan result = new Loan();
result.setLoanStatus(status);