From b0132db8155786250838e77ed6747d956d26c757 Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Sun, 11 May 2014 00:01:07 +0200 Subject: [PATCH] Logging 2x, for otherwise silent failures in a) initial loadAllJobs(), and b) subsequent manual executeJob() --- .../jobs/service/JobRegisterServiceImpl.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java index 23d3763fc..1a41f2803 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java @@ -108,8 +108,12 @@ public class JobRegisterServiceImpl implements JobRegisterService { } } catch (final Exception e) { - throw new PlatformInternalServerException("error.msg.sheduler.job.execution.failed", "Job execution failed for job with id:" - + scheduledJobDetail.getId(), scheduledJobDetail.getId()); + final String msg = "Job execution failed for job with id:" + + scheduledJobDetail.getId(); + logger.error(msg, e); + throw new PlatformInternalServerException( + "error.msg.sheduler.job.execution.failed", msg, + scheduledJobDetail.getId()); } } @@ -214,6 +218,9 @@ public class JobRegisterServiceImpl implements JobRegisterService { scheduledJobDetails.updateNextRunTime(null); final String stackTrace = getStackTraceAsString(throwable); scheduledJobDetails.updateErrorLog(stackTrace); + logger.error( + "Could not schedule job: " + + scheduledJobDetails.getJobName(), throwable); } scheduledJobDetails.updateCurrentlyRunningStatus(false); }