FINERACT-1926: Lift loan status validation for buyback

This commit is contained in:
Adam Saghy
2023-06-07 12:13:30 +02:00
parent 66b3618ea4
commit 3cec111964
@@ -80,7 +80,6 @@ public class ExternalAssetOwnersWriteServiceImpl implements ExternalAssetOwnersW
public CommandProcessingResult saleLoanByLoanId(JsonCommand command) { public CommandProcessingResult saleLoanByLoanId(JsonCommand command) {
final JsonElement json = fromApiJsonHelper.parse(command.json()); final JsonElement json = fromApiJsonHelper.parse(command.json());
Long loanId = command.getLoanId(); Long loanId = command.getLoanId();
LocalDate settlementDate = getSettlementDateFromJson(json);
LoanIdAndExternalIdAndStatus loanIdAndExternalIdAndStatus = fetchLoanDetails(loanId); LoanIdAndExternalIdAndStatus loanIdAndExternalIdAndStatus = fetchLoanDetails(loanId);
validateLoanStatus(loanIdAndExternalIdAndStatus); validateLoanStatus(loanIdAndExternalIdAndStatus);
ExternalAssetOwnerTransfer externalAssetOwnerTransfer = createSaleTransfer(loanId, command.json(), ExternalAssetOwnerTransfer externalAssetOwnerTransfer = createSaleTransfer(loanId, command.json(),
@@ -97,8 +96,6 @@ public class ExternalAssetOwnersWriteServiceImpl implements ExternalAssetOwnersW
Long loanId = command.getLoanId(); Long loanId = command.getLoanId();
LocalDate settlementDate = getSettlementDateFromJson(json); LocalDate settlementDate = getSettlementDateFromJson(json);
ExternalId externalId = getTransferExternalIdFromJson(json); ExternalId externalId = getTransferExternalIdFromJson(json);
LoanIdAndExternalIdAndStatus loanIdAndExternalIdAndStatus = fetchLoanDetails(loanId);
validateLoanStatus(loanIdAndExternalIdAndStatus);
validateSettlementDate(settlementDate); validateSettlementDate(settlementDate);
ExternalAssetOwnerTransfer effectiveTransfer = fetchAndValidateEffectiveTransferForBuyback(loanId, settlementDate); ExternalAssetOwnerTransfer effectiveTransfer = fetchAndValidateEffectiveTransferForBuyback(loanId, settlementDate);
ExternalAssetOwnerTransfer externalAssetOwnerTransfer = createBuybackTransfer(effectiveTransfer, settlementDate, externalId); ExternalAssetOwnerTransfer externalAssetOwnerTransfer = createBuybackTransfer(effectiveTransfer, settlementDate, externalId);