From 3e95c32e1856c45a649848af9a3d9b8510e5872f Mon Sep 17 00:00:00 2001 From: Manthan Surkar Date: Sun, 24 May 2020 03:43:31 +0530 Subject: [PATCH] FINERACT-821 Added and enforced NeedBraces Checkstyle --- .../config/checkstyle/checkstyle.xml | 3 +- .../ClientLoanIntegrationTest.java | 5 +- ...SavingsInterestPostingIntegrationTest.java | 9 +- ...RepaymentRescheduleAtDisbursementTest.java | 4 +- .../client/ClientEntityImportHandlerTest.java | 3 +- .../loan/LoanImportHandlerTest.java | 3 +- .../office/OfficeImportHandlerTest.java | 3 +- .../savings/SavingsImportHandlerTest.java | 3 +- .../integrationtests/common/CenterDomain.java | 73 ++++++--- .../common/CurrenciesHelper.java | 4 +- .../common/CurrencyDomain.java | 32 +++- .../integrationtests/common/OfficeDomain.java | 24 ++- .../common/PaymentTypeHelper.java | 6 +- .../common/ProvisioningIntegrationTest.java | 4 +- .../common/savings/SavingsAccountHelper.java | 6 +- .../glaccount/domain/TrialBalance.java | 4 +- .../domain/TrialBalanceRepositoryWrapper.java | 5 +- .../domain/LoanProductProvisioningEntry.java | 4 +- .../domain/ProvisioningEntry.java | 4 +- .../batch/command/CommandContext.java | 28 +++- .../bulkimport/api/BulkImportApiResource.java | 13 +- .../importhandler/ImportHandlerUtils.java | 83 ++++++----- .../center/CenterImportHandler.java | 43 +++--- .../ChartOfAccountsImportHandler.java | 5 +- .../client/ClientEntityImportHandler.java | 23 ++- .../client/ClientPersonImportHandler.java | 18 ++- .../FixedDepositImportHandler.java | 131 ++++++++++------ .../FixedDepositTransactionImportHandler.java | 17 ++- .../group/GroupImportHandler.java | 51 ++++--- .../guarantor/GuarantorImportHandler.java | 10 +- .../JournalEntriesImportHandler.java | 15 +- .../importhandler/loan/LoanImportHandler.java | 140 +++++++++++------- .../LoanRepaymentImportHandler.java | 11 +- .../RecurringDepositImportHandler.java | 111 ++++++++------ ...urringDepositTransactionImportHandler.java | 17 ++- .../savings/SavingsImportHandler.java | 93 +++++++----- .../SavingsTransactionImportHandler.java | 17 ++- .../SharedAccountImportHandler.java | 5 +- .../staff/StaffImportHandler.java | 5 +- .../users/UserImportHandler.java | 8 +- .../populator/AbstractWorkbookPopulator.java | 6 +- .../populator/CenterSheetPopulator.java | 3 +- .../populator/ClientSheetPopulator.java | 9 +- .../populator/ExtrasSheetPopulator.java | 10 +- .../FixedDepositProductSheetPopulator.java | 39 +++-- .../populator/GroupSheetPopulator.java | 6 +- .../populator/LoanProductSheetPopulator.java | 63 ++++---- .../populator/PersonnelSheetPopulator.java | 8 +- ...RecurringDepositProductSheetPopulator.java | 42 ++++-- .../SavingsProductSheetPopulator.java | 15 +- .../centers/CentersWorkbookPopulator.java | 11 +- .../ChartOfAccountsWorkbook.java | 3 +- .../client/ClientEntityWorkbookPopulator.java | 35 +++-- .../client/ClientPersonWorkbookPopulator.java | 30 ++-- ...edDepositTransactionWorkbookPopulator.java | 9 +- .../group/GroupsWorkbookPopulator.java | 16 +- .../populator/loan/LoanWorkbookPopulator.java | 10 +- .../LoanRepaymentWorkbookPopulator.java | 14 +- .../office/OfficeWorkbookPopulator.java | 3 +- ...ngDepositTransactionWorkbookPopulator.java | 9 +- .../SavingsTransactionsWorkbookPopulator.java | 9 +- .../email/data/EmailBusinessRulesData.java | 8 +- .../sms/data/SmsBusinessRulesData.java | 12 +- .../domain/ConfigurationDomainServiceJpa.java | 7 +- ...alServicesPropertiesRepositoryWrapper.java | 4 +- .../core/data/EnumOptionData.java | 8 +- .../dataqueries/data/DatatableData.java | 4 +- .../EntityDataTableChecksTemplateData.java | 8 +- .../dataqueries/data/EntityTables.java | 2 +- .../ReadWriteNonCoreDataServiceImpl.java | 4 +- .../infrastructure/hooks/domain/Hook.java | 4 +- .../jobs/domain/JobParameter.java | 4 +- .../interoperation/data/ExtensionData.java | 3 +- .../interoperation/data/GeoCodeData.java | 3 +- .../data/InteropAccountData.java | 21 ++- .../data/InteropIdentifierRequestData.java | 3 +- .../data/InteropQuoteRequestData.java | 6 +- .../data/InteropRequestData.java | 9 +- .../data/InteropTransactionData.java | 12 +- .../data/InteropTransactionRequestData.java | 3 +- .../data/InteropTransactionTypeData.java | 3 +- .../data/InteropTransactionsData.java | 3 +- .../data/InteropTransferRequestData.java | 6 +- .../interoperation/data/MoneyData.java | 6 +- .../domain/InteropIdentifier.java | 20 ++- .../serialization/InteropDataValidator.java | 3 +- .../monetary/data/CurrencyData.java | 8 +- .../data/ProvisioningCategoryData.java | 4 +- .../TellerWritePlatformServiceJpaImpl.java | 10 +- ...ountTransfersWritePlatformServiceImpl.java | 3 +- .../portfolio/calendar/data/CalendarData.java | 6 +- .../portfolio/calendar/domain/Calendar.java | 4 +- .../domain/CalendarFrequencyType.java | 4 +- .../calendar/domain/CalendarWeekDaysType.java | 4 +- .../calendar/service/CalendarUtils.java | 28 ++-- ...WritePlatformServiceJpaRepositoryImpl.java | 4 +- .../portfolio/charge/domain/Charge.java | 8 +- .../client/data/ClientDataValidator.java | 12 +- .../client/domain/ClientNonPerson.java | 9 +- .../ClientReadPlatformServiceImpl.java | 10 +- ...WritePlatformServiceJpaRepositoryImpl.java | 10 +- ...ollectionSheetReadPlatformServiceImpl.java | 12 +- .../portfolio/group/data/CenterData.java | 8 +- .../group/data/GroupGeneralData.java | 8 +- .../portfolio/group/data/GroupRoleData.java | 8 +- .../group/data/GroupTimelineData.java | 8 +- .../InterestRateChartSlabAssembler.java | 4 +- .../loanaccount/api/LoansApiResource.java | 3 +- .../loanaccount/data/LoanAccountData.java | 9 +- .../portfolio/loanaccount/domain/Loan.java | 22 ++- .../LoanRepaymentScheduleInstallment.java | 18 ++- .../domain/LoanRepositoryWrapper.java | 4 +- .../domain/LoanSummaryWrapper.java | 4 +- ...RepaymentScheduleTransactionProcessor.java | 8 +- .../service/LoanScheduleAssembler.java | 4 +- ...WritePlatformServiceJpaRepositoryImpl.java | 8 +- .../service/LoanReadPlatformServiceImpl.java | 4 +- .../LoanProductConfigurableAttributes.java | 8 +- ...anProductInterestRecalculationDetails.java | 6 +- .../paymentdetail/data/PaymentDetailData.java | 8 +- .../paymenttype/data/PaymentTypeData.java | 8 +- .../savings/data/DepositAccountData.java | 8 +- .../savings/data/SavingsAccountData.java | 8 +- .../DepositAccountDomainServiceJpa.java | 16 +- .../DepositAccountTermAndPreClosure.java | 4 +- .../domain/DepositProductAssembler.java | 12 +- .../savings/domain/DepositTermDetail.java | 13 +- .../domain/RecurringDepositAccount.java | 8 +- .../savings/domain/SavingsAccount.java | 26 +++- .../savings/domain/SavingsAccountCharge.java | 8 +- .../savings/domain/SavingsHelper.java | 12 +- .../domain/interest/PostingPeriod.java | 5 +- ...DepositAccountReadPlatformServiceImpl.java | 16 +- ...DepositProductReadPlatformServiceImpl.java | 8 +- .../AppuserClientMapperReadServiceImpl.java | 3 +- .../ShareAccountDataSerializer.java | 8 +- .../ShareProductDataSerializer.java | 8 +- .../useradministration/data/AppUserData.java | 12 +- 138 files changed, 1337 insertions(+), 683 deletions(-) diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml index 7f156dc2a..8e46fe285 100644 --- a/fineract-provider/config/checkstyle/checkstyle.xml +++ b/fineract-provider/config/checkstyle/checkstyle.xml @@ -87,6 +87,7 @@ +