FINERACT-1724: Avoiding stackoverflowerror with GH builds

.github/workflows/build-mariadb.yml

@@ -87,7 +87,9 @@ jobs:
           FINERACT_REPORT_EXPORT_S3_ENABLED: true
           FINERACT_REPORT_EXPORT_S3_BUCKET_NAME: fineract-reports
         run: |
-            ./gradlew --no-daemon --console=plain build test -x doc -x :twofactor-tests:test -x :oauth2-test:test
+            ./gradlew --no-daemon --console=plain build -x cucumber -x test -x doc
+            ./gradlew --no-daemon --console=plain cucumber
+            ./gradlew --no-daemon --console=plain test -x :twofactor-tests:test -x :oauth2-test:test
             ./gradlew --no-daemon --console=plain :twofactor-tests:test
             ./gradlew --no-daemon --console=plain :oauth2-tests:test
 

.github/workflows/build-mysql.yml

@@ -87,7 +87,9 @@ jobs:
           FINERACT_REPORT_EXPORT_S3_ENABLED: true
           FINERACT_REPORT_EXPORT_S3_BUCKET_NAME: fineract-reports
         run: |
-            ./gradlew --no-daemon --console=plain build test -x doc -x :twofactor-tests:test -x :oauth2-test:test -PdbType=mysql
+            ./gradlew --no-daemon --console=plain build -x cucumber -x test -x doc
+            ./gradlew --no-daemon --console=plain cucumber
+            ./gradlew --no-daemon --console=plain test -x :twofactor-tests:test -x :oauth2-test:test -PdbType=mysql
             ./gradlew --no-daemon --console=plain :twofactor-tests:test -PdbType=mysql
             ./gradlew --no-daemon --console=plain :oauth2-tests:test -PdbType=mysql
 

.github/workflows/build-postgresql.yml

@@ -88,7 +88,9 @@ jobs:
           FINERACT_REPORT_EXPORT_S3_ENABLED: true
           FINERACT_REPORT_EXPORT_S3_BUCKET_NAME: fineract-reports
         run: |
-            ./gradlew --no-daemon --console=plain build test -x doc -x :twofactor-tests:test -x :oauth2-test:test -PdbType=postgresql
+            ./gradlew --no-daemon --console=plain build -x cucumber -x test -x doc
+            ./gradlew --no-daemon --console=plain cucumber
+            ./gradlew --no-daemon --console=plain test -x :twofactor-tests:test -x :oauth2-test:test -PdbType=postgresql
             ./gradlew --no-daemon --console=plain :twofactor-tests:test -PdbType=postgresql
             ./gradlew --no-daemon --console=plain :oauth2-tests:test -PdbType=postgresql
 

build.gradle

@@ -291,7 +291,6 @@ configure(project.fineractJavaProjects) {
     apply plugin: 'net.ltgt.errorprone'
     apply plugin: 'com.github.spotbugs'
     apply plugin: 'com.github.andygoossens.modernizer'
-    apply plugin: 'se.thinkcode.cucumber-runner'
     apply from: "${rootDir}/buildSrc/src/main/groovy/org.apache.fineract.dependencies.gradle"
 
     group = 'org.apache.fineract'
@@ -559,11 +558,7 @@ configure(project.fineractJavaProjects) {
                 'org.bouncycastle:bcprov-jdk15to18',
                 'org.awaitility:awaitility',
                 'com.google.truth:truth',
-                'com.google.truth.extensions:truth-java8-extension',
+                'com.google.truth.extensions:truth-java8-extension'
-                'io.cucumber:cucumber-core',
-                'io.cucumber:cucumber-java',
-                'io.cucumber:cucumber-java8',
-                'io.cucumber:cucumber-junit-platform-engine',
                 )
     }
 
@@ -581,12 +576,6 @@ configure(project.fineractJavaProjects) {
         logLevel 'quiet'
     }
 
-    cucumber {
-        tags = 'not @ignore'
-        main = 'io.cucumber.core.cli.Main'
-        shorten = 'argfile'
-    }
-
     // Configuration for spotbugs plugin
     // https://github.com/spotbugs/spotbugs-gradle-plugin
 

fineract-client/build.gradle

@@ -23,9 +23,6 @@ description = 'Fineract Client'
 
 apply from: 'dependencies.gradle'
 
-// enable when all tests are migrated
-tasks.cucumber.onlyIf {false}
-
 // TODO: @vidakovic we should publish this lib to Maven Central; do in separate PR
 
 openApiMeta {

fineract-core/build.gradle

@@ -20,7 +20,6 @@ description = 'Fineract Core'
 
 apply plugin: 'java'
 apply plugin: 'eclipse'
-check.dependsOn('cucumber')
 
 compileJava.doLast {
     def mainSS = sourceSets.main

fineract-core/dependencies.gradle

@@ -107,9 +107,7 @@ dependencies {
     // testCompile dependencies are ONLY used in src/test, not src/main.
     // Do NOT repeat dependencies which are ALREADY in implementation or runtimeOnly!
     //
-    testImplementation( 'io.cucumber:cucumber-spring',
+    testImplementation( 'io.github.classgraph:classgraph')
-            'io.github.classgraph:classgraph',
-            )
     testImplementation ('org.springframework.boot:spring-boot-starter-test') {
         exclude group: 'com.jayway.jsonpath', module: 'json-path'
         exclude group: 'org.junit.vintage', module: 'junit-vintage-engine'

fineract-investor/build.gradle

@@ -21,8 +21,6 @@ description = 'Fineract Investor'
 apply plugin: 'java'
 apply plugin: 'eclipse'
 
-check.dependsOn('cucumber')
-
 compileJava.doLast {
     def mainSS = sourceSets.main
     def source = mainSS.java.classesDirectory.get()

fineract-investor/dependencies.gradle

@@ -66,9 +66,7 @@ dependencies {
     // testCompile dependencies are ONLY used in src/test, not src/main.
     // Do NOT repeat dependencies which are ALREADY in implementation or runtimeOnly!
     //
-    testImplementation( 'io.cucumber:cucumber-spring',
+    testImplementation( 'io.github.classgraph:classgraph' )
-            'io.github.classgraph:classgraph',
-            )
     testImplementation ('org.springframework.boot:spring-boot-starter-test') {
         exclude group: 'com.jayway.jsonpath', module: 'json-path'
         exclude group: 'org.junit.vintage', module: 'junit-vintage-engine'

fineract-loan/build.gradle

@@ -21,8 +21,6 @@ description = 'Fineract Loan'
 apply plugin: 'java'
 apply plugin: 'eclipse'
 
-check.dependsOn('cucumber')
-
 compileJava.doLast {
     def mainSS = sourceSets.main
     def source = mainSS.java.classesDirectory.get()

fineract-loan/dependencies.gradle

@@ -62,9 +62,7 @@ dependencies {
     // testCompile dependencies are ONLY used in src/test, not src/main.
     // Do NOT repeat dependencies which are ALREADY in implementation or runtimeOnly!
     //
-    testImplementation( 'io.cucumber:cucumber-spring',
+    testImplementation( 'io.github.classgraph:classgraph' )
-            'io.github.classgraph:classgraph',
-            )
     testImplementation ('org.springframework.boot:spring-boot-starter-test') {
         exclude group: 'com.jayway.jsonpath', module: 'json-path'
         exclude group: 'org.junit.vintage', module: 'junit-vintage-engine'

fineract-provider/build.gradle

@@ -26,6 +26,7 @@ apply plugin: 'com.gorylenko.gradle-git-properties'
 apply plugin: 'io.swagger.core.v3.swagger-gradle-plugin'
 apply plugin: 'com.google.cloud.tools.jib'
 apply plugin: 'org.springframework.boot'
+apply plugin: 'se.thinkcode.cucumber-runner'
 
 check.dependsOn('cucumber')
 
@@ -325,6 +326,12 @@ task migrateDatabase {
     }
 }
 
+cucumber {
+    tags = 'not @ignore'
+    main = 'io.cucumber.core.cli.Main'
+    shorten = 'argfile'
+}
+
 tasks.jibDockerBuild.dependsOn(bootJar)
 
 // Configuration for git properties gradle plugin

fineract-provider/dependencies.gradle

@@ -179,6 +179,10 @@ dependencies {
     //
     testImplementation( 'io.cucumber:cucumber-spring',
             'io.github.classgraph:classgraph',
+            'io.cucumber:cucumber-core',
+            'io.cucumber:cucumber-java',
+            'io.cucumber:cucumber-java8',
+            'io.cucumber:cucumber-junit-platform-engine',
             )
     testImplementation ('org.springframework.boot:spring-boot-starter-test') {
         exclude group: 'com.jayway.jsonpath', module: 'json-path'

integration-tests/build.gradle

@@ -28,9 +28,6 @@ configurations {
 
 apply from: 'dependencies.gradle'
 
-// enable when all tests are migrated
-tasks.cucumber.onlyIf { false }
-
 // Allow external drivers to be used for the tests without packaging it
 // mainly due to license incompatibilities
 configurations {

integration-tests/dependencies.gradle

@@ -28,7 +28,6 @@ dependencies {
             project(path: ':fineract-provider', configuration: 'runtimeElements'),
             project(path: ':fineract-avro-schemas', configuration: 'runtimeElements'),
             project(path: ':fineract-client', configuration: 'runtimeElements'),
-            'io.cucumber:cucumber-spring',
             'com.intuit.karate:karate-junit5',
             // 'com.google.code.gson:gson',
             )

oauth2-tests/build.gradle

@@ -28,9 +28,6 @@ configurations {
 
 apply from: 'dependencies.gradle'
 
-// enable when all tests are migrated
-tasks.cucumber.onlyIf {false}
-
 // Allow external drivers to be used for the tests without packaging it
 // mainly due to license incompatibilities
 configurations {

twofactor-tests/build.gradle

@@ -28,9 +28,6 @@ configurations {
 
 apply from: 'dependencies.gradle'
 
-// enable when all tests are migrated
-tasks.cucumber.onlyIf {false}
-
 // Allow external drivers to be used for the tests without packaging it
 // mainly due to license incompatibilities
 configurations {