FINERACT-777 Use api / implementation scoped Gradle dependencies (#661)

see https://issues.apache.org/jira/browse/FINERACT-777

fineract-provider/build.gradle

@@ -57,7 +57,7 @@ apply plugin: 'eclipse'
 apply plugin: 'idea'
 apply plugin: 'com.bmuschko.tomcat'
 apply plugin: 'project-report'
-apply plugin: 'java'
+apply plugin: 'java-library'
 apply plugin: 'openjpa'
 // apply plugin: 'pmd'
 // apply plugin: 'findbugs'

fineract-provider/dependencies.gradle

@@ -31,7 +31,20 @@ dependencies {
         exclude group: 'com.zaxxer', module: 'HikariCP'
     }
 
-    compile(
+     api(
+            [group: 'com.google.code.gson', name: 'gson', version: '2.2.4'],
+            [group: 'org.quartz-scheduler', name: 'quartz', version: '2.1.7'],
+            [group: 'org.apache.openjpa', name:'openjpa', version: openJPAVersion],
+            [group: 'org.springframework', name:'spring-jms', version: '4.0.7.RELEASE'],
+            [group: 'joda-time', name: 'joda-time', version: '2.4'],
+            [group: 'org.mnode.ical4j', name: 'ical4j', version: '1.0.4'],
+            [group: 'com.google.guava', name: 'guava', version: '15.0'],
+            [group: 'org.springframework', name: 'spring-context-support', version: springVersion],
+            [group: 'org.springframework.security.oauth', name: 'spring-security-oauth2', version: springOauthVersion],
+            [group: 'com.sun.jersey', name: 'jersey-core', version: jerseyVersion],
+            [group: 'com.squareup.retrofit', name: 'retrofit', version: '1.6.1']
+    )
+    implementation(
             // [group: 'ch.vorburger.mariaDB4j', name: 'mariaDB4j', version: '2.1.3'],
 
             [group: 'org.springframework.boot', name: 'spring-boot-starter-web', version: springBootVersion],
@@ -39,28 +52,28 @@ dependencies {
             [group: 'org.springframework.boot', name: 'spring-boot-starter-actuator', version: springBootVersion],
 
             //[group: 'org.eclipse.persistence', name: 'javax.persistence', version: '2.0.0'],
-                [group: 'org.springframework', name: 'spring-context-support', version: springVersion],
+
 
             [group: 'org.springframework.security.oauth', name: 'spring-security-oauth2', version: springOauthVersion],
 
-                [group: 'org.apache.openjpa', name:'openjpa', version: openJPAVersion],
+
             //[group: 'javax.ws.rs', name: 'jsr311-api', version: '1.1.1'],
-                [group: 'com.sun.jersey', name: 'jersey-core', version: jerseyVersion],
+
             [group: 'com.sun.jersey', name: 'jersey-servlet', version: jerseyVersion],
             [group: 'com.sun.jersey', name: 'jersey-server', version: jerseyVersion],
             [group: 'com.sun.jersey', name: 'jersey-json', version: jerseyVersion],
             [group: 'com.sun.jersey.contribs', name: 'jersey-spring', version: jerseyVersion],
             [group: 'com.sun.jersey.contribs', name: 'jersey-multipart', version: jerseyVersion],
 
-                [group: 'com.squareup.retrofit', name: 'retrofit', version: '1.6.1'],
+
             [group: 'com.squareup.okhttp', name: 'okhttp', version: '2.0.0'],
             [group: 'com.squareup.okhttp', name: 'okhttp-urlconnection', version: '2.0.0'],
 
 
-                [group: 'com.google.code.gson', name: 'gson', version: '2.2.4'],
-                [group: 'com.google.guava', name: 'guava', version: '15.0'],
 
-                [group: 'joda-time', name: 'joda-time', version: '2.4'],
+
+
+
             //[group: 'net.sourceforge.javacsv', name: 'javacsv', version: '2.0'],
             [group: 'org.apache.commons', name: 'commons-email', version: '1.3.3'],
             [group: 'org.apache.commons', name: 'commons-lang3', version: '3.3.2'],
@@ -78,9 +91,9 @@ dependencies {
 
             [group: 'com.lowagie', name: 'itext', version: '2.1.7'],
             //[group: 'com.lowagie', name: 'itext-rtf', version: '2.1.7'],
-                [group: 'org.mnode.ical4j', name: 'ical4j', version: '1.0.4'],
+
             [group: 'com.googlecode.flyway', name: 'flyway-core', version: '2.1.1'],
-                [group: 'org.quartz-scheduler', name: 'quartz', version: '2.1.7'],
+
             [group: 'com.amazonaws', name: 'aws-java-sdk-s3', version: '1.11.80'],
             [group: 'net.sf.ehcache', name: 'ehcache', version: '2.7.2'],
             [group: 'com.github.spullara.mustache.java', name: 'compiler', version: '0.8.12'],
@@ -93,7 +106,6 @@ dependencies {
             //[group: 'com.google.code.findbugs', name: 'jsr305', version: '3.0.0']
 
             [group: 'io.swagger', name: 'swagger-jersey-jaxrs', version: '1.5.15'],
-                [group: 'org.springframework', name:'spring-jms', version: '4.0.7.RELEASE'],
             [group: 'org.apache.activemq', name: 'activemq-broker', version: '5.9.1'],
             [group: 'javax.validation', name: 'validation-api', version: '2.0.0.Final']
     )
@@ -105,6 +117,14 @@ dependencies {
             'org.mockito:mockito-core:1.9.5',
             'com.jayway.restassured:rest-assured:2.3.3',
             [group: 'com.mockrunner', name: 'mockrunner-jms', version: '1.0.6'],
+            [group: 'com.google.code.gson', name: 'gson', version: '2.2.4'],
+            [group: 'org.springframework', name:'spring-jms', version: '4.0.7.RELEASE'],
+            [group: 'joda-time', name: 'joda-time', version: '2.4'],
+            [  group: 'org.mnode.ical4j', name: 'ical4j', version: '1.0.4'],
+            [group: 'com.google.guava', name: 'guava', version: '15.0'],
+            [group: 'org.apache.poi',name: 'poi-ooxml', version: '3.9'],
+            [group: 'org.springframework', name: 'spring-context-support', version: springVersion],
+            [group: 'com.sun.jersey', name: 'jersey-core', version: jerseyVersion],
             [group: 'com.mockrunner', name: 'mockrunner-jdbc', version: '1.0.6']
 
     testCompile ("org.springframework.boot:spring-boot-starter-test:$springBootVersion") {

fineract-provider/dev-dependencies.gradle

@@ -27,7 +27,21 @@ dependencies {
 
     providedRuntime("org.springframework.boot:spring-boot-starter-tomcat:${springBootVersion}")
 
-    compile(
+     api(
+            [group: 'com.google.code.gson', name: 'gson', version: '2.2.4'],
+            [group: 'org.quartz-scheduler', name: 'quartz', version: '2.1.7'],
+            [group: 'joda-time', name: 'joda-time', version: '2.4'],
+            [group: 'org.apache.openjpa', name:'openjpa-all', version:'2.4.1'],
+            [group: 'org.springframework', name:'spring-jms'],
+            [group: 'org.mnode.ical4j', name: 'ical4j', version: '1.0.4'],
+            [group: 'com.google.guava', name: 'guava', version: '15.0'],
+            [group: 'org.springframework', name: 'spring-context-support', version: springVersion],
+            [group: 'org.springframework.security.oauth', name: 'spring-security-oauth2', version: springOauthVersion],
+            [group: 'com.squareup.retrofit', name: 'retrofit', version: '1.6.1'],
+            [group: 'com.sun.jersey', name: 'jersey-core', version: jerseyVersion]
+    )
+
+    implementation(
             [group: 'ch.vorburger.mariaDB4j', name: 'mariaDB4j', version: '2.1.3'],
 
             [group: 'org.springframework.boot', name: 'spring-boot-starter-web', version: springBootVersion],
@@ -35,28 +49,27 @@ dependencies {
             [group: 'org.springframework.boot', name: 'spring-boot-starter-security', version: springBootVersion],
             [group: 'org.springframework.boot', name: 'spring-boot-starter-actuator', version: springBootVersion],
             //[group: 'org.eclipse.persistence', name: 'javax.persistence', version: '2.0.0'],
-                [group: 'org.springframework', name: 'spring-context-support', version: springVersion],
-				[group: 'org.springframework.security.oauth', name: 'spring-security-oauth2', version: springOauthVersion],
 
-                [group: 'org.apache.openjpa', name:'openjpa', version:openJPAVersion],
+
+
+
             [group: 'org.apache.openjpa', name:'openjpa-maven-plugin', version:openJPAVersion],
             [group: 'javax.ws.rs', name: 'jsr311-api', version: '1.1.1'],
-                [group: 'com.sun.jersey', name: 'jersey-core', version: jerseyVersion],
+
             [group: 'com.sun.jersey', name: 'jersey-servlet', version: jerseyVersion],
             [group: 'com.sun.jersey', name: 'jersey-server', version: jerseyVersion],
             [group: 'com.sun.jersey', name: 'jersey-json', version: jerseyVersion],
             [group: 'com.sun.jersey.contribs', name: 'jersey-spring', version: jerseyVersion],
             [group: 'com.sun.jersey.contribs', name: 'jersey-multipart', version: jerseyVersion],
 
-                [group: 'com.squareup.retrofit', name: 'retrofit', version: '1.6.1'],
+
             [group: 'com.squareup.okhttp', name: 'okhttp', version: '2.0.0'],
             [group: 'com.squareup.okhttp', name: 'okhttp-urlconnection', version: '2.0.0'],
 
 
-                [group: 'com.google.code.gson', name: 'gson', version: '2.2.4'],
-                [group: 'com.google.guava', name: 'guava', version: '15.0'],
 
-                [group: 'joda-time', name: 'joda-time', version: '2.4'],
+
+
             //[group: 'net.sourceforge.javacsv', name: 'javacsv', version: '2.0'],
             [group: 'org.apache.commons', name: 'commons-email', version: '1.3.3'],
             [group: 'org.apache.commons', name: 'commons-lang3', version: '3.3.2'],
@@ -74,9 +87,9 @@ dependencies {
 
             [group: 'com.lowagie', name: 'itext', version: '2.1.7'],
             [group: 'com.lowagie', name: 'itext-rtf', version: '2.1.7'],
-                [group: 'org.mnode.ical4j', name: 'ical4j', version: '1.0.4'],
+
             [group: 'com.googlecode.flyway', name: 'flyway-core', version: '2.1.1'],
-                [group: 'org.quartz-scheduler', name: 'quartz', version: '2.1.7'],
+
             [group: 'com.amazonaws', name: 'aws-java-sdk-s3', version: '1.11.80'],
             [group: 'net.sf.ehcache', name: 'ehcache', version: '2.7.2'],
             [group: 'com.github.spullara.mustache.java', name: 'compiler', version: '0.8.12'],
@@ -89,7 +102,7 @@ dependencies {
             //[group: 'com.google.code.findbugs', name: 'jsr305', version: '3.0.0']
 
             [group: 'io.swagger', name: 'swagger-jersey-jaxrs', version: '1.5.15'],
-                [group: 'org.springframework', name:'spring-jms', version: '4.0.7.RELEASE'],
+
             [group: 'org.apache.activemq', name: 'activemq-broker', version: '5.9.1'],
             [group: 'javax.validation', name: 'validation-api', version: '2.0.0.Final']
     )
@@ -99,6 +112,15 @@ dependencies {
             'org.mockito:mockito-core:1.9.5',
             'com.jayway.restassured:rest-assured:2.3.3',
             [group: 'com.mockrunner', name: 'mockrunner-jms', version: '1.0.6'],
+            [group: 'com.google.code.gson', name: 'gson', version: '2.2.4'],
+            [group: 'org.springframework', name:'spring-jms', version: '4.0.7.RELEASE'],
+            [group: 'joda-time', name: 'joda-time', version: '2.4'],
+            [  group: 'org.mnode.ical4j', name: 'ical4j', version: '1.0.4'],
+            [group: 'com.google.guava', name: 'guava', version: '15.0'],
+            [group: 'org.apache.poi',name: 'poi-ooxml', version: '3.9'],
+            [group: 'org.springframework', name: 'spring-context-support', version: springVersion],
+
+            [group: 'com.sun.jersey', name: 'jersey-core', version: jerseyVersion],
             [group: 'com.mockrunner', name: 'mockrunner-jdbc', version: '1.0.6']
 
     testCompile ("org.springframework.boot:spring-boot-starter-test:$springBootVersion") {

gradlew

@@ -80,14 +80,12 @@ if [ -n "$JAVA_HOME" ] ; then
     fi
     if [ ! -x "$JAVACMD" ] ; then
         die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME
-
 Please set the JAVA_HOME variable in your environment to match the
 location of your Java installation."
     fi
 else
     JAVACMD="java"
     which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
-
 Please set the JAVA_HOME variable in your environment to match the
 location of your Java installation."
 fi