From 4528231fd106acb57d70141b53f01d426b0f042e Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Sun, 7 Jun 2020 15:08:47 +0200 Subject: [PATCH] remove bad 'default:' in SavingsEnumerations switch This default: is "wrong", because it's not required - the switch, in this particular case, *IS* actually already handling all cases. But if in the future someone were to add an additional new SavingsAccountTransactionType, then we would want Error Prone to fail to signal that it needs to be handled here - but the "default:" would "hide" that. This is a follow-up to https://github.com/apache/fineract/pull/983/ for FINERACT-822, and also related to the discussion started on https://github.com/apache/fineract/pull/989. There originally used to be a "default:" in the middle of the switch, that obviously WAS completely wrong and an old copy-paste bug. --- .../fineract/portfolio/savings/service/SavingsEnumerations.java | 1 - 1 file changed, 1 deletion(-) diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java index 071b2e482..ed604d4a6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java @@ -199,7 +199,6 @@ public class SavingsEnumerations { optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(), SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount"); break; - default: } return optionData; }