From 4dc7581972ad6d75bdb3adc16fbef128b40531da Mon Sep 17 00:00:00 2001 From: Vishwas Babu A J Date: Wed, 30 Jul 2014 23:58:33 -0700 Subject: [PATCH] Update Contributing.md with verbiage changes --- Contributing.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Contributing.md b/Contributing.md index becdea239..31416d74e 100644 --- a/Contributing.md +++ b/Contributing.md @@ -4,15 +4,15 @@ Instructions for getting started are located at https://mifosforge.jira.com/wiki # Pull Request Checklist Before sending out a pull request, please ensure that the following pre-requisites are taken care of -1. An integration test is added/updated to test the new feature developed/bug-fix made +1. An integration test is added/updated to test the new feature developed/bug-fix being made -1. The pull request has a Jira issue associated with it. Details for creating Jira issues are located at https://mifosforge.jira.com/wiki/display/MIFOSX/Getting+started+-+Contributing+to+MifosX#Gettingstarted-ContributingtoMifosX-CreateIssues +1. The pull request has a Jira issue associated with it. Details for creating issues on Jira are located at https://mifosforge.jira.com/wiki/display/MIFOSX/Getting+started+-+Contributing+to+MifosX#Gettingstarted-ContributingtoMifosX-CreateIssues -1. The Relevant Jira number (Ex: MIFOSX-1454) should be present as a part of the Commit message. Refer http://comments.gmane.org/gmane.comp.finance.mifos.devel/14664 for details +1. The Relevant Jira number (Ex: MIFOSX-1454) is present as a part of the commit message. Refer http://comments.gmane.org/gmane.comp.finance.mifos.devel/14664 for details -1. Ensure newly added code has been formatted and cleaned up as per our preferences at https://github.com/openMF/mifosx/wiki/Eclipse#apply-project-preferences-to-eclipse +1. Newly added code has been formatted and cleaned up as per our preferences at https://github.com/openMF/mifosx/wiki/Eclipse#apply-project-preferences-to-eclipse -1. For ensuring a cleaner commit history, we request contributors to send their work in a single commit. This can be done using squash or reset, instructions at https://github.com/openMF/mifosx/wiki/Github-&-Git#contributing-back-changes-to-original-repositoryauthors +1. Your work is present in a single commit rather than several broken up commits. This helps us maintain a cleaner commit history. https://github.com/openMF/mifosx/wiki/Github-&-Git#contributing-back-changes-to-original-repositoryauthors has instructions for squashing multiple commits or resetting head and recommiting your work as a single commit -1. Rebase your work on top of the latest code from develop branch to make life easier for our Committers +1. Your work is rebased on top of the latest code from develop branch to make life easier for our Committers