From 74c36e810d60e05a58fa0f566885e470df1def34 Mon Sep 17 00:00:00 2001 From: Vishwas Babu A J Date: Wed, 10 Sep 2014 12:45:43 -0700 Subject: [PATCH] handle eclipse warning in portfolio packages --- .../infrastructure/cache/PlatformCacheConfiguration.java | 1 + .../service/AbandonedConnectionCleanupShutdownListener.java | 2 +- .../infrastructure/jobs/service/JobRegisterServiceImpl.java | 2 +- .../loanaccount/domain/LoanInterestRecalculationDetails.java | 4 +--- .../loanschedule/data/LoanSchedulePeriodData.java | 1 - .../portfolio/loanproduct/data/LoanProductData.java | 1 + .../domain/LoanProductInterestRecalculationDetails.java | 1 - .../loanproduct/domain/RecalculationFrequencyType.java | 2 -- .../portfolio/savings/domain/SavingsAccount.java | 5 ++--- 9 files changed, 7 insertions(+), 12 deletions(-) diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/cache/PlatformCacheConfiguration.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/cache/PlatformCacheConfiguration.java index 5a5a69190..8a0f8a8b4 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/cache/PlatformCacheConfiguration.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/cache/PlatformCacheConfiguration.java @@ -15,6 +15,7 @@ import org.springframework.cache.interceptor.KeyGenerator; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; +@SuppressWarnings("deprecation") @Configuration @EnableCaching public class PlatformCacheConfiguration implements CachingConfigurer { diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/service/AbandonedConnectionCleanupShutdownListener.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/service/AbandonedConnectionCleanupShutdownListener.java index d5d36c0f6..f5def24cd 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/service/AbandonedConnectionCleanupShutdownListener.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/service/AbandonedConnectionCleanupShutdownListener.java @@ -23,7 +23,7 @@ public class AbandonedConnectionCleanupShutdownListener implements ApplicationLi private final static Logger logger = LoggerFactory.getLogger(AbandonedConnectionCleanupShutdownListener.class); @Override - public void onApplicationEvent(ContextStoppedEvent event) { + public void onApplicationEvent(@SuppressWarnings("unused") ContextStoppedEvent event) { shutDowncleanUpThreadAndDeregisterJDBCDriver(); } diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java index c401cf7a5..75940d6a6 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java @@ -231,7 +231,7 @@ public class JobRegisterServiceImpl implements JobRegisterService, ApplicationLi } @Override - public void onApplicationEvent(ContextStoppedEvent event) { + public void onApplicationEvent(@SuppressWarnings("unused") ContextStoppedEvent event) { this.stopAllSchedulers(); } diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/LoanInterestRecalculationDetails.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/LoanInterestRecalculationDetails.java index f84cb4fbd..b69da3a4f 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/LoanInterestRecalculationDetails.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/LoanInterestRecalculationDetails.java @@ -35,7 +35,6 @@ import org.springframework.data.jpa.domain.AbstractPersistable; @Table(name = "m_loan_recalculation_details") public class LoanInterestRecalculationDetails extends AbstractPersistable { - @SuppressWarnings("unused") @OneToOne @JoinColumn(name = "loan_id", nullable = false) private Loan loan; @@ -116,12 +115,11 @@ public class LoanInterestRecalculationDetails extends AbstractPersistable } return recurrenceOnLocalDate; } - + public RecalculationFrequencyType getRestFrequencyType() { return RecalculationFrequencyType.fromInt(this.restFrequencyType); } - public Integer getRestInterval() { return this.restInterval; } diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java index 9b060684d..e6f06e236 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java @@ -31,7 +31,6 @@ public class LoanSchedulePeriodData { private final BigDecimal principalPaid; private final BigDecimal principalWrittenOff; private final BigDecimal principalOutstanding; - @SuppressWarnings("unused") private final BigDecimal principalLoanBalanceOutstanding; @SuppressWarnings("unused") private final BigDecimal interestOriginalDue; diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/data/LoanProductData.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/data/LoanProductData.java index 017f8e330..4ce3867c6 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/data/LoanProductData.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/data/LoanProductData.java @@ -127,6 +127,7 @@ public class LoanProductData { @SuppressWarnings("unused") private final List rescheduleStrategyTypeOptions; + @SuppressWarnings("unused") private final List interestRecalculationFrequencyTypeOptions; private final Boolean multiDisburseLoan; diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/LoanProductInterestRecalculationDetails.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/LoanProductInterestRecalculationDetails.java index 2d2f0a4d3..97de3bd5c 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/LoanProductInterestRecalculationDetails.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/LoanProductInterestRecalculationDetails.java @@ -31,7 +31,6 @@ import org.springframework.data.jpa.domain.AbstractPersistable; @Table(name = "m_product_loan_recalculation_details") public class LoanProductInterestRecalculationDetails extends AbstractPersistable { - @SuppressWarnings("unused") @OneToOne @JoinColumn(name = "product_id", nullable = false) private LoanProduct loanProduct; diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/RecalculationFrequencyType.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/RecalculationFrequencyType.java index 99188506d..bcf3375c9 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/RecalculationFrequencyType.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/RecalculationFrequencyType.java @@ -8,8 +8,6 @@ package org.mifosplatform.portfolio.loanproduct.domain; import java.util.HashMap; import java.util.Map; -import org.mifosplatform.portfolio.common.domain.PeriodFrequencyType; - public enum RecalculationFrequencyType { INVALID(0, "interestRecalculationFrequencyType.invalid"), // SAME_AS_REPAYMENT_PERIOD(1, "interestRecalculationFrequencyType.same.as.repayment.period"), // diff --git a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/savings/domain/SavingsAccount.java b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/savings/domain/SavingsAccount.java index bb96650f5..31e580084 100644 --- a/mifosng-provider/src/main/java/org/mifosplatform/portfolio/savings/domain/SavingsAccount.java +++ b/mifosng-provider/src/main/java/org/mifosplatform/portfolio/savings/domain/SavingsAccount.java @@ -5,7 +5,6 @@ */ package org.mifosplatform.portfolio.savings.domain; - import static org.mifosplatform.portfolio.savings.SavingsApiConstants.SAVINGS_ACCOUNT_RESOURCE_NAME; import static org.mifosplatform.portfolio.savings.SavingsApiConstants.allowOverdraftParamName; import static org.mifosplatform.portfolio.savings.SavingsApiConstants.dueAsOfDateParamName; @@ -16,7 +15,6 @@ import static org.mifosplatform.portfolio.savings.SavingsApiConstants.lockinPeri import static org.mifosplatform.portfolio.savings.SavingsApiConstants.minRequiredBalanceParamName; import static org.mifosplatform.portfolio.savings.SavingsApiConstants.overdraftLimitParamName; import static org.mifosplatform.portfolio.savings.SavingsApiConstants.withdrawalFeeForTransfersParamName; -import org.mifosplatform.organisation.staff.domain.Staff; import java.math.BigDecimal; import java.math.MathContext; @@ -1193,7 +1191,7 @@ public class SavingsAccount extends AbstractPersistable { public Staff getFieldOfficer() { return this.fieldOfficer; } - + public void unassignFieldOfficer() { this.fieldOfficer = null; } @@ -1201,6 +1199,7 @@ public class SavingsAccount extends AbstractPersistable { public void assignFieldOfficer(final Staff fieldOfficer) { this.fieldOfficer = fieldOfficer; } + public Long clientId() { Long id = null; if (this.client != null) {