CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity

FINERACT-2181: Swagger enhancement for PostSavingsProductsRequest

Browse Source
This commit is contained in:
Jose Alberto Hernandez
2025-07-01 20:17:03 +02:00
committed by Adam Saghy
parent 072017c601
commit 570f44ac93
3 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/factory/SavingsProductRequestFactory.java
+3 -3
View File
@@ -18,8 +18,8 @@
*/ */
package org.apache.fineract.test.factory; package org.apache.fineract.test.factory;
import java.util.HashSet; import java.util.ArrayList;
import java.util.Set; import java.util.List;
import org.apache.fineract.client.models.PostSavingsCharges; import org.apache.fineract.client.models.PostSavingsCharges;
import org.apache.fineract.client.models.PostSavingsProductsRequest; import org.apache.fineract.client.models.PostSavingsProductsRequest;
@@ -43,7 +43,7 @@ public final class SavingsProductRequestFactory {
private SavingsProductRequestFactory() {} private SavingsProductRequestFactory() {}
public static PostSavingsProductsRequest defaultSavingsProductRequest() { public static PostSavingsProductsRequest defaultSavingsProductRequest() {
Set<PostSavingsCharges> charges = new HashSet<>(); List<PostSavingsCharges> charges = new ArrayList<>();
return new PostSavingsProductsRequest().name(DEFAULT_SAVINGS_PRODUCT_NAME)// return new PostSavingsProductsRequest().name(DEFAULT_SAVINGS_PRODUCT_NAME)//
.shortName(DEFAULT_SAVINGS_PRODUCT_SHORT_NAME)// .shortName(DEFAULT_SAVINGS_PRODUCT_SHORT_NAME)//
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsProductsApiResourceSwagger.java
+11 -1
View File
@@ -69,9 +69,19 @@ final class SavingsProductsApiResourceSwagger {
public Integer interestCalculationDaysInYearType; public Integer interestCalculationDaysInYearType;
@Schema(example = "1") @Schema(example = "1")
public Integer accountingRule; public Integer accountingRule;
public Set<PostSavingsCharges> charges; public List<PostSavingsCharges> charges;
@Schema(example = "accountMappingForPayment") @Schema(example = "accountMappingForPayment")
public String accountMappingForPayment; public String accountMappingForPayment;
@Schema(example = "false")
public Boolean withdrawalFeeForTransfers;
@Schema(example = "false")
public Boolean enforceMinRequiredBalance;
@Schema(example = "false")
public Boolean allowOverdraft;
@Schema(example = "false")
public Boolean withHoldTax;
@Schema(example = "false")
public Boolean isDormancyTrackingActive;
} }
@Schema(description = "PostSavingsProductsResponse") @Schema(description = "PostSavingsProductsResponse")
integration-tests/src/test/java/org/apache/fineract/integrationtests/savings/base/BaseSavingsIntegrationTest.java
+6 -1
View File
@@ -119,7 +119,12 @@ public class BaseSavingsIntegrationTest extends IntegrationTest {
.accountingRule(1) // none .accountingRule(1) // none
.interestCalculationDaysInYearType(DaysInYearType.DAYS_365).interestCompoundingPeriodType(InterestPeriodType.DAILY) .interestCalculationDaysInYearType(DaysInYearType.DAYS_365).interestCompoundingPeriodType(InterestPeriodType.DAILY)
.interestCalculationType(InterestCalculationType.AVERAGE_DAILY_BALANCE) // .interestCalculationType(InterestCalculationType.AVERAGE_DAILY_BALANCE) //
.interestPostingPeriodType(InterestPeriodType.DAILY);// .interestPostingPeriodType(InterestPeriodType.DAILY) //
.withdrawalFeeForTransfers(false) //
.enforceMinRequiredBalance(false) //
.allowOverdraft(false) //
.withHoldTax(false) //
.isDormancyTrackingActive(false); //
} }
protected PostSavingsProductsResponse createProduct(PostSavingsProductsRequest productsRequest) { protected PostSavingsProductsResponse createProduct(PostSavingsProductsRequest productsRequest) {