CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

FINERACT-2446: Tax Group and Tax Component APIs return HTTP 500 when no record is found (empty result), instead of returning a proper HTTP 404 Not Found

Browse Source
This commit is contained in:
oluexpert99
2026-01-26 14:52:23 +01:00
committed by Adam Saghy
parent f2630fb712
commit 5ca75c94ec
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/service/TaxReadPlatformServiceImpl.java
+6 -2
View File
@@ -25,7 +25,9 @@ import org.apache.fineract.accounting.common.AccountingDropdownReadPlatformServi
import org.apache.fineract.portfolio.tax.data.TaxComponentData; import org.apache.fineract.portfolio.tax.data.TaxComponentData;
import org.apache.fineract.portfolio.tax.data.TaxGroupData; import org.apache.fineract.portfolio.tax.data.TaxGroupData;
import org.apache.fineract.portfolio.tax.domain.TaxComponentRepository; import org.apache.fineract.portfolio.tax.domain.TaxComponentRepository;
import org.apache.fineract.portfolio.tax.domain.TaxComponentRepositoryWrapper;
import org.apache.fineract.portfolio.tax.domain.TaxGroupRepository; import org.apache.fineract.portfolio.tax.domain.TaxGroupRepository;
import org.apache.fineract.portfolio.tax.domain.TaxGroupRepositoryWrapper;
import org.apache.fineract.portfolio.tax.mapper.TaxComponentMapper; import org.apache.fineract.portfolio.tax.mapper.TaxComponentMapper;
import org.apache.fineract.portfolio.tax.mapper.TaxGroupMapper; import org.apache.fineract.portfolio.tax.mapper.TaxGroupMapper;
@@ -34,8 +36,10 @@ public class TaxReadPlatformServiceImpl implements TaxReadPlatformService {
private final AccountingDropdownReadPlatformService accountingDropdownReadPlatformService; private final AccountingDropdownReadPlatformService accountingDropdownReadPlatformService;
private final TaxComponentRepository taxComponentRepository; private final TaxComponentRepository taxComponentRepository;
private final TaxComponentRepositoryWrapper taxComponentRepositoryWrapper;
private final TaxComponentMapper taxComponentMapper; private final TaxComponentMapper taxComponentMapper;
private final TaxGroupRepository taxGroupRepository; private final TaxGroupRepository taxGroupRepository;
private final TaxGroupRepositoryWrapper taxGroupRepositoryWrapper;
private final TaxGroupMapper taxGroupMapper; private final TaxGroupMapper taxGroupMapper;
@Override @Override
@@ -45,7 +49,7 @@ public class TaxReadPlatformServiceImpl implements TaxReadPlatformService {
@Override @Override
public TaxComponentData retrieveTaxComponentData(final Long id) { public TaxComponentData retrieveTaxComponentData(final Long id) {
return taxComponentMapper.map(taxComponentRepository.getReferenceById(id)); return taxComponentMapper.map(taxComponentRepositoryWrapper.findOneWithNotFoundDetection(id));
} }
@Override @Override
@@ -61,7 +65,7 @@ public class TaxReadPlatformServiceImpl implements TaxReadPlatformService {
@Override @Override
public TaxGroupData retrieveTaxGroupData(final Long id) { public TaxGroupData retrieveTaxGroupData(final Long id) {
return taxGroupMapper.map(taxGroupRepository.getReferenceById(id)); return taxGroupMapper.map(taxGroupRepositoryWrapper.findOneWithNotFoundDetection(id));
} }
@Override @Override
fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/starter/TaxConfiguration.java
+5 -4
View File
@@ -50,10 +50,11 @@ public class TaxConfiguration {
@Bean @Bean
@ConditionalOnMissingBean(TaxReadPlatformService.class) @ConditionalOnMissingBean(TaxReadPlatformService.class)
public TaxReadPlatformService taxReadPlatformService(final TaxComponentRepository taxComponentRepository, public TaxReadPlatformService taxReadPlatformService(final TaxComponentRepository taxComponentRepository,
final TaxComponentMapper taxComponentMapper, final TaxGroupRepository taxGroupRepository, final TaxGroupMapper taxGroupMapper, final TaxComponentRepositoryWrapper taxComponentRepositoryWrapper, final TaxComponentMapper taxComponentMapper,
AccountingDropdownReadPlatformService accountingDropdownReadPlatformService) { final TaxGroupRepository taxGroupRepository, final TaxGroupRepositoryWrapper taxGroupRepositoryWrapper,
return new TaxReadPlatformServiceImpl(accountingDropdownReadPlatformService, taxComponentRepository, taxComponentMapper, final TaxGroupMapper taxGroupMapper, AccountingDropdownReadPlatformService accountingDropdownReadPlatformService) {
taxGroupRepository, taxGroupMapper); return new TaxReadPlatformServiceImpl(accountingDropdownReadPlatformService, taxComponentRepository, taxComponentRepositoryWrapper,
taxComponentMapper, taxGroupRepository, taxGroupRepositoryWrapper, taxGroupMapper);
} }
@Bean @Bean