CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

[FINERACT-1926] Fix Internal Server Error on non existing loan

Browse Source
This commit is contained in:
taskain7
2023-06-01 08:19:32 +02:00
committed by Arnold Gálovics
parent 6a68d3b134
commit 60cb0cbe11
3 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
+7 -1
View File
@@ -33,6 +33,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import lombok.AllArgsConstructor;
import org.apache.commons.lang3.StringUtils;
@@ -601,7 +602,12 @@ public class LoanReadPlatformServiceImpl implements LoanReadPlatformService, Loa
@Override
public Long getLoanIdByLoanExternalId(String externalId) {
return loanRepositoryWrapper.findIdByExternalId(ExternalIdFactory.produce(externalId));
ExternalId loanExternalId = ExternalIdFactory.produce(externalId);
Long loanId = loanRepositoryWrapper.findIdByExternalId(loanExternalId);
if (Objects.isNull(loanId)) {
throw new LoanNotFoundException(loanExternalId);
}
return loanId;
}
private static final class LoanMapper implements RowMapper<LoanAccountData> {