diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle index 1ec2d1d5d..a59c8522d 100644 --- a/fineract-provider/build.gradle +++ b/fineract-provider/build.gradle @@ -282,7 +282,7 @@ configurations { } tasks.withType(JavaCompile) { - options.compilerArgs += ["-Xlint:unchecked", "-Werror"] // TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X") + options.compilerArgs += ["-Xlint:unchecked","-Xlint:cast","-Werror"] // TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X") options.deprecation = true } diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java index 1933e5fa1..22e120dc0 100644 --- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java +++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java @@ -242,6 +242,6 @@ public class CenterDomain implements Comparable { @Override public int compareTo(CenterDomain cd) { - return ((Integer) this.id).compareTo(cd.getId()); + return ( this.id).compareTo(cd.getId()); } } diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java index e0c754040..1e0e754c3 100644 --- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java +++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java @@ -42,7 +42,7 @@ public class GlobalConfigurationHelper { final String GET_ALL_GLOBAL_CONFIG_URL = "/fineract-provider/api/v1/configurations?" + Utils.TENANT_IDENTIFIER; LOG.info("------------------------ RETRIEVING ALL GLOBAL CONFIGURATIONS -------------------------"); final HashMap> response = Utils.performServerGet(requestSpec, responseSpec, GET_ALL_GLOBAL_CONFIG_URL, ""); - return (ArrayList) response.get("globalConfiguration"); + return response.get("globalConfiguration"); } public static HashMap getGlobalConfigurationById(final RequestSpecification requestSpec, final ResponseSpecification responseSpec, diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/HookHelper.java b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/HookHelper.java index ac1d34d4a..84fb3ee83 100644 --- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/HookHelper.java +++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/HookHelper.java @@ -89,7 +89,7 @@ public class HookHelper { LOG.info("------------------------------CHECK UPDATE HOOK DETAILS------------------------------------\n"); final String GET_URL = "/fineract-provider/api/v1/hooks/" + hookId + "?" + Utils.TENANT_IDENTIFIER; ArrayList> map = Utils.>>performServerGet(this.requestSpec, this.responseSpec, GET_URL, "config"); - HashMap hash = (HashMap) map.get(1); + HashMap hash = map.get(1); assertEquals(updateURL, hash.get("fieldValue")); } @@ -98,7 +98,7 @@ public class HookHelper { final String GET_URL = "/fineract-provider/api/v1/hooks/" + hookId + "?" + Utils.TENANT_IDENTIFIER; ResponseSpecification responseSpec404 = new ResponseSpecBuilder().expectStatusCode(404).build(); ArrayList> array = Utils.>>performServerGet(this.requestSpec, responseSpec404, GET_URL, "errors"); - HashMap map = (HashMap)array.get(0); + HashMap map = array.get(0); assertEquals("error.msg.hook.identifier.not.found",map.get("userMessageGlobalisationCode")); } } diff --git a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/data/AdHocData.java b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/data/AdHocData.java index f126476ac..6a71ebff5 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/data/AdHocData.java +++ b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/data/AdHocData.java @@ -90,7 +90,7 @@ public class AdHocData { } public static AdHocData template() { List reportRunFrequencies = Arrays.stream(ReportRunFrequency.values()).map(rrf -> new EnumOptionData( - (long) rrf.getValue(), rrf.getCode(), rrf.getCode() + rrf.getValue(), rrf.getCode(), rrf.getCode() )).collect(Collectors.toList()); AdHocData adHocData = new AdHocData(null,null,null,null,null,false,null,null,null,null,null,null, reportRunFrequencies, null, null, null); @@ -144,4 +144,4 @@ public class AdHocData { public DateTime getLastRun() { return this.lastRun; } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java index d65126328..708cdbc97 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java @@ -467,7 +467,7 @@ private WorkbookPopulator populateCenterWorkbook(Long officeId,Long staffId){ } private List fetchGLAccounts() { - List glaccounts = (List) this.glAccountReadPlatformService. + List glaccounts = this.glAccountReadPlatformService. retrieveAllGLAccounts(null, null, null, null, null, null); return glaccounts; diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java index e9b272bda..24b0cf10f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java @@ -445,11 +445,11 @@ public class EmailCampaign extends AbstractPersistableCustom { } public LocalDate getSubmittedOnDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); } public LocalDate getClosureDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.closureDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.closureDate), null); } public LocalDate getActivationLocalDate() { @@ -486,10 +486,10 @@ public class EmailCampaign extends AbstractPersistableCustom { } public LocalDate getRecurrenceStartDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.recurrenceStartDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.recurrenceStartDate), null); } public LocalDateTime getRecurrenceStartDateTime() { - return (LocalDateTime) ObjectUtils.defaultIfNull(new LocalDateTime(this.recurrenceStartDate), null); + return ObjectUtils.defaultIfNull(new LocalDateTime(this.recurrenceStartDate), null); } @@ -503,7 +503,7 @@ public class EmailCampaign extends AbstractPersistableCustom { } public LocalDateTime getNextTriggerDate() { - return (LocalDateTime) ObjectUtils.defaultIfNull(new LocalDateTime(this.nextTriggerDate), null); + return ObjectUtils.defaultIfNull(new LocalDateTime(this.nextTriggerDate), null); } @@ -512,7 +512,7 @@ public class EmailCampaign extends AbstractPersistableCustom { } public LocalDate getLastTriggerDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.lastTriggerDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.lastTriggerDate), null); } public void updateIsVisible(boolean isVisible) { diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java index 5c76449b9..7535940f7 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java @@ -462,12 +462,12 @@ public class SmsCampaign extends AbstractPersistableCustom { } public LocalDate getSubmittedOnDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); } public LocalDate getClosureDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.closureDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.closureDate), null); } public LocalDate getActivationLocalDate() { @@ -503,11 +503,11 @@ public class SmsCampaign extends AbstractPersistableCustom { } public LocalDate getRecurrenceStartDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.recurrenceStartDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.recurrenceStartDate), null); } public LocalDateTime getRecurrenceStartDateTime() { - return (LocalDateTime) ObjectUtils.defaultIfNull(new LocalDateTime(this.recurrenceStartDate), null); + return ObjectUtils.defaultIfNull(new LocalDateTime(this.recurrenceStartDate), null); } public void setLastTriggerDate(Date lastTriggerDate) { @@ -519,7 +519,7 @@ public class SmsCampaign extends AbstractPersistableCustom { } public LocalDateTime getNextTriggerDate() { - return (LocalDateTime) ObjectUtils.defaultIfNull(new LocalDateTime(this.nextTriggerDate), null); + return ObjectUtils.defaultIfNull(new LocalDateTime(this.nextTriggerDate), null); } @@ -528,7 +528,7 @@ public class SmsCampaign extends AbstractPersistableCustom { } public LocalDate getLastTriggerDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.lastTriggerDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.lastTriggerDate), null); } public void updateIsVisible(boolean isVisible) { diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonCommand.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonCommand.java index 4c7e90598..7ca8d3a1e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonCommand.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonCommand.java @@ -571,7 +571,7 @@ public final class JsonCommand { */ public boolean booleanPrimitiveValueOfParameterNamed(final String parameterName) { final Boolean value = this.fromApiJsonHelper.extractBooleanNamed(parameterName, this.parsedCommand); - return (Boolean) ObjectUtils.defaultIfNull(value, Boolean.FALSE); + return ObjectUtils.defaultIfNull(value, Boolean.FALSE); } public boolean isChangeInArrayParameterNamed(final String parameterName, final String[] existingValue) { @@ -617,4 +617,4 @@ public final class JsonCommand { this.fromApiJsonHelper.checkForUnsupportedParameters(typeOfMap, json, requestDataParameters); } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonQuery.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonQuery.java index cabe266b9..9fc5deaa5 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonQuery.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/api/JsonQuery.java @@ -241,7 +241,7 @@ public final class JsonQuery { */ public boolean booleanPrimitiveValueOfParameterNamed(final String parameterName) { final Boolean value = this.fromApiJsonHelper.extractBooleanNamed(parameterName, this.parsedQuery); - return (Boolean) ObjectUtils.defaultIfNull(value, Boolean.FALSE); + return ObjectUtils.defaultIfNull(value, Boolean.FALSE); } public boolean isChangeInArrayParameterNamed(final String parameterName, final String[] existingValue) { @@ -274,4 +274,4 @@ public final class JsonQuery { final PlatformUser dummyPlatformUser = new BasicPasswordEncodablePlatformUser(saltValue, "", passwordPlainText); return platformPasswordEncoder.encode(dummyPlatformUser); } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java index 7e3e57205..7a697fa59 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java @@ -80,7 +80,7 @@ public class CreditBureauLoanProductMapping extends AbstractPersistableCustom { skipCreditCheckInFailure = command.booleanPrimitiveValueOfParameterNamed("skipCreditcheckInFailure"); } - if((Integer)command.integerValueOfParameterNamed("stalePeriod")!=null) + if(command.integerValueOfParameterNamed("stalePeriod")!=null) { stalePeriod = command.integerValueOfParameterNamed("stalePeriod"); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadConfigurationServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadConfigurationServiceImpl.java index b250956e5..adfd8871c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadConfigurationServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReadConfigurationServiceImpl.java @@ -86,7 +86,7 @@ public class CreditBureauReadConfigurationServiceImpl implements CreditBureauRea final CbConfigMapper rm = new CbConfigMapper(); final String sql = "select " + rm.schema() + " where cbconfig.organisation_creditbureau_id= ?"; - List config = (List) this.jdbcTemplate.query(sql, + List config = this.jdbcTemplate.query(sql, rm, new Object[] {id}); Map configuration = new HashMap(); for (CreditBureauConfigurationData data : config) { diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java index 019d06323..b9ca9446c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java @@ -750,7 +750,7 @@ public final class Client extends AbstractPersistableCustom { } public LocalDate getSubmittedOnDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); } public LocalDate getActivationLocalDate() { @@ -954,13 +954,13 @@ public final class Client extends AbstractPersistableCustom { } public LocalDate getClosureDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.closureDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.closureDate), null); } public LocalDate getRejectedDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.rejectionDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.rejectionDate), null); } public LocalDate getWithdrawalDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.withdrawalDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.withdrawalDate), null); } public LocalDate getReopenedDate() { @@ -1071,4 +1071,4 @@ public final class Client extends AbstractPersistableCustom { this.proposedTransferDate = proposedTransferDate; } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java index bbc56f2ee..d33141e24 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java @@ -564,7 +564,7 @@ public class GroupsApiResource { if(parentGSIMAccountNo==null && parentGSIMId!=null) { - gsimContainer= (List)this.gsimReadPlatformService.findGsimAccountContainerbyGsimAccountId(parentGSIMId); + gsimContainer= this.gsimReadPlatformService.findGsimAccountContainerbyGsimAccountId(parentGSIMId); } else if(parentGSIMAccountNo !=null && parentGSIMId==null ) { diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java index 386b483d1..92f0769ed 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java @@ -363,7 +363,7 @@ public final class Group extends AbstractPersistableCustom { } public LocalDate getSubmittedOnDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); } public LocalDate getActivationLocalDate() { @@ -766,4 +766,4 @@ public final class Group extends AbstractPersistableCustom { } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java index 25f9065ad..56f8dd663 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java @@ -3903,7 +3903,7 @@ public class Loan extends AbstractPersistableCustom { } public LocalDate getSubmittedOnDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.submittedOnDate), null); } public LocalDate getApprovedOnDate() { diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanOfficerAssignmentHistory.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanOfficerAssignmentHistory.java index 4a0426405..dbb7ad86b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanOfficerAssignmentHistory.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanOfficerAssignmentHistory.java @@ -105,10 +105,10 @@ public class LoanOfficerAssignmentHistory extends AbstractAuditableCustom { } public LocalDate getEndDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.endDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.endDate), null); } public boolean isSameLoanOfficer(final Staff staff) { return this.loanOfficer.identifiedBy(staff); } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java index 178ae758e..c52e67664 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java @@ -2356,7 +2356,7 @@ public class SavingsAccount extends AbstractPersistableCustom { } public LocalDate getClosedOnDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.closedOnDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.closedOnDate), null); } public SavingsAccountSummary getSummary() { @@ -3160,4 +3160,4 @@ public class SavingsAccount extends AbstractPersistableCustom { private boolean isOverdraft() { return allowOverdraft; } -} \ No newline at end of file +} diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsOfficerAssignmentHistory.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsOfficerAssignmentHistory.java index cc6c7533a..ee654ba6c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsOfficerAssignmentHistory.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsOfficerAssignmentHistory.java @@ -111,7 +111,7 @@ public class SavingsOfficerAssignmentHistory extends AbstractAuditableCustom { } public LocalDate getEndDate() { - return (LocalDate) ObjectUtils.defaultIfNull(new LocalDate(this.endDate), null); + return ObjectUtils.defaultIfNull(new LocalDate(this.endDate), null); } }