CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 55 Packages Projects Releases Wiki Activity

FINERACT-822 Enforce PublicConstructorForAbstractClass check

Browse Source
This commit is contained in:
percyashu
2020-06-26 12:43:45 +02:00
committed by Michael Vorburger ⛑️
parent d9911bd771
commit 66c3bfdd4f
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/build.gradle
+2 -2
View File
@@ -215,7 +215,7 @@ jacocoTestReport{
spotless { spotless {
format 'misc', { format 'misc', {
target '**/*.md', '**/*.properties', '**/*.gradle', '**/.gitignore', '**/*.yml', '**/*.xml', '**/**.json', '**/*.sql' target '**/*.md', '**/*.properties', '**/*.gradle', '**/.gitignore', '**/*.yml', '**/*.xml', '**/**.json', '**/*.sql'
targetExclude '**/build/**', '**/bin/**', '**/.settings/**' targetExclude '**/build/**', '**/bin/**', '**/.settings/**','**/.idea/**'
indentWithSpaces(4) indentWithSpaces(4)
endWithNewline() endWithNewline()
trimTrailingWhitespace() trimTrailingWhitespace()
@@ -391,7 +391,6 @@ tasks.withType(JavaCompile) {
"InvalidParam", "InvalidParam",
"ReturnFromVoid", "ReturnFromVoid",
"AlmostJavadoc", "AlmostJavadoc",
"PublicConstructorForAbstractClass",
"ProtectedMembersInFinalClass", "ProtectedMembersInFinalClass",
"StaticAssignmentInConstructor", "StaticAssignmentInConstructor",
"UnescapedEntity", "UnescapedEntity",
@@ -453,6 +452,7 @@ tasks.withType(JavaCompile) {
"MissingCasesInEnumSwitch", "MissingCasesInEnumSwitch",
"ReferenceEquality", "ReferenceEquality",
"UndefinedEquals", "UndefinedEquals",
"PublicConstructorForAbstractClass",
"OperatorPrecedence", "OperatorPrecedence",
"EqualsGetClass", "EqualsGetClass",
"EqualsUnsafeCast", "EqualsUnsafeCast",
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformDomainRuleException.java
+1 -1
View File
@@ -27,7 +27,7 @@ public abstract class AbstractPlatformDomainRuleException extends RuntimeExcepti
private final String defaultUserMessage; private final String defaultUserMessage;
private final Object[] defaultUserMessageArgs; private final Object[] defaultUserMessageArgs;
public AbstractPlatformDomainRuleException(final String globalisationMessageCode, final String defaultUserMessage, protected AbstractPlatformDomainRuleException(final String globalisationMessageCode, final String defaultUserMessage,
final Object... defaultUserMessageArgs) { final Object... defaultUserMessageArgs) {
this.globalisationMessageCode = globalisationMessageCode; this.globalisationMessageCode = globalisationMessageCode;
this.defaultUserMessage = defaultUserMessage; this.defaultUserMessage = defaultUserMessage;
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractPlatformServiceUnavailableException.java
+1 -1
View File
@@ -27,7 +27,7 @@ public abstract class AbstractPlatformServiceUnavailableException extends Runtim
private final String defaultUserMessage; private final String defaultUserMessage;
private final Object[] defaultUserMessageArgs; private final Object[] defaultUserMessageArgs;
public AbstractPlatformServiceUnavailableException(final String globalisationMessageCode, final String defaultUserMessage, protected AbstractPlatformServiceUnavailableException(final String globalisationMessageCode, final String defaultUserMessage,
final Object... defaultUserMessageArgs) { final Object... defaultUserMessageArgs) {
this.globalisationMessageCode = globalisationMessageCode; this.globalisationMessageCode = globalisationMessageCode;
this.defaultUserMessage = defaultUserMessage; this.defaultUserMessage = defaultUserMessage;
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java
+2 -2
View File
@@ -547,7 +547,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead
@Override @Override
public abstract DepositAccountData mapRow(ResultSet rs, int rowNum) throws SQLException; public abstract DepositAccountData mapRow(ResultSet rs, int rowNum) throws SQLException;
public DepositAccountMapper() { protected DepositAccountMapper() {
final StringBuilder selectFieldsSqlBuilder = new StringBuilder(400); final StringBuilder selectFieldsSqlBuilder = new StringBuilder(400);
selectFieldsSqlBuilder.append("sa.id as id, sa.account_no as accountNo, sa.external_id as externalId, "); selectFieldsSqlBuilder.append("sa.id as id, sa.account_no as accountNo, sa.external_id as externalId, ");
selectFieldsSqlBuilder.append("c.id as clientId, c.display_name as clientName, "); selectFieldsSqlBuilder.append("c.id as clientId, c.display_name as clientName, ");
@@ -1083,7 +1083,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead
private final ClientData client; private final ClientData client;
private final GroupGeneralData group; private final GroupGeneralData group;
public DepositAccountTemplateMapper(final ClientData client, final GroupGeneralData group) { protected DepositAccountTemplateMapper(final ClientData client, final GroupGeneralData group) {
this.client = client; this.client = client;
this.group = group; this.group = group;
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java
+1 -1
View File
@@ -133,7 +133,7 @@ public class DepositProductReadPlatformServiceImpl implements DepositProductRead
@Override @Override
public abstract DepositProductData mapRow(ResultSet rs, int rowNum) throws SQLException; public abstract DepositProductData mapRow(ResultSet rs, int rowNum) throws SQLException;
public DepositProductMapper() { protected DepositProductMapper() {
final StringBuilder sqlBuilder = new StringBuilder(400); final StringBuilder sqlBuilder = new StringBuilder(400);
sqlBuilder.append("sp.id as id, sp.name as name, sp.short_name as shortName, sp.description as description, "); sqlBuilder.append("sp.id as id, sp.name as name, sp.short_name as shortName, sp.description as description, ");
sqlBuilder.append( sqlBuilder.append(