From 6a6c0301b66b53a631a0a64e783863f29ef430af Mon Sep 17 00:00:00 2001 From: Michael Vorburger Date: Sun, 11 Oct 2020 20:16:16 +0200 Subject: [PATCH] Simplify appContext.xml, mv all *Repository into .domain. packages, rm spmContext.xml (FINERACT-1175) --- .../InterestRateChartRepository.java | 3 +- .../InterestRateChartRepositoryWrapper.java | 3 +- .../InterestRateChartSlabRepository.java | 3 +- ...nterestRateChartSlabRepositoryWrapper.java | 3 +- .../service/InterestRateChartAssembler.java | 2 +- .../InterestRateChartSlabAssembler.java | 2 +- ...WritePlatformServiceJpaRepositoryImpl.java | 4 +- ...WritePlatformServiceJpaRepositoryImpl.java | 2 +- .../LookupTableRepository.java | 4 +- .../ScorecardRepository.java | 4 +- .../SurveyRepository.java | 3 +- .../spm/service/LookupTableService.java | 2 +- .../spm/service/ScorecardService.java | 2 +- .../fineract/spm/service/SpmService.java | 2 +- .../resources/META-INF/spring/appContext.xml | 44 +------------------ .../resources/META-INF/spring/spmContext.xml | 37 ---------------- 16 files changed, 17 insertions(+), 103 deletions(-) rename fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/{data => domain}/InterestRateChartRepository.java (88%) rename fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/{data => domain}/InterestRateChartRepositoryWrapper.java (94%) rename fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/{data => domain}/InterestRateChartSlabRepository.java (88%) rename fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/{data => domain}/InterestRateChartSlabRepositoryWrapper.java (94%) rename fineract-provider/src/main/java/org/apache/fineract/spm/{repository => domain}/LookupTableRepository.java (88%) rename fineract-provider/src/main/java/org/apache/fineract/spm/{repository => domain}/ScorecardRepository.java (89%) rename fineract-provider/src/main/java/org/apache/fineract/spm/{repository => domain}/SurveyRepository.java (94%) delete mode 100644 fineract-provider/src/main/resources/META-INF/spring/spmContext.xml diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartRepository.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartRepository.java similarity index 88% rename from fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartRepository.java rename to fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartRepository.java index 7c1a8aa35..cf08f4f9e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartRepository.java @@ -16,9 +16,8 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.portfolio.interestratechart.data; +package org.apache.fineract.portfolio.interestratechart.domain; -import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChart; import org.springframework.data.jpa.repository.JpaRepository; import org.springframework.data.jpa.repository.JpaSpecificationExecutor; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartRepositoryWrapper.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartRepositoryWrapper.java similarity index 94% rename from fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartRepositoryWrapper.java rename to fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartRepositoryWrapper.java index e1dfbcad5..ffcefa280 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartRepositoryWrapper.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartRepositoryWrapper.java @@ -16,9 +16,8 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.portfolio.interestratechart.data; +package org.apache.fineract.portfolio.interestratechart.domain; -import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChart; import org.apache.fineract.portfolio.interestratechart.exception.InterestRateChartNotFoundException; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabRepository.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabRepository.java similarity index 88% rename from fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabRepository.java rename to fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabRepository.java index ec9ffce34..a8ce7f0e5 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabRepository.java @@ -16,9 +16,8 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.portfolio.interestratechart.data; +package org.apache.fineract.portfolio.interestratechart.domain; -import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlab; import org.springframework.data.jpa.repository.JpaRepository; import org.springframework.data.jpa.repository.JpaSpecificationExecutor; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabRepositoryWrapper.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabRepositoryWrapper.java similarity index 94% rename from fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabRepositoryWrapper.java rename to fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabRepositoryWrapper.java index 64f811b46..fed2547f9 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabRepositoryWrapper.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabRepositoryWrapper.java @@ -16,9 +16,8 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.portfolio.interestratechart.data; +package org.apache.fineract.portfolio.interestratechart.domain; -import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlab; import org.apache.fineract.portfolio.interestratechart.exception.InterestRateChartSlabNotFoundException; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartAssembler.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartAssembler.java index 39d3d2ede..d060b8d59 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartAssembler.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartAssembler.java @@ -35,9 +35,9 @@ import org.apache.fineract.infrastructure.core.data.ApiParameterError; import org.apache.fineract.infrastructure.core.data.DataValidatorBuilder; import org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException; import org.apache.fineract.infrastructure.core.serialization.FromJsonHelper; -import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChart; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartFields; +import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlab; import org.joda.time.LocalDate; import org.springframework.beans.factory.annotation.Autowired; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabAssembler.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabAssembler.java index 35fc2673a..eef49be9b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabAssembler.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabAssembler.java @@ -43,8 +43,8 @@ import org.apache.fineract.infrastructure.core.data.ApiParameterError; import org.apache.fineract.infrastructure.core.data.DataValidatorBuilder; import org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException; import org.apache.fineract.infrastructure.core.serialization.FromJsonHelper; -import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChart; +import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlab; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlabFields; import org.apache.fineract.portfolio.interestratechart.exception.InterestRateChartSlabNotFoundException; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabWritePlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabWritePlatformServiceJpaRepositoryImpl.java index 0daeac12e..a31d88cc8 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabWritePlatformServiceJpaRepositoryImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabWritePlatformServiceJpaRepositoryImpl.java @@ -25,10 +25,10 @@ import org.apache.fineract.infrastructure.core.api.JsonCommand; import org.apache.fineract.infrastructure.core.data.CommandProcessingResult; import org.apache.fineract.infrastructure.core.data.CommandProcessingResultBuilder; import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext; -import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartSlabDataValidator; -import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartSlabRepository; +import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlab; +import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartSlabRepository; import org.apache.fineract.portfolio.savings.domain.SavingsProductRepository; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartWritePlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartWritePlatformServiceJpaRepositoryImpl.java index 7ae7f0b01..eb8f2b7b7 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartWritePlatformServiceJpaRepositoryImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartWritePlatformServiceJpaRepositoryImpl.java @@ -25,8 +25,8 @@ import org.apache.fineract.infrastructure.core.data.CommandProcessingResult; import org.apache.fineract.infrastructure.core.data.CommandProcessingResultBuilder; import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext; import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartDataValidator; -import org.apache.fineract.portfolio.interestratechart.data.InterestRateChartRepositoryWrapper; import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChart; +import org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartRepositoryWrapper; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; diff --git a/fineract-provider/src/main/java/org/apache/fineract/spm/repository/LookupTableRepository.java b/fineract-provider/src/main/java/org/apache/fineract/spm/domain/LookupTableRepository.java similarity index 88% rename from fineract-provider/src/main/java/org/apache/fineract/spm/repository/LookupTableRepository.java rename to fineract-provider/src/main/java/org/apache/fineract/spm/domain/LookupTableRepository.java index 698b700a3..37073ad62 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/spm/repository/LookupTableRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/spm/domain/LookupTableRepository.java @@ -16,11 +16,9 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.spm.repository; +package org.apache.fineract.spm.domain; import java.util.List; -import org.apache.fineract.spm.domain.LookupTable; -import org.apache.fineract.spm.domain.Survey; import org.springframework.data.jpa.repository.JpaRepository; public interface LookupTableRepository extends JpaRepository { diff --git a/fineract-provider/src/main/java/org/apache/fineract/spm/repository/ScorecardRepository.java b/fineract-provider/src/main/java/org/apache/fineract/spm/domain/ScorecardRepository.java similarity index 89% rename from fineract-provider/src/main/java/org/apache/fineract/spm/repository/ScorecardRepository.java rename to fineract-provider/src/main/java/org/apache/fineract/spm/domain/ScorecardRepository.java index 94e36e944..9acf74c37 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/spm/repository/ScorecardRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/spm/domain/ScorecardRepository.java @@ -16,12 +16,10 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.spm.repository; +package org.apache.fineract.spm.domain; import java.util.List; import org.apache.fineract.portfolio.client.domain.Client; -import org.apache.fineract.spm.domain.Scorecard; -import org.apache.fineract.spm.domain.Survey; import org.springframework.data.jpa.repository.JpaRepository; public interface ScorecardRepository extends JpaRepository { diff --git a/fineract-provider/src/main/java/org/apache/fineract/spm/repository/SurveyRepository.java b/fineract-provider/src/main/java/org/apache/fineract/spm/domain/SurveyRepository.java similarity index 94% rename from fineract-provider/src/main/java/org/apache/fineract/spm/repository/SurveyRepository.java rename to fineract-provider/src/main/java/org/apache/fineract/spm/domain/SurveyRepository.java index 13d390ac6..e834d1821 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/spm/repository/SurveyRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/spm/domain/SurveyRepository.java @@ -16,11 +16,10 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.fineract.spm.repository; +package org.apache.fineract.spm.domain; import java.util.Date; import java.util.List; -import org.apache.fineract.spm.domain.Survey; import org.springframework.data.jpa.repository.JpaRepository; import org.springframework.data.jpa.repository.Query; import org.springframework.data.repository.query.Param; diff --git a/fineract-provider/src/main/java/org/apache/fineract/spm/service/LookupTableService.java b/fineract-provider/src/main/java/org/apache/fineract/spm/service/LookupTableService.java index b42b8049d..f98d4ab42 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/spm/service/LookupTableService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/spm/service/LookupTableService.java @@ -21,8 +21,8 @@ package org.apache.fineract.spm.service; import java.util.List; import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext; import org.apache.fineract.spm.domain.LookupTable; +import org.apache.fineract.spm.domain.LookupTableRepository; import org.apache.fineract.spm.domain.Survey; -import org.apache.fineract.spm.repository.LookupTableRepository; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; diff --git a/fineract-provider/src/main/java/org/apache/fineract/spm/service/ScorecardService.java b/fineract-provider/src/main/java/org/apache/fineract/spm/service/ScorecardService.java index fb8ca7a95..52b162ca8 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/spm/service/ScorecardService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/spm/service/ScorecardService.java @@ -22,8 +22,8 @@ import java.util.List; import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext; import org.apache.fineract.portfolio.client.domain.Client; import org.apache.fineract.spm.domain.Scorecard; +import org.apache.fineract.spm.domain.ScorecardRepository; import org.apache.fineract.spm.domain.Survey; -import org.apache.fineract.spm.repository.ScorecardRepository; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; diff --git a/fineract-provider/src/main/java/org/apache/fineract/spm/service/SpmService.java b/fineract-provider/src/main/java/org/apache/fineract/spm/service/SpmService.java index 11701a6e4..b883e0d54 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/spm/service/SpmService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/spm/service/SpmService.java @@ -26,9 +26,9 @@ import org.apache.fineract.infrastructure.core.exception.PlatformDataIntegrityEx import org.apache.fineract.infrastructure.core.service.DateUtils; import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext; import org.apache.fineract.spm.domain.Survey; +import org.apache.fineract.spm.domain.SurveyRepository; import org.apache.fineract.spm.domain.SurveyValidator; import org.apache.fineract.spm.exception.SurveyNotFoundException; -import org.apache.fineract.spm.repository.SurveyRepository; import org.apache.openjpa.persistence.EntityExistsException; import org.joda.time.DateTime; import org.joda.time.LocalDate; diff --git a/fineract-provider/src/main/resources/META-INF/spring/appContext.xml b/fineract-provider/src/main/resources/META-INF/spring/appContext.xml index 8ed13e37a..90b7ed1a7 100644 --- a/fineract-provider/src/main/resources/META-INF/spring/appContext.xml +++ b/fineract-provider/src/main/resources/META-INF/spring/appContext.xml @@ -34,31 +34,7 @@ - + @@ -73,21 +49,7 @@ - - - - - - - - - - - - - - - + @@ -110,6 +72,4 @@ - - diff --git a/fineract-provider/src/main/resources/META-INF/spring/spmContext.xml b/fineract-provider/src/main/resources/META-INF/spring/spmContext.xml deleted file mode 100644 index 0b93ee0ff..000000000 --- a/fineract-provider/src/main/resources/META-INF/spring/spmContext.xml +++ /dev/null @@ -1,37 +0,0 @@ - - - - - - - - - -