CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 19 Packages Projects Releases Wiki Activity

FINERACT-1061: Removing call to rs.beforeFirst()

Browse Source
This commit is contained in:
Petri Tuomola
2020-07-01 22:31:33 +02:00
committed by Michael Vorburger ⛑️
parent 9ed9153cba
commit 6e279619a5
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/productmix/service/ProductMixReadPlatformServiceImpl.java
+2 -4
View File
@@ -111,9 +111,7 @@ public class ProductMixReadPlatformServiceImpl implements ProductMixReadPlatform
extractedData.put(this.productId, productMixData); extractedData.put(this.productId, productMixData);
return extractedData; return extractedData;
} }
/* move the cursor to starting of resultset */ do {
rs.beforeFirst();
while (rs.next()) {
final Long productId = rs.getLong("productId"); final Long productId = rs.getLong("productId");
final String name = rs.getString("name"); final String name = rs.getString("name");
final Collection<LoanProductData> restrictedProducts = this.loanProductReadPlatformService final Collection<LoanProductData> restrictedProducts = this.loanProductReadPlatformService
@@ -122,7 +120,7 @@ public class ProductMixReadPlatformServiceImpl implements ProductMixReadPlatform
.retrieveAllowedProductsForMix(productId); .retrieveAllowedProductsForMix(productId);
final ProductMixData productMixData = ProductMixData.withDetails(productId, name, restrictedProducts, allowedProducts); final ProductMixData productMixData = ProductMixData.withDetails(productId, name, restrictedProducts, allowedProducts);
extractedData.put(productId, productMixData); extractedData.put(productId, productMixData);
} } while (rs.next());
return extractedData; return extractedData;
} }
} }