FINERACT-821 Added and Enforced FinalClass checkstyle

fineract-provider/config/checkstyle/checkstyle.xml

@@ -57,6 +57,7 @@
             <property name="ignoreComments" value="false" />
         </module>
         <module name="EqualsHashCode"/>
+        <module name="FinalClass"/>
         <module name="SeparatorWrap">
             <property name="tokens" value="COMMA"/>
             <property name="option" value="EOL"/>
@@ -177,7 +178,7 @@
             <property name="ignoreSetter" value="true" />
             <property name="setterCanReturnItsClass" value="true" />
         </module>
-        <module name="FinalClass"/>
+
         <module name="HideUtilityClassConstructor"/>
 
         < ! - - TODO Checks for Exception Handling Anti-Patterns - - >

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/BatchHelper.java

@@ -40,7 +40,7 @@ import org.slf4j.LoggerFactory;
  *
  * @see org.apache.fineract.integrationtests.BatchApiTest
  */
-public class BatchHelper {
+public final class BatchHelper {
 
     private final static Logger LOG = LoggerFactory.getLogger(BatchHelper.class);
     private static final String BATCH_API_URL = "/fineract-provider/api/v1/batches?" + Utils.TENANT_IDENTIFIER;

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java

@@ -28,7 +28,7 @@ public class CenterDomain implements Comparable<CenterDomain> {
 
     private final static Logger LOG = LoggerFactory.getLogger(CenterDomain.class);
 
-    public static class Builder {
+    public final static class Builder {
 
         private final Integer id;
         private final String accountNo;

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CurrencyDomain.java

@@ -22,7 +22,7 @@ import com.google.gson.Gson;
 
 public class CurrencyDomain implements Comparable<CurrencyDomain> {
 
-    public static class Builder {
+    public final static class Builder {
 
         private String code;
         private String name;

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/OfficeDomain.java

@@ -23,7 +23,7 @@ import java.util.Arrays;
 
 public class OfficeDomain {
 
-    public static class Builder {
+    public final static class Builder {
 
         private int id;
         private String name;

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/PaymentTypeDomain.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.integrationtests.common;
 
-public class PaymentTypeDomain {
+public final class PaymentTypeDomain {
 
     private Integer id;
     private String name;

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/funds/FundsHelper.java

@@ -22,7 +22,7 @@ import com.google.gson.Gson;
 
 public class FundsHelper {
 
-    public static class Builder {
+    final public static class Builder {
 
         private String name;
         private String externalId;

fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/data/OfficeOpeningBalancesData.java

@@ -22,7 +22,7 @@ import java.util.List;
 import org.apache.fineract.accounting.glaccount.data.GLAccountData;
 import org.joda.time.LocalDate;
 
-public class OfficeOpeningBalancesData {
+public final class OfficeOpeningBalancesData {
 
     @SuppressWarnings("unused")
     private final Long officeId;

fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/AdHoc.java

@@ -32,7 +32,7 @@ import org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator;
 
 @Entity
 @Table(name = "m_adhoc")
-public class AdHoc extends AbstractAuditableCustom {
+public final class AdHoc extends AbstractAuditableCustom {
 
     @Column(name = "name", length = 100)
     private String name;

fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandContext.java

@@ -28,14 +28,14 @@ package org.apache.fineract.batch.command;
  *
  * @see org.apache.fineract.batch.service.BatchApiService
  */
-public class CommandContext {
+public final class CommandContext {
 
     /**
      * Static Builder class to provide a Build method for CommandContext.
      *
      * @author Rishabh Shukla
      */
-    public static class Builder {
+    public final static class Builder {
 
         private String resource;
         private String method;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/BulkImportEvent.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.bulkimport.data;
 import org.apache.poi.ss.usermodel.Workbook;
 import org.springframework.context.ApplicationEvent;
 
-public class BulkImportEvent extends ApplicationEvent {
+public final class BulkImportEvent extends ApplicationEvent {
 
     private final String tenantIdentifier;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/Count.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.bulkimport.data;
 
-public class Count {
+public final class Count {
 
     private Integer successCount;
     private Integer errorCount;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportData.java

@@ -20,7 +20,7 @@ package org.apache.fineract.infrastructure.bulkimport.data;
 
 import org.joda.time.LocalDate;
 
-public class ImportData {
+public final class ImportData {
 
     @SuppressWarnings("unused")
     private Long importId;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache/data/CacheData.java

@@ -20,7 +20,7 @@ package org.apache.fineract.infrastructure.cache.data;
 
 import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 
-public class CacheData {
+public final class CacheData {
 
     @SuppressWarnings("unused")
     private final EnumOptionData cacheType;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/data/EmailCampaignData.java

@@ -22,7 +22,7 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 import org.joda.time.DateTime;
 import org.joda.time.LocalDate;
 
-public class EmailCampaignData {
+public final class EmailCampaignData {
 
     @SuppressWarnings("unused")
     private Long id;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/data/EmailConfigurationData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.campaigns.email.data;
 /**
  * Immutable data object representing an Email configuration.
  */
-public class EmailConfigurationData {
+public final class EmailConfigurationData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/data/EmailConfigurationValidator.java

@@ -40,7 +40,7 @@ import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
 @Component
-public class EmailConfigurationValidator {
+public final class EmailConfigurationValidator {
 
     private final FromJsonHelper fromApiJsonHelper;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/data/EmailData.java

@@ -26,7 +26,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing a SMS message.
  */
-public class EmailData {
+public final class EmailData {
 
     private final Long id;
     private final Long groupId;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/data/EmailMessageWithAttachmentData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.campaigns.email.data;
 import java.io.File;
 import java.util.List;
 
-public class EmailMessageWithAttachmentData {
+public final class EmailMessageWithAttachmentData {
 
     private final String to;
     private final String text;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailMessageJobEmailServiceImpl.java

@@ -35,7 +35,7 @@ import org.springframework.mail.javamail.MimeMessageHelper;
 import org.springframework.stereotype.Service;
 
 @Service
-public class EmailMessageJobEmailServiceImpl implements EmailMessageJobEmailService {
+public final class EmailMessageJobEmailServiceImpl implements EmailMessageJobEmailService {
 
     private final static Logger LOG = LoggerFactory.getLogger(EmailMessageJobEmailServiceImpl.class);
     private EmailConfigurationRepository emailConfigurationRepository;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/data/SmsCampaignData.java

@@ -24,7 +24,7 @@ import org.joda.time.DateTime;
 import org.joda.time.LocalDate;
 
 @SuppressWarnings("unused")
-public class SmsCampaignData {
+public final class SmsCampaignData {
 
     private Long id;
     private final String campaignName;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/data/CodeData.java

@@ -23,7 +23,7 @@ import java.io.Serializable;
 /**
  * Immutable data object representing a code.
  */
-public class CodeData implements Serializable {
+public final class CodeData implements Serializable {
 
     private final Long id;
     @SuppressWarnings("unused")

fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/data/PaginationParameters.java

@@ -25,7 +25,7 @@ import org.apache.commons.lang3.StringUtils;
  * Immutable data object representing pagination parameter values.
  * </p>
  */
-public class PaginationParameters {
+public final class PaginationParameters {
 
     private final boolean paged;
     private final Integer offset;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauConfigurationData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.creditbureau.data;
 
-public class CreditBureauConfigurationData {
+public final class CreditBureauConfigurationData {
 
     private final long creditBureauConfigurationId;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.creditbureau.data;
 
-public class CreditBureauData {
+public final class CreditBureauData {
 
     private final long creditBureauId;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauLoanProductMappingData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.creditbureau.data;
 
-public class CreditBureauLoanProductMappingData {
+public final class CreditBureauLoanProductMappingData {
 
     private final long creditbureauLoanProductMappingId;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauMasterData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.creditbureau.data;
 
-public class CreditBureauMasterData {
+public final class CreditBureauMasterData {
 
     private final long creditBureauId;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauProduct.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.creditbureau.data;
 
-public class CreditBureauProduct {
+public final class CreditBureauProduct {
 
     private final long creditBureauProductId;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/OrganisationCreditBureauData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.creditbureau.data;
 
-public class OrganisationCreditBureauData {
+public final class OrganisationCreditBureauData {
 
     private final long organisationCreditBureauId;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/DatatableData.java

@@ -24,7 +24,7 @@ import java.util.List;
 /**
  * Immutable data object representing datatable data.
  */
-public class DatatableData implements Serializable {
+public final class DatatableData implements Serializable {
 
     @SuppressWarnings("unused")
     private final String applicationTableName;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ReportData.java

@@ -22,7 +22,7 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
 
-final public class ReportData {
+public final class ReportData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ReportParameterData.java

@@ -19,7 +19,7 @@
 package org.apache.fineract.infrastructure.dataqueries.data;
 
 /* used to show list of parameters used by a report and also for getting a list of parameters available (the reportParameterName is left null */
-final public class ReportParameterData {
+public final class ReportParameterData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ReportParameterJoinData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.dataqueries.data;
 
-final public class ReportParameterJoinData {
+public final class ReportParameterJoinData {
 
     private final Long reportId;
     private final String reportName;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetRowData.java

@@ -20,7 +20,7 @@ package org.apache.fineract.infrastructure.dataqueries.data;
 
 import java.util.List;
 
-public class ResultsetRowData {
+public final class ResultsetRowData {
 
     private final List<String> row;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/data/FineractEntityToEntityMappingData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.entityaccess.data;
 import java.io.Serializable;
 import java.util.Date;
 
-public class FineractEntityToEntityMappingData implements Serializable {
+public final class FineractEntityToEntityMappingData implements Serializable {
 
     @SuppressWarnings("unused")
     private Long mapId;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/domain/FineractEntityAccessType.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.entityaccess.domain;
 
-public class FineractEntityAccessType {
+public final class FineractEntityAccessType {
 
     private String str;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/domain/FineractEntityRelationRepositoryWrapper.java

@@ -23,7 +23,7 @@ import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 
 @Service
-public class FineractEntityRelationRepositoryWrapper {
+public final class FineractEntityRelationRepositoryWrapper {
 
     private final FineractEntityRelationRepository fineractEntityRelationRepository;
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/domain/FineractEntityType.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.infrastructure.entityaccess.domain;
 
-public class FineractEntityType {
+public final class FineractEntityType {
 
     private String type;
     private String description;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/DeviceRegistration.java

@@ -32,7 +32,7 @@ import org.apache.fineract.portfolio.client.domain.Client;
 
 @Entity
 @Table(name = "client_device_registration")
-public class DeviceRegistration extends AbstractPersistableCustom {
+public final class DeviceRegistration extends AbstractPersistableCustom {
 
     @OneToOne
     @JoinColumn(name = "client_id", nullable = false, unique = true)

fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/DeviceRegistrationData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.gcm.domain;
 import java.util.Date;
 import org.apache.fineract.portfolio.client.data.ClientData;
 
-public class DeviceRegistrationData {
+public final class DeviceRegistrationData {
 
     public Long id;
     public ClientData clientData;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/data/Event.java

@@ -20,7 +20,7 @@ package org.apache.fineract.infrastructure.hooks.data;
 
 import java.io.Serializable;
 
-public class Event implements Serializable {
+public final class Event implements Serializable {
 
     private final String actionName;
     private final String entityName;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/data/Field.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.hooks.data;
 import java.io.Serializable;
 
 @SuppressWarnings("unused")
-public class Field implements Serializable {
+public final class Field implements Serializable {
 
     private final String fieldName;
     private final String fieldValue;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/data/HookData.java

@@ -22,7 +22,7 @@ import java.io.Serializable;
 import java.util.List;
 import org.joda.time.LocalDate;
 
-public class HookData implements Serializable {
+public final class HookData implements Serializable {
 
     private final Long id;
     private final String name;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/data/HookTemplateData.java

@@ -22,7 +22,7 @@ import java.io.Serializable;
 import java.util.List;
 
 @SuppressWarnings("unused")
-public class HookTemplateData implements Serializable {
+public final class HookTemplateData implements Serializable {
 
     private final Long id;
     private final String name;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/data/ReportMailingJobConfigurationData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.infrastructure.reportmailingjob.data;
 /**
  * Immutable data object representing report mailing job configuration data.
  **/
-public class ReportMailingJobConfigurationData {
+public final class ReportMailingJobConfigurationData {
 
     private final int id;
     private final String name;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/data/ReportMailingJobData.java

@@ -26,7 +26,7 @@ import org.joda.time.DateTime;
 /**
  * Immutable data object representing report mailing job data.
  **/
-public class ReportMailingJobData {
+public final class ReportMailingJobData {
 
     private final Long id;
     private final String name;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/data/ReportMailingJobRunHistoryData.java

@@ -23,7 +23,7 @@ import org.joda.time.DateTime;
 /**
  * Immutable data object representing report mailing job run history data.
  **/
-public class ReportMailingJobRunHistoryData {
+public final class ReportMailingJobRunHistoryData {
 
     private final Long id;
     private final Long reportMailingJobId;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/data/PlatformRequestLog.java

@@ -28,7 +28,7 @@ import org.apache.commons.lang3.time.StopWatch;
  * Immutable data object representing platform API request used for
  * logging/debugging.
  */
-public class PlatformRequestLog {
+public final class PlatformRequestLog {
 
     @SuppressWarnings("unused")
     private final long startTime;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/data/SmsData.java

@@ -23,7 +23,7 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 /**
  * Immutable data object representing a SMS message.
  */
-public class SmsData {
+public final class SmsData {
 
     private final Long id;
     private final Long groupId;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/data/SurveyDataTableData.java

@@ -20,7 +20,7 @@ package org.apache.fineract.infrastructure.survey.data;
 
 import org.apache.fineract.infrastructure.dataqueries.data.DatatableData;
 
-public class SurveyDataTableData {
+public final class SurveyDataTableData {
 
     @SuppressWarnings("unused")
     private final DatatableData datatableData;

fineract-provider/src/main/java/org/apache/fineract/interoperation/data/InteropQuoteResponseData.java

@@ -24,7 +24,7 @@ import javax.validation.constraints.NotNull;
 import org.apache.fineract.interoperation.domain.InteropActionState;
 import org.joda.time.LocalDateTime;
 
-public class InteropQuoteResponseData extends InteropResponseData {
+public final class InteropQuoteResponseData extends InteropResponseData {
 
     @NotNull
     private final String quoteCode;

fineract-provider/src/main/java/org/apache/fineract/interoperation/data/InteropTransactionRequestResponseData.java

@@ -24,7 +24,7 @@ import javax.validation.constraints.NotNull;
 import org.apache.fineract.interoperation.domain.InteropActionState;
 import org.joda.time.LocalDateTime;
 
-public class InteropTransactionRequestResponseData extends InteropResponseData {
+public final class InteropTransactionRequestResponseData extends InteropResponseData {
 
     @NotNull
     private final String requestCode;

fineract-provider/src/main/java/org/apache/fineract/interoperation/data/InteropTransferResponseData.java

@@ -26,7 +26,7 @@ import javax.validation.constraints.NotNull;
 import org.apache.fineract.interoperation.domain.InteropActionState;
 import org.joda.time.LocalDateTime;
 
-public class InteropTransferResponseData extends InteropResponseData {
+public final class InteropTransferResponseData extends InteropResponseData {
 
     @NotNull
     private final String transferCode;

fineract-provider/src/main/java/org/apache/fineract/organisation/office/data/OfficeTransactionData.java

@@ -26,7 +26,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object for office transactions.
  */
-public class OfficeTransactionData {
+public final class OfficeTransactionData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/data/ProvisioningCriteriaData.java

@@ -25,7 +25,7 @@ import org.apache.fineract.accounting.glaccount.data.GLAccountData;
 import org.apache.fineract.portfolio.loanproduct.data.LoanProductData;
 
 @SuppressWarnings("unused")
-public class ProvisioningCriteriaData implements Comparable<ProvisioningCriteriaData>, Serializable {
+public final class ProvisioningCriteriaData implements Comparable<ProvisioningCriteriaData>, Serializable {
 
     private final Long criteriaId;
     private final String criteriaName;

fineract-provider/src/main/java/org/apache/fineract/organisation/staff/data/BulkTransferLoanOfficerData.java

@@ -25,7 +25,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object returned for loan-officer bulk transfer screens.
  */
-public class BulkTransferLoanOfficerData {
+public final class BulkTransferLoanOfficerData {
 
     @SuppressWarnings("unused")
     private final Long officeId;

fineract-provider/src/main/java/org/apache/fineract/organisation/staff/data/StaffData.java

@@ -26,7 +26,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing staff data.
  */
-public class StaffData implements Serializable {
+public final class StaffData implements Serializable {
 
     private final Long id;
     private final String externalId;

fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/CashierTxnType.java

@@ -20,7 +20,7 @@ package org.apache.fineract.organisation.teller.domain;
 
 import java.io.Serializable;
 
-public class CashierTxnType implements Serializable {
+public final class CashierTxnType implements Serializable {
 
     private Integer id;
     private String value;

fineract-provider/src/main/java/org/apache/fineract/portfolio/account/data/AccountTransferData.java

@@ -31,7 +31,7 @@ import org.joda.time.LocalDate;
  * Immutable data object representing a savings account.
  */
 @SuppressWarnings("unused")
-public class AccountTransferData implements Serializable {
+public final class AccountTransferData implements Serializable {
 
     private final Long id;
     private final Boolean reversed;

fineract-provider/src/main/java/org/apache/fineract/portfolio/account/data/StandingInstructionData.java

@@ -38,7 +38,7 @@ import org.joda.time.MonthDay;
  * Immutable data object representing a savings account.
  */
 @SuppressWarnings("unused")
-public class StandingInstructionData {
+public final class StandingInstructionData {
 
     private final Long id;
     private final Long accountDetailId;

fineract-provider/src/main/java/org/apache/fineract/portfolio/address/data/ClientAddressData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.portfolio.address.data;
 
-public class ClientAddressData {
+public final class ClientAddressData {
 
     private final long clientAddressId;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/address/data/FieldConfigurationData.java

@@ -18,7 +18,7 @@
  */
 package org.apache.fineract.portfolio.address.data;
 
-public class FieldConfigurationData {
+public final class FieldConfigurationData {
 
     private final long fieldConfigurationId;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/data/CalendarData.java

@@ -36,7 +36,7 @@ import org.joda.time.LocalTime;
 /**
  * Immutable data object representing a Calendar.
  */
-public class CalendarData implements Serializable {
+public final class CalendarData implements Serializable {
 
     private final Long id;
     private final Long calendarInstanceId;

fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeData.java

@@ -37,7 +37,7 @@ import org.joda.time.MonthDay;
 /**
  * Immutable data object for charge data.
  */
-public class ChargeData implements Comparable<ChargeData>, Serializable {
+public final class ChargeData implements Comparable<ChargeData>, Serializable {
 
     private final Long id;
     private final String name;

fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientChargeData.java

@@ -26,7 +26,7 @@ import org.apache.fineract.portfolio.charge.data.ChargeData;
 import org.joda.time.LocalDate;
 
 @SuppressWarnings("unused")
-public class ClientChargeData {
+public final class ClientChargeData {
 
     private final Long id;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java

@@ -40,7 +40,7 @@ import org.joda.time.LocalDate;
  * Immutable data object representing client data.
  */
 @SuppressWarnings("unused")
-final public class ClientData implements Comparable<ClientData>, Serializable {
+public final class ClientData implements Comparable<ClientData>, Serializable {
 
     private final Long id;
     private final String accountNo;

fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientFamilyMembersData.java

@@ -24,7 +24,7 @@ import java.util.Collection;
 import org.apache.fineract.infrastructure.codes.data.CodeValueData;
 import org.joda.time.LocalDate;
 
-public class ClientFamilyMembersData implements Serializable {
+public final class ClientFamilyMembersData implements Serializable {
 
     private final Long id;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientTransactionData.java

@@ -27,7 +27,7 @@ import org.apache.fineract.portfolio.paymenttype.data.PaymentTypeData;
 import org.joda.time.LocalDate;
 
 @SuppressWarnings("unused")
-public class ClientTransactionData {
+public final class ClientTransactionData {
 
     private final Long id;
     private final Long officeId;

fineract-provider/src/main/java/org/apache/fineract/portfolio/client/serialization/ClientFamilyMemberCommandFromApiJsonDeserializer.java

@@ -41,7 +41,7 @@ import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
 @Component
-public class ClientFamilyMemberCommandFromApiJsonDeserializer {
+public final class ClientFamilyMemberCommandFromApiJsonDeserializer {
 
     private final FromJsonHelper fromApiJsonHelper;
     private final Set<String> supportedParameters = new HashSet<>(Arrays.asList("id", "clientId", "firstName", "middleName", "lastName",

fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/data/CollateralData.java

@@ -26,7 +26,7 @@ import org.apache.fineract.organisation.monetary.data.CurrencyData;
 /**
  * Immutable data object for Collateral data.
  */
-public class CollateralData {
+public final class CollateralData {
 
     private final Long id;
     private final CodeValueData type;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/data/IndividualClientData.java

@@ -24,7 +24,7 @@ import java.util.Collection;
  * Immutable data object for clients with loans due for disbursement or
  * collection.
  */
-public class IndividualClientData {
+public final class IndividualClientData {
 
     private final Long clientId;
     private final String clientName;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/data/IndividualCollectionSheetData.java

@@ -25,7 +25,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object for collection sheet.
  */
-public class IndividualCollectionSheetData {
+public final class IndividualCollectionSheetData {
 
     @SuppressWarnings("unused")
     private final LocalDate dueDate;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/data/JLGClientData.java

@@ -25,7 +25,7 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData;
  * Immutable data object for clients with loans due for disbursement or
  * collection.
  */
-public class JLGClientData {
+public final class JLGClientData {
 
     private final Long clientId;
     private final String clientName;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/data/JLGCollectionSheetData.java

@@ -29,7 +29,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object for join liability group's collection sheet.
  */
-public class JLGCollectionSheetData {
+public final class JLGCollectionSheetData {
 
     private final LocalDate dueDate;
     private final Collection<LoanProductData> loanProducts;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/data/JLGGroupData.java

@@ -24,7 +24,7 @@ import java.util.Collection;
  * Immutable data object for groups with clients due for disbursement or
  * collection.
  */
-public class JLGGroupData {
+public final class JLGGroupData {
 
     private final Long groupId;
     private final String groupName;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/data/SavingsDueData.java

@@ -25,7 +25,7 @@ import org.apache.fineract.organisation.monetary.data.CurrencyData;
  * Immutable data object for representing loan with dues (example: loan is due
  * for disbursement, repayments).
  */
-public class SavingsDueData {
+public final class SavingsDueData {
 
     @SuppressWarnings("unused")
     private final Long savingsId;

fineract-provider/src/main/java/org/apache/fineract/portfolio/fund/data/FundData.java

@@ -23,7 +23,7 @@ import java.io.Serializable;
 /**
  * Immutable data object to represent fund data.
  */
-public class FundData implements Serializable {
+public final class FundData implements Serializable {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/group/data/CenterData.java

@@ -34,7 +34,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing groups.
  */
-public class CenterData implements Serializable {
+public final class CenterData implements Serializable {
 
     private final Long id;
     private String accountNo;

fineract-provider/src/main/java/org/apache/fineract/portfolio/group/data/StaffCenterData.java

@@ -20,7 +20,7 @@ package org.apache.fineract.portfolio.group.data;
 
 import java.util.Collection;
 
-public class StaffCenterData {
+public final class StaffCenterData {
 
     private final Long staffId;
     @SuppressWarnings("unused")

fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestIncentiveData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.portfolio.interestratechart.data;
 import java.math.BigDecimal;
 import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 
-public class InterestIncentiveData {
+public final class InterestIncentiveData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartData.java

@@ -27,7 +27,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing a InterestRateChart.
  */
-public class InterestRateChartData {
+public final class InterestRateChartData {
 
     private final Long id;
     private final String name;

fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabData.java

@@ -29,7 +29,7 @@ import org.apache.fineract.organisation.monetary.data.CurrencyData;
 /**
  * Immutable data object representing a InterestRateChartSlab.
  */
-public class InterestRateChartSlabData {
+public final class InterestRateChartSlabData {
 
     private final Long id;
     private final String description;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/GlimRepaymentTemplate.java

@@ -21,7 +21,7 @@ package org.apache.fineract.portfolio.loanaccount.data;
 
 import java.math.BigDecimal;
 
-public class GlimRepaymentTemplate {
+public final class GlimRepaymentTemplate {
 
     private final BigDecimal glimId;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/GroupLoanIndividualMonitoringAccountData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.portfolio.loanaccount.data;
 
 import java.math.BigDecimal;
 
-public class GroupLoanIndividualMonitoringAccountData {
+public final class GroupLoanIndividualMonitoringAccountData {
 
     private final BigDecimal glimId;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java

@@ -58,7 +58,7 @@ import org.springframework.util.CollectionUtils;
  * Immutable data object representing loan account data.
  */
 @SuppressWarnings("unused")
-public class LoanAccountData {
+public final class LoanAccountData {
 
     // basic loan details
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/GroupLoanIndividualMonitoringAccount.java

@@ -33,7 +33,7 @@ import org.apache.fineract.portfolio.group.domain.Group;
 
 @Entity
 @Table(name = "glim_accounts", uniqueConstraints = { @UniqueConstraint(columnNames = { "account_number" }, name = "FK_glim_id") })
-public class GroupLoanIndividualMonitoringAccount extends AbstractPersistableCustom {
+public final class GroupLoanIndividualMonitoringAccount extends AbstractPersistableCustom {
 
     @ManyToOne
     @JoinColumn(name = "group_id", nullable = false)

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/data/GuarantorFundingData.java

@@ -23,7 +23,7 @@ import java.util.Collection;
 import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 import org.apache.fineract.portfolio.account.data.PortfolioAccountData;
 
-public class GuarantorFundingData {
+public final class GuarantorFundingData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/data/GuarantorTransactionData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.portfolio.loanaccount.guarantor.data;
 import org.apache.fineract.portfolio.loanaccount.data.LoanTransactionData;
 import org.apache.fineract.portfolio.savings.data.DepositAccountOnHoldTransactionData;
 
-public class GuarantorTransactionData {
+public final class GuarantorTransactionData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/data/ObligeeData.java

@@ -22,7 +22,7 @@ package org.apache.fineract.portfolio.loanaccount.guarantor.data;
 import java.math.BigDecimal;
 
 @SuppressWarnings("unused")
-public class ObligeeData {
+public final class ObligeeData {
 
     private final String firstName;
     private final String lastName;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/LoanScheduleDTO.java

@@ -25,7 +25,7 @@ import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanSchedul
 /**
  * Transfer object to return the schedule after generation of schedule
  */
-public class LoanScheduleDTO {
+public final class LoanScheduleDTO {
 
     private final List<LoanRepaymentScheduleInstallment> installments;
     private final LoanScheduleModel loanScheduleModel;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/LoanScheduleParams.java

@@ -31,7 +31,7 @@ import org.apache.fineract.portfolio.loanaccount.domain.transactionprocessor.Loa
 import org.apache.fineract.portfolio.loanaccount.loanschedule.domain.RecalculationDetail;
 import org.joda.time.LocalDate;
 
-public class LoanScheduleParams {
+public final class LoanScheduleParams {
 
     // Actual period Number as per the schedule
     private int periodNumber;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java

@@ -26,7 +26,7 @@ import org.joda.time.LocalDate;
  * Immutable data object that represents a period of a loan schedule.
  *
  */
-public class LoanSchedulePeriodData {
+public final class LoanSchedulePeriodData {
 
     private final Integer period;
     private final LocalDate fromDate;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/rescheduleloan/data/LoanRescheduleRequestData.java

@@ -26,7 +26,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing loan reschedule request data.
  **/
-public class LoanRescheduleRequestData {
+public final class LoanRescheduleRequestData {
 
     private final Long id;
     private final Long loanId;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/data/LoanProductGuaranteeData.java

@@ -21,7 +21,7 @@ package org.apache.fineract.portfolio.loanproduct.data;
 import java.io.Serializable;
 import java.math.BigDecimal;
 
-public class LoanProductGuaranteeData implements Serializable {
+public final class LoanProductGuaranteeData implements Serializable {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/meeting/attendance/data/ClientAttendanceData.java

@@ -23,7 +23,7 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 /**
  * Immutable data object representing a ClientAttendance.
  */
-public class ClientAttendanceData {
+public final class ClientAttendanceData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/meeting/data/MeetingData.java

@@ -29,7 +29,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing a Meeting.
  */
-public class MeetingData {
+public final class MeetingData {
 
     private final Long id;
     private final LocalDate meetingDate;

fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/data/RateData.java

@@ -26,7 +26,7 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 /**
  * Bowpi GT Created by Jose on 19/07/2017.
  */
-public class RateData implements Serializable {
+public final class RateData implements Serializable {
 
     private Long id;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/ClosingOfSavingsAccounts.java

@@ -20,7 +20,7 @@ package org.apache.fineract.portfolio.savings.data;
 
 import org.joda.time.LocalDate;
 
-public class ClosingOfSavingsAccounts {
+public final class ClosingOfSavingsAccounts {
 
     private final transient Integer rowIndex;
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/DepositAccountInterestIncentiveData.java

@@ -22,7 +22,7 @@ import java.math.BigDecimal;
 import org.apache.fineract.infrastructure.core.data.EnumOptionData;
 import org.apache.fineract.portfolio.interestratechart.data.InterestIncentiveData;
 
-public class DepositAccountInterestIncentiveData {
+public final class DepositAccountInterestIncentiveData {
 
     @SuppressWarnings("unused")
     private final Long id;

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/DepositAccountInterestRateChartData.java

@@ -29,7 +29,7 @@ import org.joda.time.LocalDate;
 /**
  * Immutable data object representing a deposit account interest rate chart.
  */
-public class DepositAccountInterestRateChartData {
+public final class DepositAccountInterestRateChartData {
 
     private final Long id;
     private final String name;