api doc and error update

APIFolder/api.htm

@@ -1717,7 +1717,7 @@ Request Body:{
 }
                 </code>
                 <code class="method-response">{
-    "entityId": 10
+    "entityId": 16
 }
                 </code>
             </div>

APIFolder/docUpdateComments.txt

@@ -63,9 +63,6 @@ when adjusting a disbursal - The server encountered an internal error () that pr
 list of loan transactions not available (except in summary presume repayments has repayments and waivers and adjusts)
 
 ---------------------------------------------------------
-Additional Fields
-put right message for parameter not recognized etc.(plus tht 9 other jpwwrongmsg items)
-
 should be able to get clients by branch as well (but not for now)
 also get loans of different status's by branch etc (but not for now)
 

mifosng-provider/src/main/java/org/mifosng/platform/ReadExtraDataAndReportingServiceImpl.java

@@ -48,8 +48,7 @@ public class ReadExtraDataAndReportingServiceImpl implements
 			db_connection = null;
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(), "DataSource: "
+					e.getMessage(), "DataSource: " + dataSource);
-							+ dataSource);
 		}
 	}
 
@@ -82,8 +81,7 @@ public class ReadExtraDataAndReportingServiceImpl implements
 					// out.close();
 				} catch (Exception e) {
 					throw new PlatformDataIntegrityException(
-							"error.msg.exception.error", "JPWWRONGMSG - "
+							"error.msg.exception.error", e.getMessage());
-									+ e.getMessage());
 				}
 			}
 		};
@@ -140,12 +138,6 @@ public class ReadExtraDataAndReportingServiceImpl implements
 	public GenericResultset retrieveGenericResultset(final String name,
 			final String type, final Map<String, String> queryParams) {
 
-		if (name == null) {
-			throw new PlatformDataIntegrityException(
-					"error.msg.report.name.null",
-					"JPWWRONGMSG - Report Name is null.");
-		}
-
 		long startTime = System.currentTimeMillis();
 		logger.info("STARTING REPORT: " + name + "   Type: " + type);
 
@@ -225,7 +217,7 @@ public class ReadExtraDataAndReportingServiceImpl implements
 
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(), "Sql: " + sql);
+					e.getMessage(), "Sql: " + sql);
 		}
 		return result;
 
@@ -321,7 +313,7 @@ public class ReadExtraDataAndReportingServiceImpl implements
 			db_connection = null;
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(), "Input Sql: " + inputSql);
+					e.getMessage(), "Input Sql: " + inputSql);
 		}
 
 		return sql;
@@ -359,8 +351,7 @@ public class ReadExtraDataAndReportingServiceImpl implements
 			db_connection = null;
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(),
+					e.getMessage(), "Additional Fields Type: " + type);
-					"Additional Fields Type: " + type);
 		}
 
 		return additionalFieldsSets;
@@ -474,9 +465,8 @@ public class ReadExtraDataAndReportingServiceImpl implements
 
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(),
+					e.getMessage(), "Additional Fields Type: " + type
-					"Additional Fields Type: " + type + "   Set: " + set
+							+ "   Set: " + set + "   Id: " + id);
-							+ "   Id: " + id);
 		}
 		return result;
 
@@ -506,15 +496,6 @@ public class ReadExtraDataAndReportingServiceImpl implements
 		logger.info("updateExtraData - type: " + type + "    set: " + set
 				+ "  id: " + id);
 
-		logger.info("startjpw: ");
-		Set<String> keys = queryParams.keySet();
-		String pValue = "";
-		for (String key : keys) {
-			pValue = queryParams.get(key);
-			logger.info("jpw: " + key + " - " + pValue);
-		}
-		logger.info("endjpw: ");
-
 		checkResourceTypeThere(type, set);
 		String fullDatasetName = getFullDatasetName(type, set);
 		String transType = getTransType(type, fullDatasetName, id);
@@ -533,9 +514,8 @@ public class ReadExtraDataAndReportingServiceImpl implements
 			db_connection = null;
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(),
+					e.getMessage(), "Additional Fields Type: " + type
-					"Additional Fields Type: " + type + "   Set: " + set
+							+ "   Set: " + set + "   Id: " + id);
-							+ "   Id: " + id);
 		}
 
 	}
@@ -563,9 +543,8 @@ public class ReadExtraDataAndReportingServiceImpl implements
 
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(),
+					e.getMessage(), "Additional Fields Type: " + type
-					"Additional Fields Type: " + type + "   Set: " + set
+							+ "   Set: " + set + "   Sql: " + sql);
-							+ "   Sql: " + sql);
 		}
 
 	}
@@ -601,9 +580,9 @@ public class ReadExtraDataAndReportingServiceImpl implements
 			db_connection = null;
 		} catch (SQLException e) {
 			throw new PlatformDataIntegrityException("error.msg.sql.error",
-					"JPWWRONGMSG - " + e.getMessage(),
+					e.getMessage(), "Additional Fields Type: " + type
-					"Additional Fields Type: " + type + "   Full Set Name: "
+							+ "   Full Set Name: " + fullDatasetName
-							+ fullDatasetName + "   Sql: " + sql);
+							+ "   Sql: " + sql);
 		}
 
 		return transType;