CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

FINERACT-2421: Simplify InputStream to String conversion using Java 11+ API

Browse Source
This commit is contained in:
airajena
2025-12-29 10:36:05 +01:00
committed by Arnold Gálovics
parent b4fa48263b
commit 8134d7f6a0
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/template/service/TemplateMergeService.java
+3 -13
View File
@@ -22,10 +22,8 @@ import com.fasterxml.jackson.databind.ObjectMapper;
import com.github.mustachejava.DefaultMustacheFactory; import com.github.mustachejava.DefaultMustacheFactory;
import com.github.mustachejava.Mustache; import com.github.mustachejava.Mustache;
import com.github.mustachejava.MustacheFactory; import com.github.mustachejava.MustacheFactory;
import java.io.BufferedReader;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.StringReader; import java.io.StringReader;
import java.io.StringWriter; import java.io.StringWriter;
import java.net.Authenticator; import java.net.Authenticator;
@@ -55,21 +53,13 @@ public class TemplateMergeService {
private final FineractProperties fineractProperties; private final FineractProperties fineractProperties;
// TODO Replace this with appropriate alternative available in Guava
private static String getStringFromInputStream(final InputStream is) { private static String getStringFromInputStream(final InputStream is) {
final StringBuilder sb = new StringBuilder(); try {
return new String(is.readAllBytes(), StandardCharsets.UTF_8);
String line;
try (BufferedReader br = new BufferedReader(new InputStreamReader(is, StandardCharsets.UTF_8))) {
while ((line = br.readLine()) != null) {
sb.append(line);
}
} catch (final IOException e) { } catch (final IOException e) {
log.error("getStringFromInputStream() failed", e); log.error("getStringFromInputStream() failed", e);
return "";
} }
return sb.toString();
} }
public String compile(final Template template, final Map<String, Object> scopes) { public String compile(final Template template, final Map<String, Object> scopes) {