CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

FINERACT-757: Use of sqlEncodeString function isn't needed as parameters are passed as an array of Objects and SqlInjection validation is done by Spring JdbcTemplate.

Browse Source
This commit is contained in:
Angel Cajas
2019-05-27 23:00:41 -06:00
parent 7bf648aa96
commit 82568d93bf
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java
+4 -4
View File
@@ -251,7 +251,7 @@ public class ClientReadPlatformServiceImpl implements ClientReadPlatformService
} }
if (externalId != null) { if (externalId != null) {
paramList.add(ApiParameterHelper.sqlEncodeString(externalId)); paramList.add(externalId);
extraCriteria += " and c.external_id like ? " ; extraCriteria += " and c.external_id like ? " ;
} }
@@ -262,17 +262,17 @@ public class ClientReadPlatformServiceImpl implements ClientReadPlatformService
} }
if (firstname != null) { if (firstname != null) {
paramList.add(ApiParameterHelper.sqlEncodeString(firstname)); paramList.add(firstname);
extraCriteria += " and c.firstname like ? " ; extraCriteria += " and c.firstname like ? " ;
} }
if (lastname != null) { if (lastname != null) {
paramList.add(ApiParameterHelper.sqlEncodeString(lastname)); paramList.add(lastname);
extraCriteria += " and c.lastname like ? "; extraCriteria += " and c.lastname like ? ";
} }
if (searchParameters.isScopedByOfficeHierarchy()) { if (searchParameters.isScopedByOfficeHierarchy()) {
paramList.add(ApiParameterHelper.sqlEncodeString(searchParameters.getHierarchy() + "%")); paramList.add(searchParameters.getHierarchy() + "%");
extraCriteria += " and o.hierarchy like ? "; extraCriteria += " and o.hierarchy like ? ";
} }