[FINERACT-1884] fix last loan transaction

2023-02-10 12:13:47 +01:00
parent 8bd96f55e0
commit 84649193fb
2 changed files with 43 additions and 6 deletions
@@ -4974,12 +4974,11 @@ public class Loan extends AbstractAuditableWithUTCDateTimeCustom {
    }

    public LoanTransaction getLastRepaymentTransaction() {
-        for (final LoanTransaction loanTransaction : this.loanTransactions) {
-            if (!loanTransaction.isReversed() && loanTransaction.isRepaymentType()) {
-                return loanTransaction;
-            }
-        }
-        return null;
+        return loanTransactions.stream() //
+                .filter(loanTransaction -> !loanTransaction.isReversed()) //
+                .filter(LoanTransaction::isRepaymentType) //
+                .reduce((first, second) -> second) //
+                .orElse(null);
    }

    public LocalDate getLastUserTransactionForChargeCalc() {