diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml index 7cda31692..606c389e2 100644 --- a/fineract-provider/config/checkstyle/checkstyle.xml +++ b/fineract-provider/config/checkstyle/checkstyle.xml @@ -104,6 +104,10 @@ + + + + @@ -144,10 +148,6 @@ - - - - diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java index 23357ea2e..7b568da74 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java @@ -30,6 +30,7 @@ import org.apache.fineract.infrastructure.campaigns.sms.constants.SmsCampaignEnu import org.apache.fineract.infrastructure.campaigns.sms.constants.SmsCampaignTriggerType; import org.apache.fineract.infrastructure.campaigns.sms.data.SmsProviderData; import org.apache.fineract.infrastructure.core.data.EnumOptionData; +import org.apache.fineract.infrastructure.core.exception.PlatformDataIntegrityException; import org.apache.fineract.portfolio.calendar.domain.CalendarWeekDaysType; import org.apache.fineract.portfolio.calendar.service.CalendarEnumerations; import org.apache.fineract.portfolio.common.domain.PeriodFrequencyType; @@ -70,19 +71,18 @@ public class SmsCampaignDropdownReadPlatformServiceImpl implements SmsCampaignDr public Collection retrieveSmsProviders() { Collection smsProviderOptions = new ArrayList<>(); String hostName = "" ; - try { Map hostConfig = this.smsConfigUtils.getMessageGateWayRequestURI("smsbridges", null); URI uri = (URI) hostConfig.get("uri"); hostName = uri.getHost() ; HttpEntity entity = (HttpEntity) hostConfig.get("entity"); ResponseEntity> responseOne = restTemplate.exchange(uri, HttpMethod.GET, entity, new ParameterizedTypeReference>() {}); + if (!responseOne.getStatusCode().equals(HttpStatus.OK)) { + throw new PlatformDataIntegrityException("error.msg.mobile.service.provider.not.available", + "Mobile service provider not available."); + } smsProviderOptions = responseOne.getBody(); - if (!responseOne.getStatusCode().equals(HttpStatus.OK)) { - } - } catch (Exception e) { - } - return smsProviderOptions; + return smsProviderOptions; } @Override diff --git a/fineract-provider/src/main/java/org/apache/fineract/mix/service/XBRLBuilder.java b/fineract-provider/src/main/java/org/apache/fineract/mix/service/XBRLBuilder.java index 40efd1d49..0843a876b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/mix/service/XBRLBuilder.java +++ b/fineract-provider/src/main/java/org/apache/fineract/mix/service/XBRLBuilder.java @@ -114,11 +114,6 @@ public class XBRLBuilder { if (dims.length == 2) { context = new ContextData(dims[0], dims[1], taxonomy.getType()); - if (this.contextMap.containsKey(context)) { - - } else { - - } } } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformServiceImpl.java index f76c4b13b..4803cf8ed 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformServiceImpl.java @@ -245,9 +245,10 @@ public class StaffReadPlatformServiceImpl implements StaffReadPlatformService { extraCriteria.append(" and s.is_active = 1 "); } else if (status.equalsIgnoreCase("inActive")) { extraCriteria.append(" and s.is_active = 0 "); - } else if (status.equalsIgnoreCase("all")) { - } else { + } else{ + if (!status.equalsIgnoreCase("all")) { throw new UnrecognizedQueryParamException("status", status, new Object[]{"all", "active", "inactive"}); + } } } //adding the Authorization criteria so that a user cannot see an employee who does not belong to his office or a sub office for his office. diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformServiceImpl.java index 583d90061..d4f01273b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformServiceImpl.java @@ -261,8 +261,10 @@ public class TellerManagementReadPlatformServiceImpl implements TellerManagement extraCriteria.append(" and status = 300 "); } else if (status.equalsIgnoreCase("inActive")) { extraCriteria.append(" and status = 0 "); - } else if (status.equalsIgnoreCase("all")) {} else { + } else { + if (!status.equalsIgnoreCase("all")){ throw new UnrecognizedQueryParamException("status", status, new Object[] { "all", "active", "inactive" }); + } } if (StringUtils.isNotBlank(extraCriteria.toString())) { diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java index 8905ab6fb..96b4ab42e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java @@ -197,8 +197,6 @@ public class AccountTransfersWritePlatformServiceImpl implements AccountTransfer this.accountTransferDetailRepository.saveAndFlush(accountTransferDetails); transferDetailId = accountTransferDetails.getId(); - } else { - } final CommandProcessingResultBuilder builder = new CommandProcessingResultBuilder().withEntityId(transferDetailId);