CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

FINERACT-1724: Added nullcheck for batch API for enhanced reliability

Browse Source
This commit is contained in:
Arnold Galovics
2023-04-05 16:44:44 +02:00
committed by taskain7
parent 3184b16372
commit 8a51abda78
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/batch/service/BatchApiServiceImpl.java
+2 -2
View File
@@ -146,7 +146,7 @@ public class BatchApiServiceImpl implements BatchApiService {
// 1. run current node // 1. run current node
BatchResponse response = executeRequest(request, uriInfo); BatchResponse response = executeRequest(request, uriInfo);
responseList.add(response); responseList.add(response);
if (response.getStatusCode() == 200) { if (response.getStatusCode() != null && response.getStatusCode() == 200) {
requestNode.getChildRequests().forEach(childNode -> { requestNode.getChildRequests().forEach(childNode -> {
BatchRequest resolvedChildRequest; BatchRequest resolvedChildRequest;
try { try {
@@ -306,7 +306,7 @@ public class BatchApiServiceImpl implements BatchApiService {
BatchResponse errResponse = new BatchResponse(); BatchResponse errResponse = new BatchResponse();
for (BatchResponse res : responseList) { for (BatchResponse res : responseList) {
if (!res.getStatusCode().equals(200)) { if (res.getStatusCode() == null || !res.getStatusCode().equals(200)) {
errResponse.setBody("Transaction is being rolled back. First erroneous request: \n" + new Gson().toJson(res)); errResponse.setBody("Transaction is being rolled back. First erroneous request: \n" + new Gson().toJson(res));
errResponse.setRequestId(res.getRequestId()); errResponse.setRequestId(res.getRequestId());
if (statusCode == -1) { if (statusCode == -1) {