From 8aab991194bf5eb0acc62a70fa09d59cf8db7cee Mon Sep 17 00:00:00 2001
From: thesmallstar <manthan.surkar@gmail.com>
Date: Mon, 15 Jun 2020 06:23:30 +0530
Subject: [PATCH] FINERACT-821 Added and Enforced EmptyLineSeparator Checkstyle

---
 fineract-provider/config/checkstyle/checkstyle.xml    | 11 ++++++-----
 .../portfolio/calendar/service/CalendarUtils.java     |  1 +
 .../loanaccount/domain/LoanTopupDetails.java          |  2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml
index 11e79cddb..bd68d88a7 100644
--- a/fineract-provider/config/checkstyle/checkstyle.xml
+++ b/fineract-provider/config/checkstyle/checkstyle.xml
@@ -93,6 +93,11 @@
             <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
             <message key="name.invalidPattern"
              value="Method type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="EmptyLineSeparator">
+            <property name="allowNoEmptyLineBetweenFields" value="true"/>
+            <!-- No PACKAGE_DEF token, as we like our license header to be glue to "package" statement, to save 1 line screen space -->
+            <property name="tokens" value="IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
         </module>
           <module name="PackageName">
             <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]*)*$"/>
@@ -177,11 +182,7 @@
 
         <module name="ModifierOrder"/>
         <module name="RedundantModifier"/>
-        <module name="EmptyLineSeparator">
-            <property name="allowNoEmptyLineBetweenFields" value="true"/>
-            < ! - - No PACKAGE_DEF token, as we like our license header to be glue to "package" statement, to save 1 line screen space - - >
-            <property name="tokens" value="IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
-        </module>
+
         <module name="SeparatorWrap">
             <property name="tokens" value="DOT"/>
             <property name="option" value="nl"/>
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
index 42820e587..605b49747 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
@@ -57,6 +57,7 @@ import org.slf4j.LoggerFactory;
 public class CalendarUtils {
 
     private final static Logger LOG = LoggerFactory.getLogger(CalendarUtils.class);
+
     static {
         System.setProperty("net.fortuna.ical4j.timezone.date.floating", "true");
     }
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java
index d3553df47..36f05c5cb 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java
@@ -43,7 +43,7 @@ public class LoanTopupDetails extends AbstractPersistableCustom {
     @Column(name = "topup_amount", nullable = true)
     private BigDecimal topupAmount;
 
-    protected LoanTopupDetails() {};
+    protected LoanTopupDetails() {}
 
     public LoanTopupDetails(final Loan loan, final Long loanIdToClose) {
         this.loan = loan;