CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity

FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5)

Browse Source
This commit is contained in:
Aman-Mittal
2026-01-23 12:15:46 +01:00
committed by Adam Saghy
parent 6f1d96fc2c
commit 8b24325f84
18 changed files with 127 additions and 291 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-client-feign/src/main/java/org/apache/fineract/client/feign/FineractErrorDecoder.java
+1 -1
View File
@@ -79,7 +79,7 @@ public class FineractErrorDecoder implements ErrorDecoder {
private String extractValidationErrors(JsonNode rootNode) {
JsonNode errorsNode = rootNode.get("errors");
if (errorsNode != null && errorsNode.isArray() && errorsNode.size() > 0) {
if (errorsNode != null && errorsNode.isArray() && !errorsNode.isEmpty()) {
StringBuilder errors = new StringBuilder("Validation errors: ");
for (JsonNode error : errorsNode) {
String parameterName = extractField(error, "parameterName");
fineract-client-feign/src/main/java/org/apache/fineract/client/feign/services/ImagesApi.java
+8 -16
View File
@@ -77,21 +77,13 @@ public interface ImagesApi {
}
String ext = fileName.substring(dotPos + 1).toLowerCase();
switch (ext) {
case "jpg":
case "jpeg":
return "image/jpeg";
case "png":
return "image/png";
case "gif":
return "image/gif";
case "tif":
case "tiff":
return "image/tiff";
case "pdf":
return "application/pdf";
default:
return "application/octet-stream";
}
return switch (ext) {
case "jpg", "jpeg" -> "image/jpeg";
case "png" -> "image/png";
case "gif" -> "image/gif";
case "tif", "tiff" -> "image/tiff";
case "pdf" -> "application/pdf";
default -> "application/octet-stream";
};
}
}
fineract-client-feign/src/main/java/org/apache/fineract/client/feign/support/ApiResponseDecoder.java
+2 -4
View File
@@ -60,8 +60,7 @@ public final class ApiResponseDecoder implements Decoder {
}
private boolean isApiResponseType(Type type) {
if (type instanceof ParameterizedType) {
ParameterizedType paramType = (ParameterizedType) type;
if (type instanceof ParameterizedType paramType) {
Type rawType = paramType.getRawType();
return rawType == ApiResponse.class;
}
@@ -69,8 +68,7 @@ public final class ApiResponseDecoder implements Decoder {
}
private Type getApiResponseInnerType(Type type) {
if (type instanceof ParameterizedType) {
ParameterizedType paramType = (ParameterizedType) type;
if (type instanceof ParameterizedType paramType) {
Type[] typeArgs = paramType.getActualTypeArguments();
if (typeArgs.length > 0) {
return typeArgs[0];