FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5)

fineract-loan/src/main/java/org/apache/fineract/portfolio/collateralmanagement/api/CollateralManagementJsonInputParams.java

@@ -18,6 +18,9 @@
  */
 package org.apache.fineract.portfolio.collateralmanagement.api;
 
+import lombok.Getter;
+
+@Getter
 public enum CollateralManagementJsonInputParams {
 
     NAME("name"), //
@@ -39,11 +42,7 @@ public enum CollateralManagementJsonInputParams {
 
     @Override
     public String toString() {
-        return name().replaceAll("_", " ");
-    }
-
-    public String getValue() {
-        return this.value;
+        return name().replace("_", " ");
     }
 
 }

fineract-loan/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java

@@ -141,12 +141,10 @@ public class DelinquencyReadPlatformServiceImpl implements DelinquencyReadPlatfo
 
             // If the Loan is not Active yet or is cancelled (rejected or withdrawn), return template data
             if (loan.isSubmittedAndPendingApproval() || loan.isApproved() || loan.isCancelled()) {
-                if (loan.getLoanProduct() != null && !loan.getLoanProduct().isAllowApprovedDisbursedAmountsOverApplied()) {
-                    return collectionData;
-                } else {
+                if (loan.getLoanProduct() == null || loan.getLoanProduct().isAllowApprovedDisbursedAmountsOverApplied()) {
                     collectionData.setAvailableDisbursementAmountWithOverApplied(calculateAvailableDisbursementAmountWithOverApplied(loan));
-                    return collectionData;
                 }
+                return collectionData;
             }
 
             final List<LoanDelinquencyAction> savedDelinquencyList = retrieveLoanDelinquencyActions(loanId);