From 8c5606ea8e9175cbffa67bf3df08625a7c2cb0cb Mon Sep 17 00:00:00 2001 From: Hossam Hatem <7ossam7atem1@gmail.com> Date: Tue, 25 Feb 2025 23:25:31 +0200 Subject: [PATCH] FINERACT-2081: fix sonar issues in EntityTables enum --- .../infrastructure/dataqueries/data/EntityTables.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java b/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java index 0a924cf19..3062ebdf2 100644 --- a/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java +++ b/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java @@ -49,11 +49,11 @@ public enum EntityTables { SHARE_PRODUCT("m_share_product", "share_product_id", "id"), // ; - public static final EntityTables[] VALUES = values(); + static final EntityTables[] ENTITY_VALUES = values(); - private static final List ENTITY_NAMES = Arrays.stream(VALUES).map(EntityTables::getName).toList(); + private static final List ENTITY_NAMES = Arrays.stream(ENTITY_VALUES).map(EntityTables::getName).toList(); - private static final Map BY_ENTITY_NAME = Arrays.stream(VALUES) + private static final Map BY_ENTITY_NAME = Arrays.stream(ENTITY_VALUES) .collect(Collectors.toMap(EntityTables::getName, e -> e)); @NotNull @@ -106,7 +106,7 @@ public enum EntityTables { } public boolean hasCheck() { - return checkStatuses != null && !checkStatuses.isEmpty(); + return !checkStatuses.isEmpty(); } public static List getEntityNames() { @@ -135,6 +135,6 @@ public enum EntityTables { @NotNull public static List getFiltered(Predicate filter) { - return Arrays.stream(VALUES).filter(filter).toList(); + return Arrays.stream(ENTITY_VALUES).filter(filter).toList(); } }