CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

[FINERACT-1842] Wrong entityId is returned upon disbursing a loan

Browse Source
This commit is contained in:
taskain7
2023-01-10 00:56:50 -08:00
parent dafd4c3436
commit 8e597e46f7
3 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
+8 -7
View File
@@ -506,23 +506,24 @@ public class LoanWritePlatformServiceJpaRepositoryImpl implements LoanWritePlatf
businessEventNotifierService.notifyPostBusinessEvent(new LoanDisbursalBusinessEvent(loan));
Long entityId = loan.getId();
ExternalId externalId = loan.getExternalId();
Long disbursalTransactionId = null;
ExternalId disbursalTransactionExternalId = null;
// During a disbursement, the entityId should be the disbursement transaction id
if (!isAccountTransfer) {
// If accounting is not periodic accrual, the last transaction might be the accrual not the disbursement
LoanTransaction disbursalTransaction = Lists.reverse(loan.getLoanTransactions()).stream()
.filter(e -> LoanTransactionType.DISBURSEMENT.equals(e.getTypeOf())).findFirst().orElseThrow();
entityId = disbursalTransaction.getId();
externalId = disbursalTransaction.getExternalId();
disbursalTransactionId = disbursalTransaction.getId();
disbursalTransactionExternalId = disbursalTransaction.getExternalId();
businessEventNotifierService.notifyPostBusinessEvent(new LoanDisbursalTransactionBusinessEvent(disbursalTransaction));
}
return new CommandProcessingResultBuilder() //
.withCommandId(command.commandId()) //
.withEntityId(entityId) //
.withEntityExternalId(externalId) //
.withEntityId(loan.getId()) //
.withEntityExternalId(loan.getExternalId()) //
.withSubEntityId(disbursalTransactionId) //
.withSubEntityExternalId(disbursalTransactionExternalId) //
.withOfficeId(loan.getOfficeId()) //
.withClientId(loan.getClientId()) //
.withGroupId(loan.getGroupId()) //