fix(shares,savings): remove product-config voucher auto-resolve, fix charge/currency edit bugs, gate withdrawal on settlement

- ShareAdvanceCollectionApiResource: drop the hardcoded/auto-resolved Share Suspense GL lookup for
  by-voucher search; GL account and voucher are now both required, manually-selected inputs. apply()
  now accepts a separately-verified entry-fee receipt (chargeCollectionId) so a fee collected into a
  different GL than the share value is never swept into the Sundry leg or double-posted to income.
- ClerkShareWithdrawalRequestApiResource: hard-block approval when collection_applied is false, so
  shares nobody has actually paid for can't be redeemed off an Active-but-unsettled account.
- ProductPendingEditFieldMapper / ShareProductDataSerializer: fix maker-checker edits on share
  products silently dropping charges (chargesSelected vs charges field-name mismatch) and NPEing on
  approval when the replay JSON carries no currencyCode.
- SavingsAccount: initialize the clearing-hold field to zero so new savings submissions don't violate
  the NOT NULL constraint on total_savings_amount_on_hold_clearing.
- CashReportApiResource: fix voucher number resolution for GL-type ledger entries.
- application.properties: revert local tenant DB password default.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/ProductPendingEditFieldMapper.java

@@ -547,10 +547,21 @@ public final class ProductPendingEditFieldMapper {
 
     /** Returns null if "charges" wasn't present at all, else the (possibly empty) list of charge ids. */
     public static List<Long> extractChargeIds(final JsonCommand command) {
-        if (!command.hasParameter("charges")) {
+        return extractChargeIds(command, "charges");
+    }
+
+    /**
+     * Same as {@link #extractChargeIds(JsonCommand)}, but reads a caller-chosen JSON field instead of the
+     * "charges" every other product type uses. Share products alone submit this array under
+     * {@code chargesSelected} (see {@code ShareProductApiConstants.charges_paramname}) -- calling the
+     * default overload for a share product silently finds nothing, since {@code hasParameter("charges")}
+     * is always false for that payload.
+     */
+    public static List<Long> extractChargeIds(final JsonCommand command, final String paramName) {
+        if (!command.hasParameter(paramName)) {
             return null;
         }
-        final com.google.gson.JsonElement raw = command.parsedJson().getAsJsonObject().get("charges");
+        final com.google.gson.JsonElement raw = command.parsedJson().getAsJsonObject().get(paramName);
         final List<Long> ids = new java.util.ArrayList<>();
         if (raw != null && raw.isJsonArray()) {
             for (final com.google.gson.JsonElement el : raw.getAsJsonArray()) {
@@ -563,13 +574,23 @@ public final class ProductPendingEditFieldMapper {
     }
 
     public static void writeChargesToJson(final JsonObject root, final List<ProductPendingEditCharge> charges) {
+        writeChargesToJson(root, charges, "charges");
+    }
+
+    /**
+     * Same as {@link #writeChargesToJson(JsonObject, List)}, but writes under a caller-chosen field name.
+     * The replayed JSON built here is fed straight back into the same product-update parser the original
+     * submission went through, so the field name must match whatever that product type's own submit
+     * payload used -- {@code chargesSelected} for share products, {@code charges} for every other type.
+     */
+    public static void writeChargesToJson(final JsonObject root, final List<ProductPendingEditCharge> charges, final String paramName) {
         final JsonArray array = new JsonArray();
         for (final ProductPendingEditCharge charge : charges) {
             final JsonObject entry = new JsonObject();
             entry.addProperty("id", charge.getChargeId());
             array.add(entry);
         }
-        root.add("charges", array);
+        root.add(paramName, array);
     }
 
     // ---- accountFacilityLimits (1:many, satellite table) -------------------------------------------

fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java

@@ -355,7 +355,7 @@ public class SavingsAccount extends AbstractAuditableWithUTCDateTimeCustom<Long>
      *  {@link #savingsOnHoldAmount}'s staff-placed lien, so the two read as genuinely different figures
      *  rather than one bucket doing double duty. */
     @Column(name = "total_savings_amount_on_hold_clearing", scale = 6, precision = 19, nullable = true)
-    private BigDecimal savingsOnHoldAmountClearing;
+    private BigDecimal savingsOnHoldAmountClearing = BigDecimal.ZERO;
 
     @OneToMany(cascade = CascadeType.ALL, mappedBy = "account", orphanRemoval = true, fetch = FetchType.LAZY)
     protected List<InteropIdentifier> identifiers = new ArrayList<>();