fix minor issues in Mifosx-437

2013-10-18 13:19:17 +02:00
parent 7d9e4ca9c1
commit 961e581f63
2 changed files with 25 additions and 2 deletions
@@ -123,8 +123,7 @@ public class Charge extends AbstractPersistable<Long> {
        this.penalty = penalty;
        this.active = active;
        this.chargePaymentMode = paymentMode == null ? null : paymentMode.getValue();
-        this.minCap = minCap;
-        this.maxCap = maxCap;
+

        final List<ApiParameterError> dataValidationErrors = new ArrayList<ApiParameterError>();
        final DataValidatorBuilder baseDataValidator = new DataValidatorBuilder(dataValidationErrors).resource("charges");
@@ -162,6 +161,10 @@ public class Charge extends AbstractPersistable<Long> {
                        .failWithCodeNoParameterAddedToErrorCode("not.allowed.charge.time.for.loan");
            }
        }
+        if(isPercentageOfAmount()){
+            this.minCap = minCap;
+            this.maxCap = maxCap;
+        }

        if (!dataValidationErrors.isEmpty()) { throw new PlatformApiDataValidationException(dataValidationErrors); }
    }