CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 47 Packages Projects Releases Wiki Activity

FINERACT-2181: Refactor constants to follow naming convention

Browse Source
This commit is contained in:
a7med3del1973
2025-04-17 15:01:17 +02:00
committed by Adam Saghy
parent 9f4f1d4f17
commit 98894d1f21
4 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/api/FinancialActivityAccountsApiResource.java
+3 -3
View File
@@ -79,7 +79,7 @@ public class FinancialActivityAccountsApiResource {
@Consumes({ MediaType.APPLICATION_JSON }) @Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON }) @Produces({ MediaType.APPLICATION_JSON })
public FinancialActivityAccountData retrieveTemplate() { public FinancialActivityAccountData retrieveTemplate() {
context.authenticatedUser().validateHasReadPermission(FinancialActivityAccountsConstants.resourceNameForPermission); context.authenticatedUser().validateHasReadPermission(FinancialActivityAccountsConstants.RESOURCE_NAME_FOR_PERMISSION);
return financialActivityAccountReadPlatformService.getFinancialActivityAccountTemplate(); return financialActivityAccountReadPlatformService.getFinancialActivityAccountTemplate();
} }
@@ -91,7 +91,7 @@ public class FinancialActivityAccountsApiResource {
financialactivityaccounts""") financialactivityaccounts""")
@ApiResponse(responseCode = "200", description = "OK", content = @Content(array = @ArraySchema(schema = @Schema(implementation = FinancialActivityAccountsApiResourceSwagger.GetFinancialActivityAccountsResponse.class)))) @ApiResponse(responseCode = "200", description = "OK", content = @Content(array = @ArraySchema(schema = @Schema(implementation = FinancialActivityAccountsApiResourceSwagger.GetFinancialActivityAccountsResponse.class))))
public List<FinancialActivityAccountData> retrieveAll() { public List<FinancialActivityAccountData> retrieveAll() {
context.authenticatedUser().validateHasReadPermission(FinancialActivityAccountsConstants.resourceNameForPermission); context.authenticatedUser().validateHasReadPermission(FinancialActivityAccountsConstants.RESOURCE_NAME_FOR_PERMISSION);
return financialActivityAccountReadPlatformService.retrieveAll(); return financialActivityAccountReadPlatformService.retrieveAll();
} }
@@ -105,7 +105,7 @@ public class FinancialActivityAccountsApiResource {
@ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = FinancialActivityAccountsApiResourceSwagger.GetFinancialActivityAccountsResponse.class))) @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = FinancialActivityAccountsApiResourceSwagger.GetFinancialActivityAccountsResponse.class)))
public FinancialActivityAccountData retreive(@PathParam("mappingId") @Parameter(description = "mappingId") final Long mappingId, public FinancialActivityAccountData retreive(@PathParam("mappingId") @Parameter(description = "mappingId") final Long mappingId,
@Context final UriInfo uriInfo) { @Context final UriInfo uriInfo) {
context.authenticatedUser().validateHasReadPermission(FinancialActivityAccountsConstants.resourceNameForPermission); context.authenticatedUser().validateHasReadPermission(FinancialActivityAccountsConstants.RESOURCE_NAME_FOR_PERMISSION);
final ApiRequestJsonSerializationSettings settings = apiRequestParameterHelper.process(uriInfo.getQueryParameters()); final ApiRequestJsonSerializationSettings settings = apiRequestParameterHelper.process(uriInfo.getQueryParameters());
FinancialActivityAccountData financialActivityAccountData = financialActivityAccountReadPlatformService.retrieve(mappingId); FinancialActivityAccountData financialActivityAccountData = financialActivityAccountReadPlatformService.retrieve(mappingId);
fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/api/FinancialActivityAccountsConstants.java
+8 -8
View File
@@ -28,12 +28,12 @@ public final class FinancialActivityAccountsConstants {
} }
private static final String idParamName = "id"; private static final String ID_PARAM_NAME = "id";
private static final String factivityDataParamName = "financialActivityData"; private static final String FINANCIAL_ACTIVITY_DATA_PARAM_NAME = "financialActivityData";
private static final String glAccountDataParamName = "glAccountData"; private static final String GL_ACCOUNT_DATA_PARAM_NAME = "glAccountData";
private static final String glAccountOptionsParamName = "glAccountOptions"; private static final String GL_ACCOUNT_OPTIONS_PARAM_NAME = "glAccountOptions";
private static final String financialActivityOptionsParamName = "financialActivityOptions"; private static final String FINANCIAL_ACTIVITY_OPTIONS_PARAM_NAME = "financialActivityOptions";
public static final String resourceNameForPermission = "FINANCIALACTIVITYACCOUNT"; public static final String RESOURCE_NAME_FOR_PERMISSION = "FINANCIALACTIVITYACCOUNT";
static final Set<String> RESPONSE_DATA_PARAMETERS = new HashSet<>(Arrays.asList(idParamName, factivityDataParamName, static final Set<String> RESPONSE_DATA_PARAMETERS = new HashSet<>(Arrays.asList(ID_PARAM_NAME, FINANCIAL_ACTIVITY_DATA_PARAM_NAME,
glAccountDataParamName, glAccountOptionsParamName, financialActivityOptionsParamName)); GL_ACCOUNT_DATA_PARAM_NAME, GL_ACCOUNT_OPTIONS_PARAM_NAME, FINANCIAL_ACTIVITY_OPTIONS_PARAM_NAME));
} }
fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/exception/DuplicateFinancialActivityAccountFoundException.java
+3 -3
View File
@@ -25,14 +25,14 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR
*/ */
public class DuplicateFinancialActivityAccountFoundException extends AbstractPlatformDomainRuleException { public class DuplicateFinancialActivityAccountFoundException extends AbstractPlatformDomainRuleException {
private static final String errorCode = "error.msg.financialActivityAccount.exists"; private static final String ERROR_CODE = "error.msg.financialActivityAccount.exists";
public DuplicateFinancialActivityAccountFoundException(final Integer financialActivityType) { public DuplicateFinancialActivityAccountFoundException(final Integer financialActivityType) {
super(errorCode, "Mapping for activity already exists " + financialActivityType, financialActivityType); super(ERROR_CODE, "Mapping for activity already exists " + financialActivityType, financialActivityType);
} }
public static String getErrorcode() { public static String getErrorcode() {
return errorCode; return ERROR_CODE;
} }
} }
fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/exception/FinancialActivityAccountInvalidException.java
+3 -3
View File
@@ -27,10 +27,10 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR
*/ */
public class FinancialActivityAccountInvalidException extends AbstractPlatformDomainRuleException { public class FinancialActivityAccountInvalidException extends AbstractPlatformDomainRuleException {
private static final String errorCode = "error.msg.financialActivityAccount.invalid"; private static final String ERROR_CODE = "error.msg.financialActivityAccount.invalid";
public FinancialActivityAccountInvalidException(final FinancialActivity financialActivity, final GLAccount glAccount) { public FinancialActivityAccountInvalidException(final FinancialActivity financialActivity, final GLAccount glAccount) {
super(errorCode, super(ERROR_CODE,
"Financial Activity '" + financialActivity.getCode() + "' with Id :" + financialActivity.getValue() "Financial Activity '" + financialActivity.getCode() + "' with Id :" + financialActivity.getValue()
+ "' can only be associated with a Ledger Account of Type " + financialActivity.getMappedGLAccountType().getCode() + "' can only be associated with a Ledger Account of Type " + financialActivity.getMappedGLAccountType().getCode()
+ " the provided Ledger Account '" + glAccount.getName() + "(" + glAccount.getGlCode() + " the provided Ledger Account '" + glAccount.getName() + "(" + glAccount.getGlCode()
@@ -40,6 +40,6 @@ public class FinancialActivityAccountInvalidException extends AbstractPlatformDo
} }
public static String getErrorcode() { public static String getErrorcode() {
return errorCode; return ERROR_CODE;
} }
} }