CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

FINERACT-2169: Account rules api refactor;

Browse Source
This commit is contained in:
viktorpavlenko
2025-03-14 18:10:19 +00:00
committed by Adam Saghy
parent 056b3edaad
commit 99f313e02c
5 changed files with 75 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/src/test/java/org/apache/fineract/integrationtests/accounting/AccountingRuleIntegrationTest.java
+2 -2
View File
@@ -27,7 +27,7 @@ import io.restassured.http.ContentType;
import io.restassured.specification.RequestSpecification;
import io.restassured.specification.ResponseSpecification;
import java.util.ArrayList;
import org.apache.fineract.client.models.GetAccountRulesResponse;
import org.apache.fineract.client.models.AccountingRuleData;
import org.apache.fineract.client.models.GetOfficesResponse;
import org.apache.fineract.client.models.PostAccountingRulesResponse;
import org.apache.fineract.integrationtests.common.OfficeHelper;
@@ -68,7 +68,7 @@ public class AccountingRuleIntegrationTest {
// when
final PostAccountingRulesResponse accountingRule = accountRuleHelper.createAccountRule(headOffice.getId(), accountToCredit,
accountToDebit);
final ArrayList<GetAccountRulesResponse> accountingRules = accountRuleHelper.getAccountingRules();
final ArrayList<AccountingRuleData> accountingRules = accountRuleHelper.getAccountingRules();
// then
assertNotNull(accountingRule);
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/AccountRuleHelper.java
+3 -3
View File
@@ -24,7 +24,7 @@ import io.restassured.specification.RequestSpecification;
import io.restassured.specification.ResponseSpecification;
import java.lang.reflect.Type;
import java.util.ArrayList;
import org.apache.fineract.client.models.GetAccountRulesResponse;
import org.apache.fineract.client.models.AccountingRuleData;
import org.apache.fineract.client.models.PostAccountingRulesResponse;
import org.apache.fineract.client.util.JSON;
import org.apache.fineract.integrationtests.common.Utils;
@@ -51,9 +51,9 @@ public class AccountRuleHelper {
// Example: org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
// org.apache.fineract.client.models.PostLoansLoanIdRequest)
@Deprecated(forRemoval = true)
public ArrayList<GetAccountRulesResponse> getAccountingRules() {
public ArrayList<AccountingRuleData> getAccountingRules() {
final String response = Utils.performServerGet(this.requestSpec, this.responseSpec, ACCOUNTINGRULES_URL);
Type accountRuleListType = new TypeToken<ArrayList<GetAccountRulesResponse>>() {}.getType();
Type accountRuleListType = new TypeToken<ArrayList<AccountingRuleData>>() {}.getType();
return GSON.fromJson(response, accountRuleListType);
}