Update client KYC and AML changes

fineract-savings/src/main/resources/db/changelog/tenant/module/savings/parts/parts/2028_update_saving_product_temp_table.xml

@@ -22,26 +22,47 @@
   xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
 
     <!-- 1. Rename table m_savings_product_temp to m_saving_product_temp -->
+    <!-- Guard also checks the destination does NOT already exist: on a fresh DB, changeset 2026
+         creates m_saving_product_temp directly, so both tables co-exist when this runs and the
+         rename would fail with "relation already exists". -->
     <changeSet author="fineract" id="2028-1">
         <preConditions onFail="MARK_RAN">
-            <tableExists tableName="m_savings_product_temp" />
+            <and>
+                <tableExists tableName="m_savings_product_temp" />
+                <not>
+                    <tableExists tableName="m_saving_product_temp" />
+                </not>
+            </and>
         </preConditions>
         <renameTable oldTableName="m_savings_product_temp" newTableName="m_saving_product_temp" />
     </changeSet>
 
     <!-- 2. Recreate unique constraint on pending_lock_key if needed -->
+    <!-- Only applies when 2028-1 actually performed the rename (old-path DB). On a fresh DB
+         2026 creates m_saving_product_temp with constraint spt_unq_pending_lock_key (different
+         name), so sp_temp_unq_pending_lock_key does not exist and this DROP would fail.
+         Guard on maker_id: if maker_id still exists the rename path ran; if not, skip. -->
     <changeSet author="fineract" id="2028-2">
         <preConditions onFail="MARK_RAN">
-            <tableExists tableName="m_saving_product_temp" />
+            <and>
+                <tableExists tableName="m_saving_product_temp" />
+                <columnExists tableName="m_saving_product_temp" columnName="maker_id" />
+            </and>
         </preConditions>
         <dropUniqueConstraint tableName="m_saving_product_temp" constraintName="sp_temp_unq_pending_lock_key" />
         <addUniqueConstraint tableName="m_saving_product_temp" columnNames="pending_lock_key" constraintName="sp_temp_unq_pending_lock_key" />
     </changeSet>
 
     <!-- 3. Rename columns to match exact user comparative list names -->
+    <!-- Only applies on old-path DBs where the rename ran. Guard on maker_id: present means
+         old columns still need renaming; absent means 2026 already created the table with
+         the final names and this changeset must be MARK_RAN'd. -->
     <changeSet author="fineract" id="2028-rename-core-columns">
         <preConditions onFail="MARK_RAN">
-            <tableExists tableName="m_saving_product_temp" />
+            <and>
+                <tableExists tableName="m_saving_product_temp" />
+                <columnExists tableName="m_saving_product_temp" columnName="maker_id" />
+            </and>
         </preConditions>
         
         <!-- Auditing -->
@@ -74,9 +95,16 @@
     </changeSet>
 
     <!-- 4. Add the completely new columns to m_saving_product_temp -->
+    <!-- On a fresh DB, 2026 creates m_saving_product_temp with all these columns already,
+         so adding them again fails with "column already exists". Guard skips cleanly. -->
     <changeSet author="fineract" id="2028-add-missing-columns">
         <preConditions onFail="MARK_RAN">
-            <tableExists tableName="m_saving_product_temp" />
+            <and>
+                <tableExists tableName="m_saving_product_temp" />
+                <not>
+                    <columnExists tableName="m_saving_product_temp" columnName="deposit_type_enum" />
+                </not>
+            </and>
         </preConditions>
         <addColumn tableName="m_saving_product_temp">
             <!-- If column does not already exist, it will be added. Guard is implicit via preCondition or Liquibase will skip. -->