diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml index a9153fd83..d9ac82316 100644 --- a/fineract-provider/config/checkstyle/checkstyle.xml +++ b/fineract-provider/config/checkstyle/checkstyle.xml @@ -190,6 +190,7 @@ + @@ -234,7 +235,7 @@ - + diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/provisioning/ProvisioningHelper.java b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/provisioning/ProvisioningHelper.java index ec7abd876..6e2747f17 100644 --- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/provisioning/ProvisioningHelper.java +++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/provisioning/ProvisioningHelper.java @@ -34,7 +34,7 @@ public final class ProvisioningHelper { } - public static final Map createProvisioingCriteriaJson(ArrayList loanProducts, ArrayList categories, Account liability, + public static Map createProvisioingCriteriaJson(ArrayList loanProducts, ArrayList categories, Account liability, Account expense) { final HashMap map = new HashMap<>(); map.put("loanProducts", addLoanProducts(loanProducts)); @@ -48,7 +48,7 @@ public final class ProvisioningHelper { return map; } - public static final String createProvisioningEntryJson() { + public static String createProvisioningEntryJson() { final HashMap map = new HashMap<>(); map.put("createjournalentries", Boolean.FALSE); map.put("locale", "en"); @@ -59,7 +59,7 @@ public final class ProvisioningHelper { return provisioningEntryCreateJson; } - public static final String createProvisioningEntryJsonWithJournalsEnabled() { + public static String createProvisioningEntryJsonWithJournalsEnabled() { final HashMap map = new HashMap<>(); map.put("createjournalentries", Boolean.TRUE); map.put("locale", "en"); diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/api/GLClosureJsonInputParams.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/api/GLClosureJsonInputParams.java index 2f12c63c6..89fad67d6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/api/GLClosureJsonInputParams.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/api/GLClosureJsonInputParams.java @@ -30,7 +30,7 @@ public enum GLClosureJsonInputParams { private final String value; - private GLClosureJsonInputParams(final String value) { + GLClosureJsonInputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/exception/GLClosureInvalidException.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/exception/GLClosureInvalidException.java index bd445aa8e..4d6c4dd2b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/exception/GLClosureInvalidException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/closure/exception/GLClosureInvalidException.java @@ -27,7 +27,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class GLClosureInvalidException extends AbstractPlatformDomainRuleException { /*** enum of reasons for invalid Accounting Closure **/ - public static enum GlClosureInvalidReason { + public enum GlClosureInvalidReason { FUTURE_DATE, ACCOUNTING_CLOSED; diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java index 05bf18150..113e7e20b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java @@ -34,14 +34,14 @@ public final class AccountingConstants { /*** * Accounting placeholders for cash based accounting for loan products ***/ - public static enum CashAccountsForLoan { + public enum CashAccountsForLoan { FUND_SOURCE(1), LOAN_PORTFOLIO(2), INTEREST_ON_LOANS(3), INCOME_FROM_FEES(4), INCOME_FROM_PENALTIES(5), LOSSES_WRITTEN_OFF( 6), TRANSFERS_SUSPENSE(10), OVERPAYMENT(11), INCOME_FROM_RECOVERY(12); private final Integer value; - private CashAccountsForLoan(final Integer value) { + CashAccountsForLoan(final Integer value) { this.value = value; } @@ -70,7 +70,7 @@ public final class AccountingConstants { /*** * Accounting placeholders for accrual based accounting for loan products ***/ - public static enum AccrualAccountsForLoan { + public enum AccrualAccountsForLoan { FUND_SOURCE(1), LOAN_PORTFOLIO(2), INTEREST_ON_LOANS(3), INCOME_FROM_FEES(4), INCOME_FROM_PENALTIES(5), LOSSES_WRITTEN_OFF( 6), INTEREST_RECEIVABLE( @@ -78,7 +78,7 @@ public final class AccountingConstants { private final Integer value; - private AccrualAccountsForLoan(final Integer value) { + AccrualAccountsForLoan(final Integer value) { this.value = value; } @@ -108,7 +108,7 @@ public final class AccountingConstants { /*** * Enum of all accounting related input parameter names used while creating/updating a loan product ***/ - public static enum LoanProductAccountingParams { + public enum LoanProductAccountingParams { FUND_SOURCE("fundSourceAccountId"), LOAN_PORTFOLIO("loanPortfolioAccountId"), INTEREST_ON_LOANS( "interestOnLoanAccountId"), INCOME_FROM_FEES("incomeFromFeeAccountId"), INCOME_FROM_PENALTIES( @@ -126,7 +126,7 @@ public final class AccountingConstants { private final String value; - private LoanProductAccountingParams(final String value) { + LoanProductAccountingParams(final String value) { this.value = value; } @@ -140,7 +140,7 @@ public final class AccountingConstants { } } - public static enum LoanProductAccountingDataParams { + public enum LoanProductAccountingDataParams { FUND_SOURCE("fundSourceAccount"), LOAN_PORTFOLIO("loanPortfolioAccount"), INTEREST_ON_LOANS( "interestOnLoanAccount"), INCOME_FROM_FEES("incomeFromFeeAccount"), INCOME_FROM_PENALTIES( @@ -153,7 +153,7 @@ public final class AccountingConstants { private final String value; - private LoanProductAccountingDataParams(final String value) { + LoanProductAccountingDataParams(final String value) { this.value = value; } @@ -170,14 +170,14 @@ public final class AccountingConstants { /*** * Accounting placeholders for cash based accounting for savings products ***/ - public static enum CashAccountsForSavings { + public enum CashAccountsForSavings { SAVINGS_REFERENCE(1), SAVINGS_CONTROL(2), INTEREST_ON_SAVINGS(3), INCOME_FROM_FEES(4), INCOME_FROM_PENALTIES(5), TRANSFERS_SUSPENSE( 10), OVERDRAFT_PORTFOLIO_CONTROL(11), INCOME_FROM_INTEREST(12), LOSSES_WRITTEN_OFF(13), ESCHEAT_LIABILITY(14); private final Integer value; - private CashAccountsForSavings(final Integer value) { + CashAccountsForSavings(final Integer value) { this.value = value; } @@ -206,7 +206,7 @@ public final class AccountingConstants { /*** * Enum of all accounting related input parameter names used while creating/updating a savings product ***/ - public static enum SavingProductAccountingParams { + public enum SavingProductAccountingParams { SAVINGS_REFERENCE("savingsReferenceAccountId"), SAVINGS_CONTROL("savingsControlAccountId"), INCOME_FROM_FEES( "incomeFromFeeAccountId"), INCOME_FROM_PENALTIES("incomeFromPenaltyAccountId"), INTEREST_ON_SAVINGS( @@ -224,7 +224,7 @@ public final class AccountingConstants { private final String value; - private SavingProductAccountingParams(final String value) { + SavingProductAccountingParams(final String value) { this.value = value; } @@ -238,7 +238,7 @@ public final class AccountingConstants { } } - public static enum SavingProductAccountingDataParams { + public enum SavingProductAccountingDataParams { SAVINGS_REFERENCE("savingsReferenceAccount"), SAVINGS_CONTROL("savingsControlAccount"), INCOME_FROM_FEES( "incomeFromFeeAccount"), INCOME_FROM_PENALTIES("incomeFromPenaltyAccount"), INTEREST_ON_SAVINGS( @@ -251,7 +251,7 @@ public final class AccountingConstants { private final String value; - private SavingProductAccountingDataParams(final String value) { + SavingProductAccountingDataParams(final String value) { this.value = value; } @@ -265,7 +265,7 @@ public final class AccountingConstants { } } - public static enum FinancialActivity { + public enum FinancialActivity { ASSET_TRANSFER(100, "assetTransfer", GLAccountType.ASSET), LIABILITY_TRANSFER(200, "liabilityTransfer", GLAccountType.LIABILITY), CASH_AT_MAINVAULT(101, "cashAtMainVault", GLAccountType.ASSET), CASH_AT_TELLER(102, @@ -286,7 +286,7 @@ public final class AccountingConstants { } } - private FinancialActivity(final Integer value, final String code, final GLAccountType mappedGLAccountType) { + FinancialActivity(final Integer value, final String code, final GLAccountType mappedGLAccountType) { this.value = value; this.code = code; this.mappedGLAccountType = mappedGLAccountType; @@ -343,13 +343,13 @@ public final class AccountingConstants { /*** * Accounting placeholders for cash based accounting for Share products ***/ - public static enum CashAccountsForShares { + public enum CashAccountsForShares { SHARES_REFERENCE(1), SHARES_SUSPENSE(2), INCOME_FROM_FEES(3), SHARES_EQUITY(4); private final Integer value; - private CashAccountsForShares(final Integer value) { + CashAccountsForShares(final Integer value) { this.value = value; } @@ -378,14 +378,14 @@ public final class AccountingConstants { /*** * Enum of all accounting related input parameter names used while creating/updating a savings product ***/ - public static enum SharesProductAccountingParams { + public enum SharesProductAccountingParams { SHARES_REFERENCE("shareReferenceId"), SHARES_SUSPENSE("shareSuspenseId"), INCOME_FROM_FEES("incomeFromFeeAccountId"), SHARES_EQUITY( "shareEquityId"); private final String value; - private SharesProductAccountingParams(final String value) { + SharesProductAccountingParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingDropdownReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingDropdownReadPlatformService.java index 988beb05e..b1da6b7d4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingDropdownReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingDropdownReadPlatformService.java @@ -25,22 +25,22 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData; public interface AccountingDropdownReadPlatformService { - public List retrieveGLAccountTypeOptions(); + List retrieveGLAccountTypeOptions(); - public List retrieveGLAccountUsageOptions(); + List retrieveGLAccountUsageOptions(); - public List retrieveJournalEntryTypeOptions(); + List retrieveJournalEntryTypeOptions(); - public List retrieveAccountingRuleTypeOptions(); + List retrieveAccountingRuleTypeOptions(); - public Map> retrieveAccountMappingOptionsForLoanProducts(); + Map> retrieveAccountMappingOptionsForLoanProducts(); - public Map> retrieveAccountMappingOptionsForSavingsProducts(); + Map> retrieveAccountMappingOptionsForSavingsProducts(); - public Map> retrieveAccountMappingOptionsForCharges(); + Map> retrieveAccountMappingOptionsForCharges(); - public Map> retrieveAccountMappingOptions(); + Map> retrieveAccountMappingOptions(); - public Map> retrieveAccountMappingOptionsForShareProducts(); + Map> retrieveAccountMappingOptionsForShareProducts(); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingRuleType.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingRuleType.java index 640c6e79b..9af5c9b4e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingRuleType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingRuleType.java @@ -43,7 +43,7 @@ public enum AccountingRuleType { return type; } - private AccountingRuleType(final Integer value, final String code) { + AccountingRuleType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/api/FinancialActivityAccountsJsonInputParams.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/api/FinancialActivityAccountsJsonInputParams.java index 2972e7bea..b1021b14e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/api/FinancialActivityAccountsJsonInputParams.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/api/FinancialActivityAccountsJsonInputParams.java @@ -30,7 +30,7 @@ public enum FinancialActivityAccountsJsonInputParams { private final String value; - private FinancialActivityAccountsJsonInputParams(final String value) { + FinancialActivityAccountsJsonInputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/service/FinancialActivityAccountReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/service/FinancialActivityAccountReadPlatformServiceImpl.java index e55256c3c..8d27d7022 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/service/FinancialActivityAccountReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/service/FinancialActivityAccountReadPlatformServiceImpl.java @@ -89,7 +89,7 @@ public class FinancialActivityAccountReadPlatformServiceImpl implements Financia private final String sql; - public FinancialActivityAccountMapper() { + FinancialActivityAccountMapper() { StringBuilder sb = new StringBuilder(300); sb.append( " faa.id as id, faa.financial_activity_type as financialActivityId, glaccount.id as glAccountId,glaccount.name as glAccountName,glaccount.gl_code as glCode "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/api/GLAccountJsonInputParams.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/api/GLAccountJsonInputParams.java index 7eceef626..68645fd22 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/api/GLAccountJsonInputParams.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/api/GLAccountJsonInputParams.java @@ -31,7 +31,7 @@ public enum GLAccountJsonInputParams { private final String value; - private GLAccountJsonInputParams(final String value) { + GLAccountJsonInputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountType.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountType.java index 55239c437..45ad97731 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountType.java @@ -30,7 +30,7 @@ public enum GLAccountType { private final Integer value; private final String code; - private GLAccountType(final Integer value, final String code) { + GLAccountType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountUsage.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountUsage.java index fa545efbd..e478f056a 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountUsage.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountUsage.java @@ -28,7 +28,7 @@ public enum GLAccountUsage { private final Integer value; private final String code; - private GLAccountUsage(final Integer value, final String code) { + GLAccountUsage(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalanceRepository.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalanceRepository.java index e68c70d57..f49e8b5d4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalanceRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalanceRepository.java @@ -27,5 +27,5 @@ import org.springframework.data.repository.query.Param; public interface TrialBalanceRepository extends JpaRepository, JpaSpecificationExecutor { @Query(value = "select * from m_trial_balance where office_id=:officeId and account_id=:accountId and closing_balance is null order by created_date, entry_date", nativeQuery = true) - List findNewByOfficeAndAccount(@Param("officeId") final Long officeId, @Param("accountId") final Long accountId); + List findNewByOfficeAndAccount(@Param("officeId") Long officeId, @Param("accountId") Long accountId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidDeleteException.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidDeleteException.java index f90a76f78..9ddcb1c43 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidDeleteException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidDeleteException.java @@ -26,7 +26,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class GLAccountInvalidDeleteException extends AbstractPlatformDomainRuleException { /*** Enum of reasons for invalid delete **/ - public static enum GlAccountInvalidDeleteReason { + public enum GlAccountInvalidDeleteReason { TRANSANCTIONS_LOGGED, HAS_CHILDREN; diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidUpdateException.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidUpdateException.java index 157a57d2f..14c4259a0 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidUpdateException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidUpdateException.java @@ -26,7 +26,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class GLAccountInvalidUpdateException extends AbstractPlatformDomainRuleException { /*** Enum of reasons for invalid delete **/ - public static enum GlAccountInvalidUpdateReason { + public enum GlAccountInvalidUpdateReason { TRANSANCTIONS_LOGGED; diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformService.java index 91838ecc3..046da52d1 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformService.java @@ -37,7 +37,7 @@ public interface GLAccountReadPlatformService { List retrieveAllEnabledHeaderGLAccounts(GLAccountType accountType); - GLAccountData retrieveNewGLAccountDetails(final Integer type); + GLAccountData retrieveNewGLAccountDetails(Integer type); - List retrieveAccountsByTagId(final Long ruleId, final Integer transactionType); + List retrieveAccountsByTagId(Long ruleId, Integer transactionType); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java index 6c40a4fce..021cfcdcb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java @@ -56,7 +56,7 @@ public class GLAccountReadPlatformServiceImpl implements GLAccountReadPlatformSe private final JournalEntryAssociationParametersData associationParametersData; - public GLAccountMapper(final JournalEntryAssociationParametersData associationParametersData) { + GLAccountMapper(final JournalEntryAssociationParametersData associationParametersData) { if (associationParametersData == null) { this.associationParametersData = new JournalEntryAssociationParametersData(); } else { diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntryJsonInputParams.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntryJsonInputParams.java index 8aabf4446..0d9f46762 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntryJsonInputParams.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/api/JournalEntryJsonInputParams.java @@ -34,7 +34,7 @@ public enum JournalEntryJsonInputParams { private final String value; - private JournalEntryJsonInputParams(final String value) { + JournalEntryJsonInputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/domain/JournalEntryType.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/domain/JournalEntryType.java index efb5a48f5..5dba1ba56 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/domain/JournalEntryType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/domain/JournalEntryType.java @@ -28,7 +28,7 @@ public enum JournalEntryType { private final Integer value; private final String code; - private JournalEntryType(final Integer value, final String code) { + JournalEntryType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/exception/JournalEntryInvalidException.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/exception/JournalEntryInvalidException.java index 94b93b89e..325b304fc 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/exception/JournalEntryInvalidException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/exception/JournalEntryInvalidException.java @@ -27,7 +27,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class JournalEntryInvalidException extends AbstractPlatformDomainRuleException { /*** enum of reasons for invalid Journal Entry **/ - public static enum GlJournalEntryInvalidReason { + public enum GlJournalEntryInvalidReason { FUTURE_DATE, ACCOUNTING_CLOSED, NO_DEBITS_OR_CREDITS, DEBIT_CREDIT_SUM_MISMATCH_WITH_AMOUNT, DEBIT_CREDIT_SUM_MISMATCH, DEBIT_CREDIT_ACCOUNT_OR_AMOUNT_EMPTY, GL_ACCOUNT_DISABLED, GL_ACCOUNT_MANUAL_ENTRIES_NOT_PERMITTED, INVALID_DEBIT_OR_CREDIT_ACCOUNTS; diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryReadPlatformServiceImpl.java index 86e70ee2b..abdcd2f08 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryReadPlatformServiceImpl.java @@ -95,7 +95,7 @@ public class JournalEntryReadPlatformServiceImpl implements JournalEntryReadPlat private final JournalEntryAssociationParametersData associationParametersData; - public GLJournalEntryMapper(final JournalEntryAssociationParametersData associationParametersData) { + GLJournalEntryMapper(final JournalEntryAssociationParametersData associationParametersData) { if (associationParametersData == null) { this.associationParametersData = new JournalEntryAssociationParametersData(); } else { diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryWritePlatformService.java index 297d32e01..054a134dd 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryWritePlatformService.java @@ -39,11 +39,11 @@ public interface JournalEntryWritePlatformService { CommandProcessingResult defineOpeningBalance(JsonCommand command); - public String revertProvisioningJournalEntries(final Date reversalTransactionDate, final Long entityId, final Integer entityType); + String revertProvisioningJournalEntries(Date reversalTransactionDate, Long entityId, Integer entityType); - public String createProvisioningJournalEntries(ProvisioningEntry entry); + String createProvisioningJournalEntries(ProvisioningEntry entry); void createJournalEntriesForShares(Map accountingBridgeData); - void revertShareAccountJournalEntries(final ArrayList transactionId, final Date transactionDate); + void revertShareAccountJournalEntries(ArrayList transactionId, Date transactionDate); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/PortfolioProductType.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/PortfolioProductType.java index 31a50b865..d233e73f2 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/PortfolioProductType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/PortfolioProductType.java @@ -29,7 +29,7 @@ public enum PortfolioProductType { private final Integer value; private final String code; - private PortfolioProductType(final Integer value, final String code) { + PortfolioProductType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformService.java index dfd58159d..3b0a304cc 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformService.java @@ -25,26 +25,26 @@ import org.apache.fineract.accounting.producttoaccountmapping.data.PaymentTypeTo public interface ProductToGLAccountMappingReadPlatformService { - public Map fetchAccountMappingDetailsForLoanProduct(final Long loanProductId, final Integer accountingType); + Map fetchAccountMappingDetailsForLoanProduct(Long loanProductId, Integer accountingType); - public List fetchPaymentTypeToFundSourceMappingsForLoanProduct(final Long loanProductId); + List fetchPaymentTypeToFundSourceMappingsForLoanProduct(Long loanProductId); - public List fetchFeeToIncomeOrLiabilityAccountMappingsForLoanProduct(final Long loanProductId); + List fetchFeeToIncomeOrLiabilityAccountMappingsForLoanProduct(Long loanProductId); - public List fetchPenaltyToIncomeAccountMappingsForLoanProduct(final Long loanProductId); + List fetchPenaltyToIncomeAccountMappingsForLoanProduct(Long loanProductId); - public Map fetchAccountMappingDetailsForSavingsProduct(final Long savingsProductId, final Integer accountingType); + Map fetchAccountMappingDetailsForSavingsProduct(Long savingsProductId, Integer accountingType); - public List fetchPaymentTypeToFundSourceMappingsForSavingsProduct(final Long savingsProductId); + List fetchPaymentTypeToFundSourceMappingsForSavingsProduct(Long savingsProductId); - public List fetchFeeToIncomeAccountMappingsForSavingsProduct(final Long savingsProductId); + List fetchFeeToIncomeAccountMappingsForSavingsProduct(Long savingsProductId); - public List fetchPenaltyToIncomeAccountMappingsForSavingsProduct(final Long savingsProductId); + List fetchPenaltyToIncomeAccountMappingsForSavingsProduct(Long savingsProductId); - public Map fetchAccountMappingDetailsForShareProduct(final Long productId, final Integer accountingType); + Map fetchAccountMappingDetailsForShareProduct(Long productId, Integer accountingType); - public List fetchPaymentTypeToFundSourceMappingsForShareProduct(final Long productId); + List fetchPaymentTypeToFundSourceMappingsForShareProduct(Long productId); - public List fetchFeeToIncomeAccountMappingsForShareProduct(final Long productId); + List fetchFeeToIncomeAccountMappingsForShareProduct(Long productId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/constant/ProvisioningEntriesApiConstants.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/constant/ProvisioningEntriesApiConstants.java index e85310ca0..c32878235 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/constant/ProvisioningEntriesApiConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/constant/ProvisioningEntriesApiConstants.java @@ -20,16 +20,16 @@ package org.apache.fineract.accounting.provisioning.constant; public interface ProvisioningEntriesApiConstants { - public static final String JSON_DATE_PARAM = "date"; + String JSON_DATE_PARAM = "date"; - public static final String JSON_DATEFORMAT_PARAM = "dateFormat"; + String JSON_DATEFORMAT_PARAM = "dateFormat"; - public static final String JSON_LOCALE_PARAM = "locale"; + String JSON_LOCALE_PARAM = "locale"; - public static final String JSON_CREATEJOURNALENTRIES_PARAM = "createjournalentries"; + String JSON_CREATEJOURNALENTRIES_PARAM = "createjournalentries"; - public static final String PROVISIONINGENTRY_PARAM = "provisioningentry"; + String PROVISIONINGENTRY_PARAM = "provisioningentry"; - public static final String ENTRIES_PARAM = "entries"; + String ENTRIES_PARAM = "entries"; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformService.java index 552b5e06e..7550ecc4c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformService.java @@ -27,17 +27,17 @@ import org.apache.fineract.infrastructure.core.service.SearchParameters; public interface ProvisioningEntriesReadPlatformService { - public Collection retrieveLoanProductsProvisioningData(Date date); + Collection retrieveLoanProductsProvisioningData(Date date); - public ProvisioningEntryData retrieveProvisioningEntryData(Long entryId); + ProvisioningEntryData retrieveProvisioningEntryData(Long entryId); - public Page retrieveAllProvisioningEntries(Integer offset, Integer limit); + Page retrieveAllProvisioningEntries(Integer offset, Integer limit); - public ProvisioningEntryData retrieveProvisioningEntryData(String date); + ProvisioningEntryData retrieveProvisioningEntryData(String date); - public ProvisioningEntryData retrieveProvisioningEntryDataByCriteriaId(Long criteriaId); + ProvisioningEntryData retrieveProvisioningEntryDataByCriteriaId(Long criteriaId); - public ProvisioningEntryData retrieveExistingProvisioningIdDateWithJournals(); + ProvisioningEntryData retrieveExistingProvisioningIdDateWithJournals(); - public Page retrieveProvisioningEntries(SearchParameters searchParams); + Page retrieveProvisioningEntries(SearchParameters searchParams); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResourceSwagger.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResourceSwagger.java index 019ff7eda..e5c8979aa 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResourceSwagger.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResourceSwagger.java @@ -118,7 +118,7 @@ final class AccountingRuleApiResourceSwagger { public static class PutAccountingRulesResponsechangesSwagger { - public PutAccountingRulesResponsechangesSwagger() {} + PutAccountingRulesResponsechangesSwagger() {} @Schema(example = "Employee Salary posting rule") public String name; diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java index 2e56de911..1c564cb54 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java @@ -33,7 +33,7 @@ public enum AccountingRuleJsonInputParams { private final String value; - private AccountingRuleJsonInputParams(final String value) { + AccountingRuleJsonInputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/exception/AccountingRuleInvalidException.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/exception/AccountingRuleInvalidException.java index 801270325..5a6d7ef60 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/exception/AccountingRuleInvalidException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/exception/AccountingRuleInvalidException.java @@ -27,7 +27,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class AccountingRuleInvalidException extends AbstractPlatformDomainRuleException { /*** enum of reasons for invalid Accounting Closure **/ - public static enum GlClosureInvalidReason { + public enum GlClosureInvalidReason { FUTURE_DATE, ACCOUNTING_CLOSED; diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/service/AccountingRuleReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/service/AccountingRuleReadPlatformServiceImpl.java index 94f906ae2..2d3cd72c9 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/service/AccountingRuleReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/rule/service/AccountingRuleReadPlatformServiceImpl.java @@ -64,7 +64,7 @@ public class AccountingRuleReadPlatformServiceImpl implements AccountingRuleRead private final GLAccountReadPlatformService glAccountReadPlatformService; private final boolean isAssociationParametersExists; - public AccountingRuleDataExtractor(final JdbcTemplate jdbcTemplate, final GLAccountReadPlatformService glAccountReadPlatformService, + AccountingRuleDataExtractor(final JdbcTemplate jdbcTemplate, final GLAccountReadPlatformService glAccountReadPlatformService, final boolean isAssociationParametersExists) { this.jdbcTemplate = jdbcTemplate; this.glAccountReadPlatformService = glAccountReadPlatformService; diff --git a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/AdHocJsonInputParams.java b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/AdHocJsonInputParams.java index d2b45d987..1c3a10bd8 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/AdHocJsonInputParams.java +++ b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/AdHocJsonInputParams.java @@ -31,7 +31,7 @@ public enum AdHocJsonInputParams { private final String value; - private AdHocJsonInputParams(final String value) { + AdHocJsonInputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/ReportRunFrequency.java b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/ReportRunFrequency.java index 8c79487f5..d502fc053 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/ReportRunFrequency.java +++ b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/ReportRunFrequency.java @@ -33,7 +33,7 @@ public enum ReportRunFrequency { private final long value; private final String code; - private ReportRunFrequency(final long value, final String code) { + ReportRunFrequency(final long value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategy.java b/fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategy.java index 62cf78903..67311f3ea 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategy.java +++ b/fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategy.java @@ -40,5 +40,5 @@ public interface CommandStrategy { * @param uriInfo * @return BatchResponse */ - public BatchResponse execute(BatchRequest batchRequest, UriInfo uriInfo); + BatchResponse execute(BatchRequest batchRequest, UriInfo uriInfo); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandProcessingResultType.java b/fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandProcessingResultType.java index e30d8c599..5a1993fde 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandProcessingResultType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/commands/domain/CommandProcessingResultType.java @@ -28,7 +28,7 @@ public enum CommandProcessingResultType { private final Integer value; private final String code; - private CommandProcessingResultType(final Integer value, final String code) { + CommandProcessingResultType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandProcessingService.java b/fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandProcessingService.java index 19033a13d..50c62e436 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandProcessingService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandProcessingService.java @@ -30,6 +30,6 @@ public interface CommandProcessingService { CommandProcessingResult logCommand(CommandSource commandSourceResult); - boolean validateCommand(final CommandWrapper commandWrapper, final AppUser user); + boolean validateCommand(CommandWrapper commandWrapper, AppUser user); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/AccountNumberFormatRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/AccountNumberFormatRepository.java index bed8e900d..91f6e7995 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/AccountNumberFormatRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/AccountNumberFormatRepository.java @@ -26,7 +26,7 @@ import org.springframework.data.repository.query.Param; public interface AccountNumberFormatRepository extends JpaRepository, JpaSpecificationExecutor { - public static final String FIND_ACCOUNT_NUMBER_FORMAT_FOR_ENTITY = "select anf from AccountNumberFormat anf where anf.accountTypeEnum = :accountTypeEnum"; + String FIND_ACCOUNT_NUMBER_FORMAT_FOR_ENTITY = "select anf from AccountNumberFormat anf where anf.accountTypeEnum = :accountTypeEnum"; @Query(FIND_ACCOUNT_NUMBER_FORMAT_FOR_ENTITY) AccountNumberFormat findOneByAccountTypeEnum(@Param("accountTypeEnum") Integer accountTypeEnum); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/EntityAccountType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/EntityAccountType.java index 1df0217ce..1f23c1baa 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/EntityAccountType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/EntityAccountType.java @@ -29,7 +29,7 @@ public enum EntityAccountType { private final Integer value; private final String code; - private EntityAccountType(final Integer value, final String code) { + EntityAccountType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/service/AccountNumberFormatReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/service/AccountNumberFormatReadPlatformServiceImpl.java index d22f02f79..d25c2911c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/service/AccountNumberFormatReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/service/AccountNumberFormatReadPlatformServiceImpl.java @@ -61,7 +61,7 @@ public class AccountNumberFormatReadPlatformServiceImpl implements AccountNumber private final String schema; - public AccountNumberFormatMapper() { + AccountNumberFormatMapper() { final StringBuilder builder = new StringBuilder(400); builder.append(" anf.id as id, anf.account_type_enum as accountTypeEnum, anf.prefix_type_enum as prefixTypeEnum"); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/GlobalEntityType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/GlobalEntityType.java index 39dc86f38..cab690cac 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/GlobalEntityType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/GlobalEntityType.java @@ -68,7 +68,7 @@ public enum GlobalEntityType { } } - private GlobalEntityType(final Integer value, final String code) { + GlobalEntityType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportFormatType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportFormatType.java index 122bbfc4a..d2b7a8498 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportFormatType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportFormatType.java @@ -27,7 +27,7 @@ public enum ImportFormatType { private final String format; - private ImportFormatType(String format) { + ImportFormatType(String format) { this.format = format; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandler.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandler.java index 6aacc5b70..cbd551150 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandler.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandler.java @@ -23,5 +23,5 @@ import org.apache.poi.ss.usermodel.Workbook; public interface ImportHandler { - public Count process(Workbook workbook, String locale, String dateFormat); + Count process(Workbook workbook, String locale, String dateFormat); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorService.java index 2c872039f..8ed29da16 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorService.java @@ -22,5 +22,5 @@ import javax.ws.rs.core.Response; public interface BulkImportWorkbookPopulatorService { - public Response getTemplate(final String entityType, final Long officeId, final Long staffId, final String dateFormat); + Response getTemplate(String entityType, Long officeId, Long staffId, String dateFormat); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookService.java index c2f727852..a603eff41 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookService.java @@ -28,13 +28,13 @@ import org.apache.fineract.infrastructure.documentmanagement.data.DocumentData; public interface BulkImportWorkbookService { - public Long importWorkbook(String entityType, InputStream inputStream, FormDataContentDisposition fileDetail, final String locale, - final String dateFormat); + Long importWorkbook(String entityType, InputStream inputStream, FormDataContentDisposition fileDetail, String locale, + String dateFormat); - public Collection getImports(GlobalEntityType type); + Collection getImports(GlobalEntityType type); - public DocumentData getOutputTemplateLocation(String importDocumentId); + DocumentData getOutputTemplateLocation(String importDocumentId); - public Response getOutputTemplate(String importDocumentId); + Response getOutputTemplate(String importDocumentId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache/domain/CacheType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache/domain/CacheType.java index 51f2debc8..5994a31fd 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache/domain/CacheType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/cache/domain/CacheType.java @@ -47,7 +47,7 @@ public enum CacheType { return type; } - private CacheType(final Integer value, final String code) { + CacheType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/constants/CampaignType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/constants/CampaignType.java index ce8ac2a20..13e765c68 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/constants/CampaignType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/constants/CampaignType.java @@ -27,7 +27,7 @@ public enum CampaignType { private final Integer value; private final String code; - private CampaignType(Integer value, String code) { + CampaignType(Integer value, String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/ScheduledEmailStretchyReportParamDateOption.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/ScheduledEmailStretchyReportParamDateOption.java index 68b28dee1..e2af910a0 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/ScheduledEmailStretchyReportParamDateOption.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/ScheduledEmailStretchyReportParamDateOption.java @@ -35,7 +35,7 @@ public enum ScheduledEmailStretchyReportParamDateOption { * @param code * @param value */ - private ScheduledEmailStretchyReportParamDateOption(final Integer id, final String code, final String value) { + ScheduledEmailStretchyReportParamDateOption(final Integer id, final String code, final String value) { this.value = value; this.code = code; this.id = id; diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationReadPlatformServiceImpl.java index 1ddd2afd3..472f4f3b4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationReadPlatformServiceImpl.java @@ -48,7 +48,7 @@ public class EmailConfigurationReadPlatformServiceImpl implements EmailConfigura final String schema; - public EmailConfigurationRowMapper() { + EmailConfigurationRowMapper() { final StringBuilder sql = new StringBuilder(300); sql.append("cnf.id as id, "); sql.append("cnf.name as name, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformService.java index cc9276004..99f105c49 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformService.java @@ -31,13 +31,13 @@ public interface EmailReadPlatformService { EmailData retrieveOne(Long resourceId); - Collection retrieveAllPending(final SearchParameters searchParameters); + Collection retrieveAllPending(SearchParameters searchParameters); - Collection retrieveAllSent(final SearchParameters searchParameters); + Collection retrieveAllSent(SearchParameters searchParameters); Collection retrieveAllDelivered(Integer limit); - Collection retrieveAllFailed(final SearchParameters searchParameters); + Collection retrieveAllFailed(SearchParameters searchParameters); Page retrieveEmailByStatus(Integer limit, Integer status, Date dateFrom, Date dateTo); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformServiceImpl.java index 0f1d7633a..bbed73949 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailReadPlatformServiceImpl.java @@ -58,7 +58,7 @@ public class EmailReadPlatformServiceImpl implements EmailReadPlatformService { final String schema; - public EmailMapper() { + EmailMapper() { final StringBuilder sql = new StringBuilder(300); sql.append(" emo.id as id, "); sql.append("emo.group_id as groupId, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignStatus.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignStatus.java index 43d3c27d7..399e90ac6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignStatus.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignStatus.java @@ -28,7 +28,7 @@ public enum SmsCampaignStatus { private final Integer value; private final String code; - private SmsCampaignStatus(Integer value, String code) { + SmsCampaignStatus(Integer value, String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignTriggerType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignTriggerType.java index cc992417c..83349e9bb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignTriggerType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/constants/SmsCampaignTriggerType.java @@ -28,7 +28,7 @@ public enum SmsCampaignTriggerType { private final Integer value; private final String code; - private SmsCampaignTriggerType(Integer value, String code) { + SmsCampaignTriggerType(Integer value, String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaignRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaignRepository.java index 32f562dbc..a36d43c12 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaignRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaignRepository.java @@ -27,16 +27,14 @@ import org.springframework.data.repository.query.Param; public interface SmsCampaignRepository extends JpaRepository, JpaSpecificationExecutor { - List findByCampaignType(final Integer campaignType); + List findByCampaignType(Integer campaignType); - Collection findByCampaignTypeAndTriggerTypeAndStatus(final Integer campaignType, final Integer triggerType, - final Integer status); + Collection findByCampaignTypeAndTriggerTypeAndStatus(Integer campaignType, Integer triggerType, Integer status); - Collection findByTriggerTypeAndStatus(final Integer triggerType, final Integer status); + Collection findByTriggerTypeAndStatus(Integer triggerType, Integer status); - Collection findByTriggerType(final Integer triggerType); + Collection findByTriggerType(Integer triggerType); @Query("SELECT campaign FROM SmsCampaign campaign WHERE campaign.paramValue LIKE :reportPattern AND campaign.triggerType=:triggerType AND campaign.status=300") - List findActiveSmsCampaigns(@Param("reportPattern") final String reportPattern, - @Param("triggerType") final Integer triggerType); + List findActiveSmsCampaigns(@Param("reportPattern") String reportPattern, @Param("triggerType") Integer triggerType); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDomainServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDomainServiceImpl.java index 55b43b049..4f695e691 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDomainServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDomainServiceImpl.java @@ -478,7 +478,7 @@ public class SmsCampaignDomainServiceImpl implements SmsCampaignDomainService { final boolean isDeposit; - public SavingsAccountTransactionListener(final boolean isDeposit) { + SavingsAccountTransactionListener(final boolean isDeposit) { this.isDeposit = isDeposit; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignReadPlatformService.java index c62d75f90..9d19356b0 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignReadPlatformService.java @@ -25,11 +25,11 @@ import org.apache.fineract.infrastructure.core.service.SearchParameters; public interface SmsCampaignReadPlatformService { - public SmsCampaignData retrieveOne(final Long campaignId); + SmsCampaignData retrieveOne(Long campaignId); - public Page retrieveAll(final SearchParameters searchParameters); + Page retrieveAll(SearchParameters searchParameters); - public SmsCampaignData retrieveTemplate(final String reportType); + SmsCampaignData retrieveTemplate(String reportType); Collection retrieveAllScheduleActiveCampaign(); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignWritePlatformService.java index 18520274a..da965a67c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignWritePlatformService.java @@ -49,10 +49,10 @@ public interface SmsCampaignWritePlatformService { CampaignPreviewData previewMessage(JsonQuery query); - public void storeTemplateMessageIntoSmsOutBoundTable() throws JobExecutionException; + void storeTemplateMessageIntoSmsOutBoundTable() throws JobExecutionException; - public void insertDirectCampaignIntoSmsOutboundTable(final Client client, final SmsCampaign smsCampaign); + void insertDirectCampaignIntoSmsOutboundTable(Client client, SmsCampaign smsCampaign); - public void insertDirectCampaignIntoSmsOutboundTable(final SavingsAccount savingsAccount, final SmsCampaign smsCampaign); + void insertDirectCampaignIntoSmsOutboundTable(SavingsAccount savingsAccount, SmsCampaign smsCampaign); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/CodeConstants.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/CodeConstants.java index 5b833ead5..827cdb41f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/CodeConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/CodeConstants.java @@ -26,14 +26,14 @@ public class CodeConstants { /*** * Enum of all parameters passed in while creating/updating a code and code value ***/ - public static enum CodevalueJSONinputParams { + public enum CodevalueJSONinputParams { CODEVALUE_ID("id"), NAME("name"), POSITION("position"), DESCRIPTION("description"), IS_ACTIVE("isActive"), IS_MANDATORY( "isMandatory"); private final String value; - private CodevalueJSONinputParams(final String value) { + CodevalueJSONinputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/service/CodeValueReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/service/CodeValueReadPlatformService.java index cfbd528a7..d1e508bc4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/service/CodeValueReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/service/CodeValueReadPlatformService.java @@ -40,9 +40,9 @@ import org.apache.fineract.infrastructure.codes.data.CodeValueData; */ public interface CodeValueReadPlatformService { - Collection retrieveCodeValuesByCode(final String code); + Collection retrieveCodeValuesByCode(String code); - Collection retrieveAllCodeValues(final Long codeId); + Collection retrieveAllCodeValues(Long codeId); - CodeValueData retrieveCodeValue(final Long codeValueId); + CodeValueData retrieveCodeValue(Long codeValueId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainService.java index cc1b1994a..4b791c92b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainService.java @@ -55,9 +55,9 @@ public interface ConfigurationDomainService { Integer retrieveFinancialYearBeginningMonth(); - public Integer retrieveMinAllowedClientsInGroup(); + Integer retrieveMinAllowedClientsInGroup(); - public Integer retrieveMaxAllowedClientsInGroup(); + Integer retrieveMaxAllowedClientsInGroup(); boolean isMeetingMandatoryForJLGLoans(); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/service/ExternalServicesConstants.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/service/ExternalServicesConstants.java index 454d1f25d..77978cbbe 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/service/ExternalServicesConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/service/ExternalServicesConstants.java @@ -52,13 +52,13 @@ public final class ExternalServicesConstants { public static final String NOTIFICATION_GCM_END_POINT = "gcm_end_point"; public static final String NOTIFICATION_FCM_END_POINT = "fcm_end_point"; - public static enum ExternalservicePropertiesJSONinputParams { + public enum ExternalservicePropertiesJSONinputParams { EXTERNAL_SERVICE_ID("external_service_id"), NAME("name"), VALUE("value"); private final String value; - private ExternalservicePropertiesJSONinputParams(final String value) { + ExternalservicePropertiesJSONinputParams(final String value) { this.value = value; } @@ -84,14 +84,14 @@ public final class ExternalServicesConstants { } } - public static enum SMTPJSONinputParams { + public enum SMTPJSONinputParams { USERNAME("username"), PASSWORD("password"), HOST("host"), PORT("port"), USETLS("useTLS"), FROM_EMAIL("fromEmail"), FROM_NAME( "fromName"); private final String value; - private SMTPJSONinputParams(final String value) { + SMTPJSONinputParams(final String value) { this.value = value; } @@ -117,13 +117,13 @@ public final class ExternalServicesConstants { } } - public static enum SMSJSONinputParams { + public enum SMSJSONinputParams { HASTNAME("host_name"), PORT("port_number"), END_POINT("end_point"), TENANT_APP_KEY("tenant_app_key"); private final String value; - private SMSJSONinputParams(final String value) { + SMSJSONinputParams(final String value) { this.value = value; } @@ -149,13 +149,13 @@ public final class ExternalServicesConstants { } } - public static enum S3JSONinputParams { + public enum S3JSONinputParams { S3_ACCESS_KEY("s3_access_key"), S3_BUCKET_NAME("s3_bucket_name"), S3_SECRET_KEY("s3_secret_key"); private final String value; - private S3JSONinputParams(final String value) { + S3JSONinputParams(final String value) { this.value = value; } @@ -181,13 +181,13 @@ public final class ExternalServicesConstants { } } - public static enum NotificationJSONinputParams { + public enum NotificationJSONinputParams { SERVER_KEY("server_key"), GCM_END_POINT("gcm_end_point"), FCM_END_POINT("fcm_end_point"); private final String value; - private NotificationJSONinputParams(final String value) { + NotificationJSONinputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/AbstractFromApiJsonDeserializer.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/AbstractFromApiJsonDeserializer.java index 643c4caef..d4f64d273 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/AbstractFromApiJsonDeserializer.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/AbstractFromApiJsonDeserializer.java @@ -24,5 +24,5 @@ package org.apache.fineract.infrastructure.core.serialization; public abstract class AbstractFromApiJsonDeserializer implements FromApiJsonDeserializer { @Override - public abstract T commandFromApiJson(final String json); + public abstract T commandFromApiJson(String json); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromApiJsonDeserializer.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromApiJsonDeserializer.java index 405372960..4580f695f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromApiJsonDeserializer.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromApiJsonDeserializer.java @@ -23,5 +23,5 @@ package org.apache.fineract.infrastructure.core.serialization; */ public interface FromApiJsonDeserializer { - T commandFromApiJson(final String json); + T commandFromApiJson(String json); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromCommandJsonDeserializer.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromCommandJsonDeserializer.java index a763700ec..1215a0032 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromCommandJsonDeserializer.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/FromCommandJsonDeserializer.java @@ -23,9 +23,9 @@ package org.apache.fineract.infrastructure.core.serialization; */ public interface FromCommandJsonDeserializer { - T commandFromCommandJson(final String json); + T commandFromCommandJson(String json); - T commandFromCommandJson(final Long resourceId, final String json); + T commandFromCommandJson(Long resourceId, String json); - T commandFromCommandJson(final Long resourceId, final String json, final boolean makerCheckerApproval); + T commandFromCommandJson(Long resourceId, String json, boolean makerCheckerApproval); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java index 9a4d99532..c0b6c80b6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java @@ -176,7 +176,7 @@ public final class SearchParameters { loanId, savingsId, orphansOnly, isSelfUser); } - public static final SearchParameters forProvisioningEntries(final Long provisioningEntryId, final Long officeId, final Long productId, + public static SearchParameters forProvisioningEntries(final Long provisioningEntryId, final Long officeId, final Long productId, final Long categoryId, final Integer offset, final Integer limit) { return new SearchParameters(provisioningEntryId, officeId, productId, categoryId, offset, limit); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java index a9da7c73f..5e085d2e6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java @@ -51,7 +51,7 @@ public enum EntityTables { private final String foreignKeyColumnNameOnDatatable; - private EntityTables(String name, ImmutableList codes, String foreignKeyColumnNameOnDatatable) { + EntityTables(String name, ImmutableList codes, String foreignKeyColumnNameOnDatatable) { this.name = name; this.codes = codes; this.foreignKeyColumnNameOnDatatable = foreignKeyColumnNameOnDatatable; diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/StatusEnum.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/StatusEnum.java index fc8627002..6c848f467 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/StatusEnum.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/StatusEnum.java @@ -35,7 +35,7 @@ public enum StatusEnum { return code; } - private StatusEnum(String name, Integer code) { + StatusEnum(String name, Integer code) { this.name = name; this.code = code; diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/EntityDatatableChecksRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/EntityDatatableChecksRepository.java index 0bacdacb6..5b08ae304 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/EntityDatatableChecksRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/EntityDatatableChecksRepository.java @@ -27,23 +27,23 @@ import org.springframework.data.repository.query.Param; public interface EntityDatatableChecksRepository extends JpaRepository, JpaSpecificationExecutor { - public List findByEntityAndStatus(String entityName, Long status); + List findByEntityAndStatus(String entityName, Long status); @Query("select t from EntityDatatableChecks t WHERE t.status =:status and t.entity=:entity and t.productId = :productId ") - public List findByEntityStatusAndProduct(@Param("entity") String entity, @Param("status") Long status, + List findByEntityStatusAndProduct(@Param("entity") String entity, @Param("status") Long status, @Param("productId") Long productId); @Query("select t from EntityDatatableChecks t WHERE t.status =:status and t.entity=:entity and t.productId IS NULL ") - public List findByEntityStatusAndNoProduct(@Param("entity") String entity, @Param("status") Long status); + List findByEntityStatusAndNoProduct(@Param("entity") String entity, @Param("status") Long status); @Query("select t from EntityDatatableChecks t WHERE t.status =:status " + "and t.entity=:entity and t.datatableName = :datatableName AND t.productId = :productId") - public List findByEntityStatusAndDatatableIdAndProductId(@Param("entity") String entityName, + List findByEntityStatusAndDatatableIdAndProductId(@Param("entity") String entityName, @Param("status") Long status, @Param("datatableName") String datatableName, @Param("productId") Long productId); @Query("select t from EntityDatatableChecks t WHERE t.status =:status and t.entity=:entity " + " and t.datatableName = :datatableName AND t.productId IS NULL") - public List findByEntityStatusAndDatatableIdAndNoProduct(@Param("entity") String entityName, + List findByEntityStatusAndDatatableIdAndNoProduct(@Param("entity") String entityName, @Param("status") Long status, @Param("datatableName") String datatableName); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/EntityDatatableChecksWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/EntityDatatableChecksWritePlatformService.java index 533a1eb36..0bb309e42 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/EntityDatatableChecksWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/EntityDatatableChecksWritePlatformService.java @@ -26,12 +26,11 @@ public interface EntityDatatableChecksWritePlatformService { CommandProcessingResult createCheck(JsonCommand command); - CommandProcessingResult deleteCheck(final Long entityDatatableCheckId); + CommandProcessingResult deleteCheck(Long entityDatatableCheckId); - void runTheCheck(final Long entityId, final String entityName, final Long statusCode, String foreignKeyColumn); + void runTheCheck(Long entityId, String entityName, Long statusCode, String foreignKeyColumn); - void runTheCheckForProduct(final Long entityId, final String entityName, final Long statusCode, String foreignKeyColumn, - long productLoanId); + void runTheCheckForProduct(Long entityId, String entityName, Long statusCode, String foreignKeyColumn, long productLoanId); boolean saveDatatables(Long status, String entity, Long entityId, Long productId, JsonArray data); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataService.java index d83a06c34..6ca0bcd7c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataService.java @@ -24,7 +24,7 @@ import org.apache.fineract.infrastructure.dataqueries.data.ResultsetColumnHeader public interface GenericDataService { - GenericResultsetData fillGenericResultSet(final String sql); + GenericResultsetData fillGenericResultSet(String sql); String generateJsonFromGenericResultsetData(GenericResultsetData grs); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingService.java index f1d723fe0..dd0ef88eb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingService.java @@ -43,7 +43,7 @@ public interface ReadReportingService { Collection getAllowedParameters(); - ReportData retrieveReport(final Long id); + ReportData retrieveReport(Long id); Collection getAllowedReportTypes(); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepository.java index 364da1e08..08ca0a713 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepository.java @@ -28,28 +28,28 @@ import org.apache.fineract.infrastructure.documentmanagement.domain.StorageType; public interface ContentRepository { - public StorageType type = null; + StorageType type = null; // TODO:Vishwas Need to move these settings to the Database - public static final Integer MAX_FILE_UPLOAD_SIZE_IN_MB = 5; + Integer MAX_FILE_UPLOAD_SIZE_IN_MB = 5; // TODO:Vishwas Need to move these settings to the Database - public static final Integer MAX_IMAGE_UPLOAD_SIZE_IN_MB = 1; + Integer MAX_IMAGE_UPLOAD_SIZE_IN_MB = 1; - public abstract String saveFile(InputStream uploadedInputStream, DocumentCommand documentCommand); + String saveFile(InputStream uploadedInputStream, DocumentCommand documentCommand); - public abstract void deleteFile(String fileName, String documentPath); + void deleteFile(String fileName, String documentPath); - public abstract FileData fetchFile(DocumentData documentData); + FileData fetchFile(DocumentData documentData); - public abstract String saveImage(InputStream uploadedInputStream, Long resourceId, String imageName, Long fileSize); + String saveImage(InputStream uploadedInputStream, Long resourceId, String imageName, Long fileSize); - public abstract String saveImage(Base64EncodedImage base64EncodedImage, Long resourceId, String imageName); + String saveImage(Base64EncodedImage base64EncodedImage, Long resourceId, String imageName); - public abstract void deleteImage(final Long resourceId, final String location); + void deleteImage(Long resourceId, String location); - public abstract ImageData fetchImage(ImageData imageData); + ImageData fetchImage(ImageData imageData); - public abstract StorageType getStorageType(); + StorageType getStorageType(); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java index 660bcf3ed..76211a290 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java @@ -37,13 +37,13 @@ public final class ContentRepositoryUtils { private static final Random random = new Random(); - public static enum ImageMIMEtype { + public enum ImageMIMEtype { GIF("image/gif"), JPEG("image/jpeg"), PNG("image/png"); private final String value; - private ImageMIMEtype(final String value) { + ImageMIMEtype(final String value) { this.value = value; } @@ -67,13 +67,13 @@ public final class ContentRepositoryUtils { } } - public static enum ImageFileExtension { + public enum ImageFileExtension { GIF(".gif"), JPEG(".jpeg"), JPG(".jpg"), PNG(".png"); private final String value; - private ImageFileExtension(final String value) { + ImageFileExtension(final String value) { this.value = value; } @@ -99,14 +99,14 @@ public final class ContentRepositoryUtils { } } - public static enum ImageDataURIsuffix { + public enum ImageDataURIsuffix { GIF("data:" + ImageMIMEtype.GIF.getValue() + ";base64,"), JPEG("data:" + ImageMIMEtype.JPEG.getValue() + ";base64,"), PNG( "data:" + ImageMIMEtype.PNG.getValue() + ";base64,"); private final String value; - private ImageDataURIsuffix(final String value) { + ImageDataURIsuffix(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentReadPlatformServiceImpl.java index 4e0c47734..f76a05b2a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentReadPlatformServiceImpl.java @@ -103,7 +103,7 @@ public class DocumentReadPlatformServiceImpl implements DocumentReadPlatformServ private final boolean hideLocation; private final boolean hideStorageType; - public DocumentMapper(final boolean hideLocation, final boolean hideStorageType) { + DocumentMapper(final boolean hideLocation, final boolean hideStorageType) { this.hideLocation = hideLocation; this.hideStorageType = hideStorageType; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentWritePlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentWritePlatformServiceJpaRepositoryImpl.java index b2c7f058d..dce1ab842 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentWritePlatformServiceJpaRepositoryImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/DocumentWritePlatformServiceJpaRepositoryImpl.java @@ -177,7 +177,7 @@ public class DocumentWritePlatformServiceJpaRepositoryImpl implements DocumentWr } /*** Entities for document Management **/ - public static enum DocumentManagementEntity { + public enum DocumentManagementEntity { CLIENTS, CLIENT_IDENTIFIERS, STAFF, LOANS, SAVINGS, GROUPS, IMPORT; diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/ImageReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/ImageReadPlatformServiceImpl.java index 707588cd7..b4f3fc6ee 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/ImageReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/service/ImageReadPlatformServiceImpl.java @@ -58,7 +58,7 @@ public class ImageReadPlatformServiceImpl implements ImageReadPlatformService { private final String entityDisplayName; - public ImageMapper(final String entityDisplayName) { + ImageMapper(final String entityDisplayName) { this.entityDisplayName = entityDisplayName; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/FineractEntityAccessConstants.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/FineractEntityAccessConstants.java index 7cc771d39..6ceccea03 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/FineractEntityAccessConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/FineractEntityAccessConstants.java @@ -31,14 +31,14 @@ public final class FineractEntityAccessConstants { /*** * Enum of all parameters passed in while creating/updating an entity access ***/ - public static enum EntityAccessJSONinputParams { + public enum EntityAccessJSONinputParams { ENTITY_TYPE("entityType"), ENTITY_ID("entityId"), ENTITY_ACCESS_TYPE_ID("entityAccessTypeId"), SECOND_ENTITY_TYPE( "secondEntityType"), SECOND_ENTITY_ID("secondEntityId"); private final String value; - private EntityAccessJSONinputParams(final String value) { + EntityAccessJSONinputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadService.java index 7dbcd0240..41f2ae4c9 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadService.java @@ -25,10 +25,10 @@ import org.apache.fineract.infrastructure.entityaccess.domain.FineractEntityType public interface FineractEntityAccessReadService { - Collection retrieveEntityAccessFor(FineractEntityType firstEntityType, final Long relId, - final Long fromEntityId, boolean includeAllSubOffices); + Collection retrieveEntityAccessFor(FineractEntityType firstEntityType, Long relId, Long fromEntityId, + boolean includeAllSubOffices); - String getSQLQueryInClause_WithListOfIDsForEntityAccess(FineractEntityType firstEntityType, final Long relId, final Long fromEntityId, + String getSQLQueryInClause_WithListOfIDsForEntityAccess(FineractEntityType firstEntityType, Long relId, Long fromEntityId, boolean includeAllOffices); String getSQLQueryInClauseIDList_ForLoanProductsForOffice(Long loanProductId, boolean includeAllOffices); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadServiceImpl.java index 72052ac92..e720b7176 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessReadServiceImpl.java @@ -221,7 +221,7 @@ public class FineractEntityAccessReadServiceImpl implements FineractEntityAccess private final String schema; - public GetOneEntityMapper() { + GetOneEntityMapper() { StringBuilder str = new StringBuilder("select eem.rel_id as relId, "); str.append("eem.from_id as fromId,eem.to_Id as toId,eem.start_date as startDate,eem.end_date as endDate "); @@ -252,7 +252,7 @@ public class FineractEntityAccessReadServiceImpl implements FineractEntityAccess private final String schema; - public EntityToEntityMapper() { + EntityToEntityMapper() { StringBuilder str = new StringBuilder("select eem.id as mapId, "); str.append("eem.rel_id as relId, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessWriteService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessWriteService.java index fbd8f53f3..25afdb9a8 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessWriteService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/entityaccess/service/FineractEntityAccessWriteService.java @@ -24,21 +24,20 @@ import org.apache.fineract.infrastructure.core.data.CommandProcessingResult; public interface FineractEntityAccessWriteService { - CommandProcessingResult createEntityAccess(final JsonCommand command); + CommandProcessingResult createEntityAccess(JsonCommand command); - CommandProcessingResult createEntityToEntityMapping(final Long relId, final JsonCommand command); + CommandProcessingResult createEntityToEntityMapping(Long relId, JsonCommand command); - CommandProcessingResult updateEntityToEntityMapping(final Long mapId, final JsonCommand command); + CommandProcessingResult updateEntityToEntityMapping(Long mapId, JsonCommand command); - CommandProcessingResult deleteEntityToEntityMapping(final Long mapId); + CommandProcessingResult deleteEntityToEntityMapping(Long mapId); - void addNewEntityAccess(final String entityType, final Long entityId, final CodeValue accessType, final String secondEntityType, - final Long secondEntityId); + void addNewEntityAccess(String entityType, Long entityId, CodeValue accessType, String secondEntityType, Long secondEntityId); /* - * CommandProcessingResult updateEntityAccess ( final Long entityAccessId, final JsonCommand command); + * CommandProcessingResult updateEntityAccess ( Long entityAccessId, JsonCommand command); * - * CommandProcessingResult removeEntityAccess ( final String entityType, final Long entityId, final Long accessType, - * final String secondEntityType, final Long secondEntityId); + * CommandProcessingResult removeEntityAccess ( String entityType, Long entityId, Long accessType, String + * secondEntityType, Long secondEntityId); */ } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/DeviceRegistrationRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/DeviceRegistrationRepository.java index f2365a516..53f22fd7e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/DeviceRegistrationRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/DeviceRegistrationRepository.java @@ -26,7 +26,7 @@ import org.springframework.data.repository.query.Param; public interface DeviceRegistrationRepository extends JpaRepository, JpaSpecificationExecutor { - public static final String FIND_DEVICE_REGISTRATION_BY_CLIENT = "select dr from DeviceRegistration dr where dr.client.id =:clientId "; + String FIND_DEVICE_REGISTRATION_BY_CLIENT = "select dr from DeviceRegistration dr where dr.client.id =:clientId "; @Query(FIND_DEVICE_REGISTRATION_BY_CLIENT) DeviceRegistration findDeviceRegistrationByClientId(@Param("clientId") Long clientId); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationReadPlatformServiceImpl.java index 1b3f7dee7..1cf8aa11a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationReadPlatformServiceImpl.java @@ -50,7 +50,7 @@ public class DeviceRegistrationReadPlatformServiceImpl implements DeviceRegistra private final String schema; - public DeviceRegistrationDataMapper() { + DeviceRegistrationDataMapper() { final StringBuilder sqlBuilder = new StringBuilder(200); sqlBuilder.append(" cdr.id as id, cdr.registration_id as registrationId, cdr.updatedon_date as updatedOnDate, "); sqlBuilder.append(" c.id as clientId, c.display_name as clientName "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationWritePlatformService.java index 2391fdd58..f10975b60 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/service/DeviceRegistrationWritePlatformService.java @@ -22,9 +22,9 @@ import org.apache.fineract.infrastructure.gcm.domain.DeviceRegistration; public interface DeviceRegistrationWritePlatformService { - public DeviceRegistration registerDevice(final Long clientId, final String registrationId); + DeviceRegistration registerDevice(Long clientId, String registrationId); - public DeviceRegistration updateDeviceRegistration(final Long id, final Long clientId, final String registrationId); + DeviceRegistration updateDeviceRegistration(Long id, Long clientId, String registrationId); - public void deleteDeviceRegistration(final Long id); + void deleteDeviceRegistration(Long id); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/processor/WebHookService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/processor/WebHookService.java index f76fc7e53..c4eaed46d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/processor/WebHookService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/processor/WebHookService.java @@ -32,11 +32,11 @@ import retrofit.http.POST; public interface WebHookService { - static final String ENTITY_HEADER = "X-Fineract-Entity"; - static final String ACTION_HEADER = "X-Fineract-Action"; - static final String TENANT_HEADER = "Fineract-Platform-TenantId"; - static final String ENDPOINT_HEADER = "X-Fineract-Endpoint"; - static final String API_KEY_HEADER = "X-Fineract-API-Key"; + String ENTITY_HEADER = "X-Fineract-Entity"; + String ACTION_HEADER = "X-Fineract-Action"; + String TENANT_HEADER = "Fineract-Platform-TenantId"; + String ENDPOINT_HEADER = "X-Fineract-Endpoint"; + String API_KEY_HEADER = "X-Fineract-API-Key"; // Ping @GET("/") diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java index 26d93081d..33c80dbef 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformService.java @@ -29,7 +29,7 @@ public interface HookReadPlatformService { HookData retrieveHook(Long hookId); - List retrieveHooksByEvent(final String entityName, final String actionName); + List retrieveHooksByEvent(String entityName, String actionName); HookData retrieveNewHookDetails(String templateName); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java index 0ddc08899..34f73662e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookReadPlatformServiceImpl.java @@ -119,7 +119,7 @@ public class HookReadPlatformServiceImpl implements HookReadPlatformService { private final JdbcTemplate jdbcTemplate; - public HookMapper(final JdbcTemplate jdbcTemplate) { + HookMapper(final JdbcTemplate jdbcTemplate) { this.jdbcTemplate = jdbcTemplate; } @@ -199,7 +199,7 @@ public class HookReadPlatformServiceImpl implements HookReadPlatformService { private final JdbcTemplate jdbcTemplate; - public TemplateMapper(final JdbcTemplate jdbcTemplate) { + TemplateMapper(final JdbcTemplate jdbcTemplate) { this.jdbcTemplate = jdbcTemplate; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java index fd0892006..7417cc6d9 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java @@ -50,7 +50,7 @@ public enum JobName { private final String name; - private JobName(final String name) { + JobName(final String name) { this.name = name; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobRegisterService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobRegisterService.java index 54ac539a9..05e025dca 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobRegisterService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobRegisterService.java @@ -20,18 +20,18 @@ package org.apache.fineract.infrastructure.jobs.service; public interface JobRegisterService { - public void executeJob(Long jobId); + void executeJob(Long jobId); - public void rescheduleJob(Long jobId); + void rescheduleJob(Long jobId); - public void pauseScheduler(); + void pauseScheduler(); - public void startScheduler(); + void startScheduler(); - public boolean isSchedulerRunning(); + boolean isSchedulerRunning(); - public void stopScheduler(String name); + void stopScheduler(String name); - public void stopAllSchedulers(); + void stopAllSchedulers(); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformService.java index a70e32e20..992430386 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformService.java @@ -27,24 +27,24 @@ import org.apache.fineract.infrastructure.jobs.domain.SchedulerDetail; public interface SchedularWritePlatformService { - public List retrieveAllJobs(); + List retrieveAllJobs(); - public ScheduledJobDetail findByJobKey(String triggerKey); + ScheduledJobDetail findByJobKey(String triggerKey); - public void saveOrUpdate(ScheduledJobDetail scheduledJobDetails); + void saveOrUpdate(ScheduledJobDetail scheduledJobDetails); - public void saveOrUpdate(ScheduledJobDetail scheduledJobDetails, ScheduledJobRunHistory scheduledJobRunHistory); + void saveOrUpdate(ScheduledJobDetail scheduledJobDetails, ScheduledJobRunHistory scheduledJobRunHistory); - public Long fetchMaxVersionBy(String triggerKey); + Long fetchMaxVersionBy(String triggerKey); - public ScheduledJobDetail findByJobId(Long jobId); + ScheduledJobDetail findByJobId(Long jobId); - public CommandProcessingResult updateJobDetail(Long jobId, JsonCommand command); + CommandProcessingResult updateJobDetail(Long jobId, JsonCommand command); - public SchedulerDetail retriveSchedulerDetail(); + SchedulerDetail retriveSchedulerDetail(); - public void updateSchedulerDetail(final SchedulerDetail schedulerDetail); + void updateSchedulerDetail(SchedulerDetail schedulerDetail); - public boolean processJobDetailForExecution(String jobKey, String triggerType); + boolean processJobDetailForExecution(String jobKey, String triggerType); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedulerServiceConstants.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedulerServiceConstants.java index 4bd5b80f7..178c5de43 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedulerServiceConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedulerServiceConstants.java @@ -20,22 +20,22 @@ package org.apache.fineract.infrastructure.jobs.service; public interface SchedulerServiceConstants { - public static final String JOB_KEY_SEPERATOR = " _ "; - public static final String TRIGGER_TYPE_CRON = "cron"; - public static final String TRIGGER_TYPE_APPLICATION = "application"; - public static final String TRIGGER_TYPE_REFERENCE = "TRIGGER_TYPE_REFERENCE"; - public static final String SCHEDULER_EXCEPTION = "SchedulerException"; - public static final String JOB_EXECUTION_EXCEPTION = "JobExecutionException"; - public static final String JOB_METHOD_INVOCATION_FAILED_EXCEPTION = "JobMethodInvocationFailedException"; - public static final String STATUS_SUCCESS = "success"; - public static final String STATUS_FAILED = "failed"; - public static final String DEFAULT_LISTENER_NAME = "Global Listner"; - public static final int STACK_TRACE_LEVEL = 7; - public static final String TENANT_IDENTIFIER = "tenantIdentifier"; - public static final String SCHEDULER = "Scheduler"; - public static final String SCHEDULER_GROUP = "group"; - public static final int DEFAULT_THREAD_COUNT = 7; - public static final int GROUP_THREAD_COUNT = 1; - public static final String SCHEDULER_NAME = "schedulerName"; + String JOB_KEY_SEPERATOR = " _ "; + String TRIGGER_TYPE_CRON = "cron"; + String TRIGGER_TYPE_APPLICATION = "application"; + String TRIGGER_TYPE_REFERENCE = "TRIGGER_TYPE_REFERENCE"; + String SCHEDULER_EXCEPTION = "SchedulerException"; + String JOB_EXECUTION_EXCEPTION = "JobExecutionException"; + String JOB_METHOD_INVOCATION_FAILED_EXCEPTION = "JobMethodInvocationFailedException"; + String STATUS_SUCCESS = "success"; + String STATUS_FAILED = "failed"; + String DEFAULT_LISTENER_NAME = "Global Listner"; + int STACK_TRACE_LEVEL = 7; + String TENANT_IDENTIFIER = "tenantIdentifier"; + String SCHEDULER = "Scheduler"; + String SCHEDULER_GROUP = "group"; + int DEFAULT_THREAD_COUNT = 7; + int GROUP_THREAD_COUNT = 1; + String SCHEDULER_NAME = "schedulerName"; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/openjpa/OpenJpaDialect.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/openjpa/OpenJpaDialect.java index 744b37430..44a95ad71 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/openjpa/OpenJpaDialect.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/openjpa/OpenJpaDialect.java @@ -103,7 +103,7 @@ public class OpenJpaDialect extends DefaultJpaDialect { private int savepointCounter = 0; - public OpenJpaTransactionData(OpenJPAEntityManager entityManager) { + OpenJpaTransactionData(OpenJPAEntityManager entityManager) { this.entityManager = entityManager; } @@ -141,7 +141,7 @@ public class OpenJpaDialect extends DefaultJpaDialect { private final OpenJPAEntityManager entityManager; - public OpenJpaConnectionHandle(OpenJPAEntityManager entityManager) { + OpenJpaConnectionHandle(OpenJPAEntityManager entityManager) { this.entityManager = entityManager; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/domain/ReportMailingJobConfigurationRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/domain/ReportMailingJobConfigurationRepository.java index 7dc621989..7d42c8882 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/domain/ReportMailingJobConfigurationRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/reportmailingjob/domain/ReportMailingJobConfigurationRepository.java @@ -27,5 +27,5 @@ public interface ReportMailingJobConfigurationRepository /** * find ReportMailingJobConfiguration by name **/ - ReportMailingJobConfiguration findByName(final String name); + ReportMailingJobConfiguration findByName(String name); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/domain/TwoFactorConfigurationRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/domain/TwoFactorConfigurationRepository.java index 1927736a9..508e9a83c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/domain/TwoFactorConfigurationRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/domain/TwoFactorConfigurationRepository.java @@ -27,7 +27,7 @@ import org.springframework.data.jpa.repository.JpaSpecificationExecutor; public interface TwoFactorConfigurationRepository extends JpaRepository, JpaSpecificationExecutor { - TwoFactorConfiguration findByName(final String name); + TwoFactorConfiguration findByName(String name); @Override List findAll(); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/BasicAuthTenantDetailsServiceJdbc.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/BasicAuthTenantDetailsServiceJdbc.java index e6c85034c..07d1180e8 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/BasicAuthTenantDetailsServiceJdbc.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/BasicAuthTenantDetailsServiceJdbc.java @@ -62,7 +62,7 @@ public class BasicAuthTenantDetailsServiceJdbc implements BasicAuthTenantDetails .append(" ts.deadlock_max_retry_interval as maxIntervalBetweenRetries ")// .append(" from tenants t left join tenant_server_connections ts "); - public TenantMapper(boolean isReport) { + TenantMapper(boolean isReport) { this.isReport = isReport; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java index a7a77a4d5..a8128a485 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java @@ -37,7 +37,7 @@ public final class SQLInjectionValidator { private static final String SQL_PATTERN = "[a-zA-Z_=,\\-'!><.?\"`% ()0-9*\n\r]*"; - public static final void validateSQLInput(final String sqlSearch) { + public static void validateSQLInput(final String sqlSearch) { if (StringUtils.isBlank(sqlSearch)) { return; } @@ -125,7 +125,7 @@ public final class SQLInjectionValidator { } } - public static final void validateAdhocQuery(final String sqlSearch) { + public static void validateAdhocQuery(final String sqlSearch) { if (StringUtils.isBlank(sqlSearch)) { return; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageRepository.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageRepository.java index f2f24ec71..f8fd7f42f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageRepository.java @@ -25,5 +25,5 @@ import org.springframework.data.jpa.repository.JpaSpecificationExecutor; public interface SmsMessageRepository extends JpaRepository, JpaSpecificationExecutor { - Page findByStatusType(final Integer status, Pageable pageable); + Page findByStatusType(Integer status, Pageable pageable); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageStatusType.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageStatusType.java index ef5cb96b1..e9f276428 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageStatusType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessageStatusType.java @@ -52,7 +52,7 @@ public enum SmsMessageStatusType { return enumeration; } - private SmsMessageStatusType(final Integer value, final String code) { + SmsMessageStatusType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobService.java index fb3564957..4fc4b2151 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobService.java @@ -31,14 +31,14 @@ public interface SmsMessageScheduledJobService { /** * sends a batch of SMS messages to the SMS gateway **/ - public void sendMessagesToGateway(); + void sendMessagesToGateway(); /** * sends triggered batch SMS messages to SMS gateway * * @param smsDataMap */ - public void sendTriggeredMessages(Map> smsDataMap); + void sendTriggeredMessages(Map> smsDataMap); /** * Sends a triggered batch of SMS messages to SMS gateway using specified provider. @@ -53,5 +53,5 @@ public interface SmsMessageScheduledJobService { /** * get delivery report from the SMS gateway **/ - public void getDeliveryReports(); + void getDeliveryReports(); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobServiceImpl.java index 339e8196e..6304e59be 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobServiceImpl.java @@ -152,7 +152,7 @@ public class SmsMessageScheduledJobServiceImpl implements SmsMessageScheduledJob private final FineractPlatformTenant tenant; private final Collection apiQueueResourceDatas; - public SmsTask(final FineractPlatformTenant tenant, final Collection apiQueueResourceDatas) { + SmsTask(final FineractPlatformTenant tenant, final Collection apiQueueResourceDatas) { this.tenant = tenant; this.apiQueueResourceDatas = apiQueueResourceDatas; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java index 921eff4c3..9593ec7bd 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java @@ -62,7 +62,7 @@ public class SmsReadPlatformServiceImpl implements SmsReadPlatformService { final String schema; - public SmsMapper() { + SmsMapper() { final StringBuilder sql = new StringBuilder(300); sql.append("smo.id as id, "); sql.append("smo.group_id as groupId, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/PovertyLineService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/PovertyLineService.java index e23f3e59e..bca83167c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/PovertyLineService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/PovertyLineService.java @@ -23,8 +23,8 @@ import org.apache.fineract.infrastructure.survey.data.PpiPovertyLineData; public interface PovertyLineService { - PpiPovertyLineData retrieveAll(final String ppiName); + PpiPovertyLineData retrieveAll(String ppiName); - LikeliHoodPovertyLineData retrieveForLikelihood(final String ppiName, final Long likelihood); + LikeliHoodPovertyLineData retrieveForLikelihood(String ppiName, Long likelihood); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/ReadLikelihoodService.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/ReadLikelihoodService.java index 66628130a..35763accb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/ReadLikelihoodService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/survey/service/ReadLikelihoodService.java @@ -26,7 +26,7 @@ import org.apache.fineract.infrastructure.survey.data.LikelihoodData; */ public interface ReadLikelihoodService { - public List retrieveAll(final String ppiName); + List retrieveAll(String ppiName); - public LikelihoodData retrieve(final Long likelihoodId); + LikelihoodData retrieve(Long likelihoodId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicReadPlatformServiceImpl.java index 97705d8c7..b55eb822b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicReadPlatformServiceImpl.java @@ -44,7 +44,7 @@ public class TopicReadPlatformServiceImpl implements TopicReadPlatformService { private final String schema; - public TopicMapper() { + TopicMapper() { final StringBuilder sqlBuilder = new StringBuilder(200); sqlBuilder.append("t.id as id, t.title as title, t.enabled as enabled, "); sqlBuilder.append("t.entity_id as entityId, t.entity_type as entityType, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicSubscriberReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicSubscriberReadPlatformServiceImpl.java index 6317f11c3..d399ec247 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicSubscriberReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicSubscriberReadPlatformServiceImpl.java @@ -44,7 +44,7 @@ public class TopicSubscriberReadPlatformServiceImpl implements TopicSubscriberRe private final String schema; - public TopicSubscriberMapper() { + TopicSubscriberMapper() { final StringBuilder sqlBuilder = new StringBuilder(200); sqlBuilder.append("ts.id as id, ts.topic_id as topicId, ts.user_id as userId, "); sqlBuilder.append("ts.subscription_date as subscriptionDate from topic_subscriber ts "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/HolidayStatusType.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/HolidayStatusType.java index d862bc417..85abe07a6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/HolidayStatusType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/HolidayStatusType.java @@ -47,7 +47,7 @@ public enum HolidayStatusType { return enumeration; } - private HolidayStatusType(final Integer value, final String code) { + HolidayStatusType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/RescheduleType.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/RescheduleType.java index 291a8e44a..6a9e8e3cb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/RescheduleType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/domain/RescheduleType.java @@ -26,7 +26,7 @@ public enum RescheduleType { private final Integer value; private final String code; - private RescheduleType(Integer value, String code) { + RescheduleType(Integer value, String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/service/HolidayWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/service/HolidayWritePlatformService.java index 482d61d5a..44927c67e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/service/HolidayWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/service/HolidayWritePlatformService.java @@ -27,8 +27,8 @@ public interface HolidayWritePlatformService { CommandProcessingResult updateHoliday(JsonCommand command); - CommandProcessingResult activateHoliday(final Long holidayId); + CommandProcessingResult activateHoliday(Long holidayId); - CommandProcessingResult deleteHoliday(final Long holidayId); + CommandProcessingResult deleteHoliday(Long holidayId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryReadPlatformService.java index e8fd059f7..68c3d84ad 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryReadPlatformService.java @@ -23,5 +23,5 @@ import org.apache.fineract.organisation.provisioning.data.ProvisioningCategoryDa public interface ProvisioningCategoryReadPlatformService { - public Collection retrieveAllProvisionCategories(); + Collection retrieveAllProvisionCategories(); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryWritePlatformService.java index 3f652acb5..556f31711 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCategoryWritePlatformService.java @@ -25,7 +25,7 @@ public interface ProvisioningCategoryWritePlatformService { CommandProcessingResult createProvisioningCateogry(JsonCommand command); - CommandProcessingResult updateProvisioningCategory(final Long categoryId, JsonCommand command); + CommandProcessingResult updateProvisioningCategory(Long categoryId, JsonCommand command); CommandProcessingResult deleteProvisioningCateogry(JsonCommand command); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCriteriaWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCriteriaWritePlatformService.java index 3d6f0a2be..8fa72337d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCriteriaWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/service/ProvisioningCriteriaWritePlatformService.java @@ -25,7 +25,7 @@ public interface ProvisioningCriteriaWritePlatformService { CommandProcessingResult createProvisioningCriteria(JsonCommand command); - CommandProcessingResult updateProvisioningCriteria(final Long categoryId, JsonCommand command); + CommandProcessingResult updateProvisioningCriteria(Long categoryId, JsonCommand command); CommandProcessingResult deleteProvisioningCriteria(Long entryId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffOrganisationalRoleType.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffOrganisationalRoleType.java index ec5750fac..65f5fdd9c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffOrganisationalRoleType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffOrganisationalRoleType.java @@ -29,7 +29,7 @@ public enum StaffOrganisationalRoleType { private final Integer value; private final String code; - private StaffOrganisationalRoleType(final Integer value, final String code) { + StaffOrganisationalRoleType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffRepository.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffRepository.java index 158a0bf20..2f8c20410 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffRepository.java @@ -25,12 +25,12 @@ import org.springframework.data.repository.query.Param; public interface StaffRepository extends JpaRepository, JpaSpecificationExecutor { - public static final String FIND_BY_OFFICE_QUERY = "select s from Staff s where s.id = :id AND s.office.id = :officeId"; + String FIND_BY_OFFICE_QUERY = "select s from Staff s where s.id = :id AND s.office.id = :officeId"; /** * Find staff by officeid. */ @Query(FIND_BY_OFFICE_QUERY) - public Staff findByOffice(@Param("id") Long id, @Param("officeId") Long officeId); + Staff findByOffice(@Param("id") Long id, @Param("officeId") Long officeId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/exception/StaffRoleException.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/exception/StaffRoleException.java index 30f1d774d..69dcf0eee 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/exception/StaffRoleException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/exception/StaffRoleException.java @@ -25,7 +25,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformResourc */ public class StaffRoleException extends AbstractPlatformResourceNotFoundException { - public static enum StaffRole { + public enum StaffRole { LOAN_OFFICER, BRANCH_MANAGER, SAVINGS_OFFICER; diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformService.java index d6af2bf07..4d838eb6a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffReadPlatformService.java @@ -27,7 +27,7 @@ public interface StaffReadPlatformService { Collection retrieveAllStaffForDropdown(Long officeId); - Collection retrieveAllLoanOfficersInOfficeById(final Long officeId); + Collection retrieveAllLoanOfficersInOfficeById(Long officeId); /** * returns all staff in offices that are above the provided officeId. @@ -36,5 +36,5 @@ public interface StaffReadPlatformService { Collection retrieveAllStaff(String sqlSearch, Long officeId, boolean loanOfficersOnly, String status); - Object[] hasAssociatedItems(final Long staffId); + Object[] hasAssociatedItems(Long staffId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/TellerStatus.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/TellerStatus.java index d714d362a..47f1b7866 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/TellerStatus.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/TellerStatus.java @@ -50,7 +50,7 @@ public enum TellerStatus { return status; } - private TellerStatus(final Integer value, final String code) { + TellerStatus(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformService.java index 4f7741a5b..3c75b7c41 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformService.java @@ -62,9 +62,9 @@ public interface TellerManagementReadPlatformService { Collection retrieveCashiersForTellers(String sqlSearch, Long tellerId); Page retrieveCashierTransactions(Long cashierId, boolean includeAllTellers, Date fromDate, Date toDate, - String currencyCode, final SearchParameters searchParameters); + String currencyCode, SearchParameters searchParameters); CashierTransactionsWithSummaryData retrieveCashierTransactionsWithSummary(Long cashierId, boolean includeAllTellers, Date fromDate, - Date toDate, String currencyCode, final SearchParameters searchParameters); + Date toDate, String currencyCode, SearchParameters searchParameters); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerTransactionWritePlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerTransactionWritePlatformService.java index fb4940443..13a6e58e6 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerTransactionWritePlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerTransactionWritePlatformService.java @@ -36,5 +36,5 @@ public interface TellerTransactionWritePlatformService { * the command containing the teller transaction details * @return the result i */ - public CommandProcessingResult createTellerTransaction(JsonCommand command); + CommandProcessingResult createTellerTransaction(JsonCommand command); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/RepaymentRescheduleType.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/RepaymentRescheduleType.java index 7789933ab..8a937b7bf 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/RepaymentRescheduleType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/RepaymentRescheduleType.java @@ -32,7 +32,7 @@ public enum RepaymentRescheduleType { private final Integer value; private final String code; - private RepaymentRescheduleType(final Integer value, final String code) { + RepaymentRescheduleType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/service/WorkingDaysReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/service/WorkingDaysReadPlatformServiceImpl.java index 21756f84b..24800a13b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/service/WorkingDaysReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/service/WorkingDaysReadPlatformServiceImpl.java @@ -49,7 +49,7 @@ public class WorkingDaysReadPlatformServiceImpl implements WorkingDaysReadPlatfo private final String schema; - public WorkingDaysMapper() { + WorkingDaysMapper() { final StringBuilder sqlBuilder = new StringBuilder(100); sqlBuilder.append("w.id as id,w.recurrence as recurrence,w.repayment_rescheduling_enum as status_enum,"); sqlBuilder.append("w.extend_term_daily_repayments as extendTermForDailyRepayments,"); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountAssociationType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountAssociationType.java index 09ba317e1..737d79dd4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountAssociationType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountAssociationType.java @@ -45,7 +45,7 @@ public enum AccountAssociationType { return enumeration; } - private AccountAssociationType(final Integer value, final String code) { + AccountAssociationType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountTransferType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountTransferType.java index 3d717fcb3..8efb15e49 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountTransferType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/AccountTransferType.java @@ -52,7 +52,7 @@ public enum AccountTransferType { return enumeration; } - private AccountTransferType(final Integer value, final String code) { + AccountTransferType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionPriority.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionPriority.java index fe6e70245..10929ac9e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionPriority.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionPriority.java @@ -52,7 +52,7 @@ public enum StandingInstructionPriority { return enumeration; } - private StandingInstructionPriority(final Integer value, final String code) { + StandingInstructionPriority(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionRepository.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionRepository.java index 054888d84..b229abc1d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionRepository.java @@ -29,23 +29,22 @@ import org.springframework.data.repository.query.Param; public interface StandingInstructionRepository extends JpaRepository, JpaSpecificationExecutor { - public static final String FIND_BY_LOAN_AND_STATUS_QUERY = "select accountTransferStandingInstruction " + String FIND_BY_LOAN_AND_STATUS_QUERY = "select accountTransferStandingInstruction " + "from AccountTransferStandingInstruction accountTransferStandingInstruction " + "where accountTransferStandingInstruction.status = :status " + "and (accountTransferStandingInstruction.accountTransferDetails.toLoanAccount = :loan " + "or accountTransferStandingInstruction.accountTransferDetails.fromLoanAccount = :loan)"; - public static final String FIND_BY_SAVINGS_AND_STATUS_QUERY = "select accountTransferStandingInstruction " + String FIND_BY_SAVINGS_AND_STATUS_QUERY = "select accountTransferStandingInstruction " + "from AccountTransferStandingInstruction accountTransferStandingInstruction " + "where accountTransferStandingInstruction.status = :status " + "and (accountTransferStandingInstruction.accountTransferDetails.toSavingsAccount = :savingsAccount " + "or accountTransferStandingInstruction.accountTransferDetails.fromSavingsAccount = :savingsAccount)"; @Query(FIND_BY_LOAN_AND_STATUS_QUERY) - public Collection findByLoanAccountAndStatus(@Param("loan") Loan loan, - @Param("status") Integer status); + Collection findByLoanAccountAndStatus(@Param("loan") Loan loan, @Param("status") Integer status); @Query(FIND_BY_SAVINGS_AND_STATUS_QUERY) - public Collection findBySavingsAccountAndStatus( - @Param("savingsAccount") SavingsAccount savingsAccount, @Param("status") Integer status); + Collection findBySavingsAccountAndStatus(@Param("savingsAccount") SavingsAccount savingsAccount, + @Param("status") Integer status); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionStatus.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionStatus.java index cd452ed46..218453901 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionStatus.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionStatus.java @@ -48,7 +48,7 @@ public enum StandingInstructionStatus { return enumeration; } - private StandingInstructionStatus(final Integer value, final String code) { + StandingInstructionStatus(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionType.java index c266bb2ac..f7509af58 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionType.java @@ -44,7 +44,7 @@ public enum StandingInstructionType { return enumeration; } - private StandingInstructionType(final Integer value, final String code) { + StandingInstructionType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java index 69ff14b83..4fbf9b61a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountAssociationsReadPlatformServiceImpl.java @@ -137,7 +137,7 @@ public class AccountAssociationsReadPlatformServiceImpl implements AccountAssoci private final String schemaSql; - public AccountAssociationsMapper() { + AccountAssociationsMapper() { final StringBuilder sqlBuilder = new StringBuilder(); sqlBuilder.append("aa.id as id,"); // sqlBuilder.append("savingsAccount.id as savingsAccountId, diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersReadPlatformServiceImpl.java index b71ba0409..56dfe35c8 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersReadPlatformServiceImpl.java @@ -270,7 +270,7 @@ public class AccountTransfersReadPlatformServiceImpl implements AccountTransfers private final String schemaSql; - public AccountTransfersMapper() { + AccountTransfersMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append("att.id as id, att.is_reversed as isReversed,"); sqlBuilder.append("att.transaction_date as transferDate, att.amount as transferAmount,"); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformService.java index fdbf47486..ce542e41b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformService.java @@ -28,7 +28,7 @@ public interface PortfolioAccountReadPlatformService { PortfolioAccountData retrieveOne(Long accountId, Integer accountTypeId, String currencyCode); - Collection retrieveAllForLookup(final PortfolioAccountDTO portfolioAccountDTO); + Collection retrieveAllForLookup(PortfolioAccountDTO portfolioAccountDTO); PortfolioAccountData retrieveOneByPaidInAdvance(Long accountId, Integer accountTypeId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java index c6904e86c..1c7c0d19a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java @@ -169,7 +169,7 @@ public class PortfolioAccountReadPlatformServiceImpl implements PortfolioAccount private final String schemaSql; - public PortfolioSavingsAccountMapper() { + PortfolioSavingsAccountMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append("sa.id as id, sa.account_no as accountNo, sa.external_id as externalId, "); @@ -231,7 +231,7 @@ public class PortfolioAccountReadPlatformServiceImpl implements PortfolioAccount private final String schemaSql; - public PortfolioLoanAccountMapper() { + PortfolioLoanAccountMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append("la.id as id, la.account_no as accountNo, la.external_id as externalId, "); @@ -295,7 +295,7 @@ public class PortfolioAccountReadPlatformServiceImpl implements PortfolioAccount private final String schemaSql; - public PortfolioLoanAccountRefundByTransferMapper() { + PortfolioLoanAccountRefundByTransferMapper() { final StringBuilder amountQueryString = new StringBuilder(400); amountQueryString.append("(select (SUM(ifnull(mr.principal_completed_derived, 0)) +"); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionReadPlatformServiceImpl.java index 9f02adde1..c62ababe3 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionReadPlatformServiceImpl.java @@ -362,7 +362,7 @@ public class StandingInstructionReadPlatformServiceImpl implements StandingInstr private final String schemaSql; - public StandingInstructionMapper() { + StandingInstructionMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append("atsi.id as id,atsi.name as name, atsi.priority as priority,"); sqlBuilder.append("atsi.status as status, atsi.instruction_type as instructionType,"); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java index e11cf508e..892a6fbcb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java @@ -318,7 +318,7 @@ public class AccountDetailsReadPlatformServiceJpaRepositoryImpl implements Accou final String schemaSql; - public SavingsAccountSummaryDataMapper() { + SavingsAccountSummaryDataMapper() { final StringBuilder accountsSummary = new StringBuilder(); accountsSummary.append("sa.id as id, sa.account_no as accountNo, sa.external_id as externalId, sa.status_enum as statusEnum, "); accountsSummary.append("sa.account_type_enum as accountType, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/service/AccountsCommandsService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/service/AccountsCommandsService.java index 097a8528b..941ff227e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/service/AccountsCommandsService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/service/AccountsCommandsService.java @@ -20,5 +20,5 @@ package org.apache.fineract.portfolio.accounts.service; public interface AccountsCommandsService { - public Object handleCommand(Long accountId, String command, String jsonBody); + Object handleCommand(Long accountId, String command, String jsonBody); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/FieldConfigurationReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/FieldConfigurationReadPlatformService.java index dc69eaf57..89823386f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/FieldConfigurationReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/FieldConfigurationReadPlatformService.java @@ -24,7 +24,7 @@ import org.apache.fineract.portfolio.address.data.FieldConfigurationData; public interface FieldConfigurationReadPlatformService { - public Collection retrieveFieldConfiguration(String entity); + Collection retrieveFieldConfiguration(String entity); List retrieveFieldConfigurationList(String entity); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/CalendarConstants.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/CalendarConstants.java index 6152477f1..8c00de90d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/CalendarConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/CalendarConstants.java @@ -29,7 +29,7 @@ public final class CalendarConstants { public static final String CALENDAR_RESOURCE_NAME = "calendar"; - public static enum CalendarSupportedParameters { + public enum CalendarSupportedParameters { CALENDAR_ID("id"), ENTITY_TYPE("entityType"), ENTITY_ID("entityId"), TITLE("title"), DESCRIPTION("description"), LOCATION( "location"), START_DATE("startDate"), END_DATE("endDate"), CREATED_DATE("createdDate"), DURATION("duration"), TYPE_ID( @@ -45,7 +45,7 @@ public final class CalendarConstants { private final String value; - private CalendarSupportedParameters(final String value) { + CalendarSupportedParameters(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarEntityType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarEntityType.java index 4617e7929..0e9fd9f94 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarEntityType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarEntityType.java @@ -35,7 +35,7 @@ public enum CalendarEntityType { private final Integer value; private final String code; - private CalendarEntityType(final Integer value, final String code) { + CalendarEntityType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarRemindBy.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarRemindBy.java index 39e1fd44b..b61d7f254 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarRemindBy.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarRemindBy.java @@ -28,7 +28,7 @@ public enum CalendarRemindBy { private final Integer value; private final String code; - private CalendarRemindBy(final Integer value, final String code) { + CalendarRemindBy(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarType.java index c1fa7df23..09535078d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/CalendarType.java @@ -29,7 +29,7 @@ public enum CalendarType { private final Integer value; private final String code; - private CalendarType(final Integer value, final String code) { + CalendarType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java index 1f5f1cea7..41452274b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java @@ -393,7 +393,7 @@ public final class CalendarUtils { private final String code; private final Integer value; - private DayNameEnum(final Integer value, final String code) { + DayNameEnum(final Integer value, final String code) { this.value = value; this.code = code; } @@ -416,14 +416,14 @@ public final class CalendarUtils { } } - public static enum NthDayNameEnum { + public enum NthDayNameEnum { ONE(1, "First"), TWO(2, "Second"), THREE(3, "Third"), FOUR(4, "Fourth"), FIVE(5, "Fifth"), LAST(-1, "Last"), INVALID(0, "Invalid"); private final String code; private final Integer value; - private NthDayNameEnum(final Integer value, final String code) { + NthDayNameEnum(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/domain/ChargePaymentMode.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/domain/ChargePaymentMode.java index 5e0940f3a..9c764b216 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/domain/ChargePaymentMode.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/domain/ChargePaymentMode.java @@ -26,7 +26,7 @@ public enum ChargePaymentMode { private final Integer value; private final String code; - private ChargePaymentMode(final Integer value, final String code) { + ChargePaymentMode(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBePayedException.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBePayedException.java index 44a81f52f..0f4df09cf 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBePayedException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBePayedException.java @@ -23,7 +23,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class LoanChargeCannotBePayedException extends AbstractPlatformDomainRuleException { /*** enum of reasons of why Loan Charge cannot be waived **/ - public static enum LoanChargeCannotBePayedReason { + public enum LoanChargeCannotBePayedReason { ALREADY_PAID, ALREADY_WAIVED, LOAN_INACTIVE, CHARGE_NOT_ACCOUNT_TRANSFER, CHARGE_NOT_PAYABLE; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeUpdatedException.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeUpdatedException.java index 68ccbef6d..2bdf6fda0 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeUpdatedException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeUpdatedException.java @@ -23,7 +23,7 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR public class LoanChargeCannotBeUpdatedException extends AbstractPlatformDomainRuleException { /*** enum of reasons of why Loan Charge cannot be waived **/ - public static enum LoanChargeCannotBeUpdatedReason { + public enum LoanChargeCannotBeUpdatedReason { ALREADY_PAID, ALREADY_WAIVED, LOAN_NOT_IN_SUBMITTED_AND_PENDING_APPROVAL_STAGE; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformService.java index 0f8818c40..fbec2a84f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformService.java @@ -53,7 +53,7 @@ public interface ChargeReadPlatformService { * Excludes Given List of Charge Types from the response * @return */ - Collection retrieveLoanAccountApplicableCharges(final Long loanId, ChargeTimeType[] excludeChargeTimes); + Collection retrieveLoanAccountApplicableCharges(Long loanId, ChargeTimeType[] excludeChargeTimes); /** * Returns all charges applicable for a given loan product (filter based on Currency of Selected Loan Product) @@ -62,7 +62,7 @@ public interface ChargeReadPlatformService { * Excludes Given List of Charge Types from the response * @return */ - Collection retrieveLoanProductApplicableCharges(final Long loanProductId, ChargeTimeType[] excludeChargeTimes); + Collection retrieveLoanProductApplicableCharges(Long loanProductId, ChargeTimeType[] excludeChargeTimes); /** * Returns all Penalties applicable for loans @@ -120,5 +120,5 @@ public interface ChargeReadPlatformService { */ Collection retrieveSharesApplicableCharges(); - public Collection retrieveShareProductCharges(final Long shareProductId); + Collection retrieveShareProductCharges(Long shareProductId); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java index 27f877802..b2554b12e 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java @@ -23,7 +23,7 @@ import org.springframework.data.jpa.repository.JpaSpecificationExecutor; import org.springframework.data.jpa.repository.Query; import org.springframework.data.repository.query.Param; -abstract interface ClientRepository extends JpaRepository, JpaSpecificationExecutor { +interface ClientRepository extends JpaRepository, JpaSpecificationExecutor { String FIND_CLIENT_BY_ACCOUNT_NUMBER = "select client from Client client where client.accountNumber = :accountNumber"; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientStatus.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientStatus.java index 87c484527..46388584c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientStatus.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientStatus.java @@ -92,7 +92,7 @@ public enum ClientStatus { return clientStatus; } - private ClientStatus(final Integer value, final String code) { + ClientStatus(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransactionType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransactionType.java index 952644c0d..eda1fa726 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransactionType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientTransactionType.java @@ -29,7 +29,7 @@ public enum ClientTransactionType { private final Integer value; private final String code; - private ClientTransactionType(final Integer value, final String code) { + ClientTransactionType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/LegalForm.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/LegalForm.java index 26f17e6f1..bd29d5741 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/LegalForm.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/LegalForm.java @@ -30,7 +30,7 @@ public enum LegalForm { private final Integer value; private final String code; - private LegalForm(final Integer value, final String code) { + LegalForm(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientAddressReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientAddressReadPlatformService.java index 31d4b884a..a8512c16f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientAddressReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientAddressReadPlatformService.java @@ -23,6 +23,6 @@ import org.apache.fineract.portfolio.address.data.ClientAddressData; public interface ClientAddressReadPlatformService { - public Collection retrieveClientAddrConfiguration(String entity); + Collection retrieveClientAddrConfiguration(String entity); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientIdentifierReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientIdentifierReadPlatformServiceImpl.java index c096718b7..3ed3b92dd 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientIdentifierReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientIdentifierReadPlatformServiceImpl.java @@ -88,7 +88,7 @@ public class ClientIdentifierReadPlatformServiceImpl implements ClientIdentifier private static final class ClientIdentityMapper implements RowMapper { - public ClientIdentityMapper() {} + ClientIdentityMapper() {} public String schema() { return "ci.id as id, ci.client_id as clientId, ci.document_type_id as documentTypeId, ci.status as status, ci.document_key as documentKey," diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java index 8b5237860..5f9f37af4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java @@ -42,7 +42,7 @@ public interface ClientReadPlatformService { Collection retrieveActiveClientMembersOfGroup(Long groupId); - Collection retrieveActiveClientMembersOfCenter(final Long centerId); + Collection retrieveActiveClientMembersOfCenter(Long centerId); ClientData retrieveAllNarrations(String clientNarrations); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java index cddd2c5a6..024461d73 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java @@ -754,7 +754,7 @@ public class ClientReadPlatformServiceImpl implements ClientReadPlatformService private final String schema; - public ClientLookupMapper() { + ClientLookupMapper() { final StringBuilder builder = new StringBuilder(200); builder.append("c.id as id, c.display_name as displayName, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/api/CollateralApiConstants.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/api/CollateralApiConstants.java index 51a11945e..d3ea569ef 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/api/CollateralApiConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/api/CollateralApiConstants.java @@ -39,7 +39,7 @@ public final class CollateralApiConstants { private final String value; - private CollateralJSONinputParams(final String value) { + CollateralJSONinputParams(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/service/CollectionSheetReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/service/CollectionSheetReadPlatformServiceImpl.java index e131927e4..c83062729 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/service/CollectionSheetReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/collectionsheet/service/CollectionSheetReadPlatformServiceImpl.java @@ -802,7 +802,7 @@ public class CollectionSheetReadPlatformServiceImpl implements CollectionSheetRe private final String sql; - public IndividualMandatorySavingsCollectionsheetExtractor(final boolean checkForOfficeId, final boolean checkforStaffId) { + IndividualMandatorySavingsCollectionsheetExtractor(final boolean checkForOfficeId, final boolean checkforStaffId) { final StringBuilder sb = new StringBuilder(400); sb.append( diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/BusinessEventNotificationConstants.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/BusinessEventNotificationConstants.java index 76fb6e207..e7fa68369 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/BusinessEventNotificationConstants.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/BusinessEventNotificationConstants.java @@ -69,7 +69,7 @@ public class BusinessEventNotificationConstants { private final String value; - private BusinessEvents(final String value) { + BusinessEvents(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java index 85bea15a9..edb24f43b 100755 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java @@ -46,7 +46,7 @@ public enum ConditionType { return type; } - private ConditionType(final Integer value, final String code) { + ConditionType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/DaysInMonthType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/DaysInMonthType.java index 52590194f..32d58ccbc 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/DaysInMonthType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/DaysInMonthType.java @@ -38,7 +38,7 @@ public enum DaysInMonthType { private final Integer value; private final String code; - private DaysInMonthType(final Integer value, final String code) { + DaysInMonthType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/NthDayType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/NthDayType.java index 4e5d5ff00..a9a29d361 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/NthDayType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/NthDayType.java @@ -26,7 +26,7 @@ public enum NthDayType { private final Integer value; private final String code; - private NthDayType(Integer value, String code) { + NthDayType(Integer value, String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupTypes.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupTypes.java index 236f6df29..a23452415 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupTypes.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupTypes.java @@ -31,7 +31,7 @@ public enum GroupTypes { private final String code; private final String value; - private GroupTypes(final Long id, final String code, final String value) { + GroupTypes(final Long id, final String code, final String value) { this.id = id; this.code = code; this.value = value; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java index 2b0ce4eb6..bbbfeb105 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java @@ -204,7 +204,7 @@ public class CenterReadPlatformServiceImpl implements CenterReadPlatformService private final String schemaSql; - public CenterCalendarDataMapper() { + CenterCalendarDataMapper() { schemaSql = "select ce.id as id, g.account_no as accountNo," + "ce.display_name as name, g.office_id as officeId, g.staff_id as staffId, s.display_name as staffName," @@ -278,7 +278,7 @@ public class CenterReadPlatformServiceImpl implements CenterReadPlatformService private final String schemaSql; - public GroupDataMapper() { + GroupDataMapper() { this.schemaSql = SQL_QUERY; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java index 8f23c28d4..c048ec372 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java @@ -253,7 +253,7 @@ public class GroupReadPlatformServiceImpl implements GroupReadPlatformService { private static final class GroupLookupDataMapper implements RowMapper { - public final String schema() { + public String schema() { return "g.id as id, g.account_no as accountNo, g.display_name as displayName from m_group g where g.level_id = 2 "; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanStatus.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanStatus.java index b2056ad59..9482d67ad 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanStatus.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanStatus.java @@ -80,7 +80,7 @@ public enum LoanStatus { return enumeration; } - private LoanStatus(final Integer value, final String code) { + LoanStatus(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSubStatus.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSubStatus.java index b157b6e0e..c773340e3 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSubStatus.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSubStatus.java @@ -39,7 +39,7 @@ public enum LoanSubStatus { return enumeration; } - private LoanSubStatus(final Integer value, final String code) { + LoanSubStatus(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionType.java index efb777e55..0c2851cd5 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionType.java @@ -55,7 +55,7 @@ public enum LoanTransactionType { private final Integer value; private final String code; - private LoanTransactionType(final Integer value, final String code) { + LoanTransactionType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/LoanRepaymentScheduleTransactionProcessor.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/LoanRepaymentScheduleTransactionProcessor.java index 21df78a24..36bff0f13 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/LoanRepaymentScheduleTransactionProcessor.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/LoanRepaymentScheduleTransactionProcessor.java @@ -48,7 +48,7 @@ public interface LoanRepaymentScheduleTransactionProcessor { boolean isInterestFirstRepaymentScheduleTransactionProcessor(); void handleRefund(LoanTransaction loanTransaction, MonetaryCurrency currency, List installments, - final Set charges); + Set charges); void processTransactionsFromDerivedFields(List transactionsPostDisbursement, MonetaryCurrency currency, List installments, Set charges); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/domain/GuarantorFundStatusType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/domain/GuarantorFundStatusType.java index 4396e219a..e38a7e7e7 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/domain/GuarantorFundStatusType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/domain/GuarantorFundStatusType.java @@ -52,7 +52,7 @@ public enum GuarantorFundStatusType { return enumeration; } - private GuarantorFundStatusType(final Integer value, final String code) { + GuarantorFundStatusType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/service/GuarantorReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/service/GuarantorReadPlatformServiceImpl.java index 984772a75..78971fc73 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/service/GuarantorReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/guarantor/service/GuarantorReadPlatformServiceImpl.java @@ -181,7 +181,7 @@ public class GuarantorReadPlatformServiceImpl implements GuarantorReadPlatformSe private final String sql; private final GuarantorTransactionMapper guarantorTransactionMapper; - public GuarantorFundingMapper(final GuarantorTransactionMapper guarantorTransactionMapper) { + GuarantorFundingMapper(final GuarantorTransactionMapper guarantorTransactionMapper) { this.guarantorTransactionMapper = guarantorTransactionMapper; StringBuilder sb = new StringBuilder(" gfd.id as gfdId,"); sb.append(" gfd.amount as amount, gfd.amount_released_derived as amountReleased, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java index 193017059..62f6158be 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java @@ -2681,7 +2681,7 @@ public abstract class AbstractLoanScheduleGenerator implements LoanScheduleGener private final LocalDate scheduledDueDate; private final ArrayList variationsData; - public LoanTermVariationParams(final boolean skipPeriod, final boolean recalculateAmounts, final LocalDate scheduledDueDate, + LoanTermVariationParams(final boolean skipPeriod, final boolean recalculateAmounts, final LocalDate scheduledDueDate, final ArrayList variationsData) { this.skipPeriod = skipPeriod; this.recalculateAmounts = recalculateAmounts; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/rescheduleloan/service/LoanRescheduleRequestReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/rescheduleloan/service/LoanRescheduleRequestReadPlatformServiceImpl.java index 884736a0b..8718d91ab 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/rescheduleloan/service/LoanRescheduleRequestReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/rescheduleloan/service/LoanRescheduleRequestReadPlatformServiceImpl.java @@ -64,7 +64,7 @@ public class LoanRescheduleRequestReadPlatformServiceImpl implements LoanResched private final String schema; - public LoanRescheduleRequestRowMapper() { + LoanRescheduleRequestRowMapper() { final StringBuilder sqlBuilder = new StringBuilder(200); sqlBuilder.append("lr.id as id, lr.loan_id as loanId, lr.status_enum as statusEnum, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanArrearsAgingServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanArrearsAgingServiceImpl.java index 5fd76746c..f439e4185 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanArrearsAgingServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanArrearsAgingServiceImpl.java @@ -419,7 +419,7 @@ public class LoanArrearsAgingServiceImpl implements LoanArrearsAgingService, Bus private final String schema; - public OriginalScheduleExtractor(final String loanIdsAsString) { + OriginalScheduleExtractor(final String loanIdsAsString) { final StringBuilder scheduleDetail = new StringBuilder(); scheduleDetail.append("select ml.id as loanId, mr.duedate as dueDate, mr.principal_amount as principalAmount, "); scheduleDetail.append( diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeReadPlatformServiceImpl.java index 67e3296e7..ce06559fb 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeReadPlatformServiceImpl.java @@ -417,7 +417,7 @@ public class LoanChargeReadPlatformServiceImpl implements LoanChargeReadPlatform private final String schemaSql; - public LoanInstallmentChargeAccrualMapper() { + LoanInstallmentChargeAccrualMapper() { StringBuilder sb = new StringBuilder(50); sb.append(" lsi.installment as installmentNumber, lsi.duedate as dueAsOfDate, "); sb.append("lic.amount_outstanding_derived as amountOutstanding,"); @@ -469,7 +469,7 @@ public class LoanChargeReadPlatformServiceImpl implements LoanChargeReadPlatform private final String schemaSql; private final Map installmentChargeDatas; - public LoanInstallmentChargeUnRecognizedIncomeMapper(final Map installmentChargeDatas) { + LoanInstallmentChargeUnRecognizedIncomeMapper(final Map installmentChargeDatas) { this.installmentChargeDatas = installmentChargeDatas; StringBuilder sb = new StringBuilder(50); sb.append(" cpb.installment_number as installmentNumber, "); @@ -520,7 +520,7 @@ public class LoanChargeReadPlatformServiceImpl implements LoanChargeReadPlatform private final String schemaSql; - public LoanChargesPaidByMapper() { + LoanChargesPaidByMapper() { StringBuilder sb = new StringBuilder(100); sb.append("lcp.id as id, lcp.loan_charge_id as chargeId, "); sb.append("lcp.amount as amount, "); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java index 87ec1a053..f477dc31a 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java @@ -1026,7 +1026,7 @@ public class LoanReadPlatformServiceImpl implements LoanReadPlatformService { private boolean excludePastUndisbursed; private BigDecimal totalPaidFeeCharges; - public LoanScheduleResultSetExtractor(final RepaymentScheduleRelatedLoanData repaymentScheduleRelatedLoanData, + LoanScheduleResultSetExtractor(final RepaymentScheduleRelatedLoanData repaymentScheduleRelatedLoanData, Collection disbursementData, boolean isInterestRecalculationEnabled, BigDecimal totalPaidFeeCharges) { this.currency = repaymentScheduleRelatedLoanData.getCurrency(); this.disbursement = repaymentScheduleRelatedLoanData.disbursementData(); diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanSchedularService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanSchedularService.java index a85615bd4..0635acd46 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanSchedularService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanSchedularService.java @@ -27,5 +27,5 @@ public interface LoanSchedularService { void recalculateInterest() throws JobExecutionException; - void recalculateInterest(@SuppressWarnings("unused") final Map jobParameters); + void recalculateInterest(@SuppressWarnings("unused") Map jobParameters); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductValueConditionType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductValueConditionType.java index 5ff421386..015119771 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductValueConditionType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductValueConditionType.java @@ -28,7 +28,7 @@ public enum LoanProductValueConditionType { private final Integer value; private final String code; - private LoanProductValueConditionType(final Integer value, final String code) { + LoanProductValueConditionType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/RecalculationFrequencyType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/RecalculationFrequencyType.java index 7b8d834bc..13cc32404 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/RecalculationFrequencyType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/RecalculationFrequencyType.java @@ -48,7 +48,7 @@ public enum RecalculationFrequencyType { return type; } - private RecalculationFrequencyType(final Integer value, final String code) { + RecalculationFrequencyType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/meeting/attendance/AttendanceType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/meeting/attendance/AttendanceType.java index b019b5d4d..fae510526 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/meeting/attendance/AttendanceType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/meeting/attendance/AttendanceType.java @@ -35,7 +35,7 @@ public enum AttendanceType { private final Integer value; private final String code; - private AttendanceType(final Integer value, final String code) { + AttendanceType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/products/service/ProductCommandsService.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/products/service/ProductCommandsService.java index b5adf3a72..d93735759 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/products/service/ProductCommandsService.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/products/service/ProductCommandsService.java @@ -20,5 +20,5 @@ package org.apache.fineract.portfolio.products.service; public interface ProductCommandsService { - public Object handleCommand(Long productId, String command, String jsonBody); + Object handleCommand(Long productId, String command, String jsonBody); } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountOnClosureType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountOnClosureType.java index 61da52012..72c5e4c41 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountOnClosureType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountOnClosureType.java @@ -38,7 +38,7 @@ public enum DepositAccountOnClosureType { private final Integer value; private final String code; - private DepositAccountOnClosureType(final Integer value, final String code) { + DepositAccountOnClosureType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountType.java index b038dd309..9a1218a8f 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountType.java @@ -36,7 +36,7 @@ public enum DepositAccountType { private final String code; private static final String SPACE = " "; - private DepositAccountType(final Integer value, final String code) { + DepositAccountType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/SavingsPostingInterestPeriodType.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/SavingsPostingInterestPeriodType.java index c2e2a6828..204ab96b0 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/SavingsPostingInterestPeriodType.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/SavingsPostingInterestPeriodType.java @@ -35,7 +35,7 @@ public enum SavingsPostingInterestPeriodType { private final Integer value; private final String code; - private SavingsPostingInterestPeriodType(final Integer value, final String code) { + SavingsPostingInterestPeriodType(final Integer value, final String code) { this.value = value; this.code = code; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsEvent.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsEvent.java index 817bc8512..ca5779939 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsEvent.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsEvent.java @@ -40,7 +40,7 @@ public enum SavingsEvent { private final String value; - private SavingsEvent(final String value) { + SavingsEvent(final String value) { this.value = value; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java index 1fb523890..f3dae1c23 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java @@ -971,7 +971,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead private final String schemaSql; - public SavingsAccountTransactionsMapper() { + SavingsAccountTransactionsMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append("tr.id as transactionId, tr.transaction_type_enum as transactionType, "); @@ -1383,7 +1383,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead private final String schemaSql; - public DepositAccountForMaturityMapper() { + DepositAccountForMaturityMapper() { final StringBuilder sqlBuilder = new StringBuilder(200); sqlBuilder.append("da.id as id, "); sqlBuilder.append("da.account_no as accountNumber, "); @@ -1477,7 +1477,7 @@ public class DepositAccountReadPlatformServiceImpl implements DepositAccountRead private final String schemaSql; - public AccountTransferMapper() { + AccountTransferMapper() { final StringBuilder sqlBuilder = new StringBuilder(400); sqlBuilder.append( "sa.id as fromAcc ,aa.linked_savings_account_id as toAcc,st.amount as amount, st.transaction_date as transactionDate ")