FINERACT-2081: Fix linked account validation

This commit is contained in:
Adam Saghy
2024-06-10 20:07:38 +02:00
parent 6f62699cb3
commit a6b69ec029
@@ -1531,12 +1531,11 @@ public final class LoanApplicationValidator {
public void validateLinkedSavingsAccount(final JsonElement element, DataValidatorBuilder baseDataValidator) { public void validateLinkedSavingsAccount(final JsonElement element, DataValidatorBuilder baseDataValidator) {
final boolean linkedAccountIdWasProvided = this.fromApiJsonHelper.parameterExists(LoanApiConstants.linkAccountIdParameterName, final boolean linkedAccountIdWasProvided = this.fromApiJsonHelper.parameterExists(LoanApiConstants.linkAccountIdParameterName,
element); element);
if (linkedAccountIdWasProvided) { final Long linkedAccountId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.linkAccountIdParameterName, element);
final Long linkAccountId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.linkAccountIdParameterName, element); if (linkedAccountIdWasProvided && linkedAccountId != null) {
baseDataValidator.reset().parameter(LoanApiConstants.linkAccountIdParameterName).value(linkAccountId).ignoreIfNull() baseDataValidator.reset().parameter(LoanApiConstants.linkAccountIdParameterName).value(linkedAccountId).ignoreIfNull()
.longGreaterThanZero(); .longGreaterThanZero();
final Long linkedAccountId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.linkAccountIdParameterName, element);
final SavingsAccount savingsAccount = savingsAccountRepository.findOneWithNotFoundDetection(linkedAccountId); final SavingsAccount savingsAccount = savingsAccountRepository.findOneWithNotFoundDetection(linkedAccountId);
final Long clientId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.clientIdParameterName, element); final Long clientId = this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.clientIdParameterName, element);
if (savingsAccount.isNotActive()) { if (savingsAccount.isNotActive()) {