From a6dcba11cff8ffc5f1077ab9108dc08425cb506e Mon Sep 17 00:00:00 2001
From: John Woodlock <john.woodlock@gmail.com>
Date: Thu, 18 Apr 2013 19:41:33 +0100
Subject: [PATCH] wip mifosx-195 maintenance changes

---
 .../core/data/DataValidatorBuilder.java       |  2 +-
 .../dataqueries/domain/Report.java            | 34 ++++++++++++-------
 2 files changed, 22 insertions(+), 14 deletions(-)

diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/data/DataValidatorBuilder.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/data/DataValidatorBuilder.java
index 8162cb0d5..0fac1f6ce 100644
--- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/data/DataValidatorBuilder.java
+++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/data/DataValidatorBuilder.java
@@ -385,7 +385,7 @@ public class DataValidatorBuilder {
     }
     
     public DataValidatorBuilder cantBeBlankWhenParameterProvidedIs(final String parameterName, final Object parameterValue) {
-        if (value != null) { return this; }
+        if (StringUtils.isNotBlank(value.toString())) { return this; }
 
         StringBuilder validationErrorCode = new StringBuilder("validation.msg.").append(resource).append(".").append(parameter)
                 .append(".must.be.provided.when.").append(parameterName).append(".is.").append(parameterValue);
diff --git a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/domain/Report.java b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/domain/Report.java
index bf43b7aeb..8804fed8c 100644
--- a/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/domain/Report.java
+++ b/mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/domain/Report.java
@@ -194,27 +194,35 @@ public class Report extends AbstractPersistable<Long> {
 				.parameter("reportType")
 				.value(this.reportType)
 				.notBlank()
-				.notExceedingLengthOf(20)
 				.isOneOfTheseValues(
 						new Object[] { "Table", "Pentaho", "Chart" });
 
 		baseDataValidator.reset().parameter("reportSubType")
 				.value(this.reportSubType).notExceedingLengthOf(20);
 
-		if (this.reportType != null && this.reportType.equals("Chart")) {
-			baseDataValidator
-					.reset()
-					.parameter("reportSubType")
-					.value(this.reportSubType)
-					.cantBeBlankWhenParameterProvidedIs("reportType",
-							this.reportType)
-					.isOneOfTheseValues(new Object[] { "Bar", "Pie" });
+		if (StringUtils.isNotBlank(this.reportType)) {
+			if (this.reportType.equals("Chart")) {
+				baseDataValidator
+						.reset()
+						.parameter("reportSubType")
+						.value(this.reportSubType)
+						.cantBeBlankWhenParameterProvidedIs("reportType",
+								this.reportType)
+						.isOneOfTheseValues(new Object[] { "Bar", "Pie" });
+			} else {
+				baseDataValidator
+						.reset()
+						.parameter("reportSubType")
+						.value(this.reportSubType)
+						.mustBeBlankWhenParameterProvidedIs("reportType",
+								this.reportType);
+			}
 		}
 
-		baseDataValidator.reset().parameter("reportCategory").value(this.reportCategory)
-				.notExceedingLengthOf(45);
+		baseDataValidator.reset().parameter("reportCategory")
+				.value(this.reportCategory).notExceedingLengthOf(45);
 
-		if (this.reportType != null) {
+		if (StringUtils.isNotBlank(this.reportType)) {
 			if ((this.reportType.equals("Table"))
 					|| (this.reportType.equals("Chart"))) {
 				baseDataValidator
@@ -247,5 +255,5 @@ public class Report extends AbstractPersistable<Long> {
 	public String getReportName() {
 		return reportName;
 	}
-	
+
 }